From patchwork Wed Apr 10 10:04:38 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastian Hecht X-Patchwork-Id: 2420261 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork2.kernel.org (Postfix) with ESMTP id 6B29BDF2E5 for ; Wed, 10 Apr 2013 10:05:01 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UPrtd-0004mq-9e; Wed, 10 Apr 2013 10:04:53 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UPrta-0000wg-FL; Wed, 10 Apr 2013 10:04:50 +0000 Received: from mail-bk0-x22e.google.com ([2a00:1450:4008:c01::22e]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UPrtX-0000wM-FA for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2013 10:04:48 +0000 Received: by mail-bk0-f46.google.com with SMTP id je9so130620bkc.5 for ; Wed, 10 Apr 2013 03:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=+HSSu5E1ZeJH0jPjsXZidR+30M+WcYr333hMkb4c2Mk=; b=o4sv4yTpLpPILElBGhBXbzUHsjU3oXo1QIcezSMt3W5YaT/6KQ+IViXx2hU/4yAk0R PKTuqNGOwvx26Mj90Sa7rFqGeqyVj4mB9zWU3vSPgrnnafFzFqpNtFzy9QEix2XSoyiU 8247VVmg6voR+KYDlWIT89rLe03exhMZMs0IF8Zsro7p5vWAnqzMEueWBmtEGB2Wj69L 847QJrPCrfSmg+PM29ekWacgxa3rr+aZxcFTwCOzrGTZNYDeko5vJjnvvTFHOrkG5Fx5 Fw/qcErMTt+LEYhEKV5TdSdHbxE6QbJ00aE0uqfkvk+c6N8v0LLgDLtK8WrgeGb4E9Tf M2mA== X-Received: by 10.204.231.6 with SMTP id jo6mr479049bkb.30.1365588284399; Wed, 10 Apr 2013 03:04:44 -0700 (PDT) Received: from localhost.localdomain (g229017229.adsl.alicedsl.de. [92.229.17.229]) by mx.google.com with ESMTPS id ej2sm4144637bkb.14.2013.04.10.03.04.43 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 10 Apr 2013 03:04:43 -0700 (PDT) From: Bastian Hecht To: linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org Subject: [PATCH] ARM: hw_breakpoint: Do not use __cpuinitdata for dbg_cpu_pm_nb Date: Wed, 10 Apr 2013 12:04:38 +0200 Message-Id: <1365588278-5185-1-git-send-email-hechtb+renesas@gmail.com> X-Mailer: git-send-email 1.7.9.5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130410_060447_689524_8DBE7A7E X-CRM114-Status: GOOD ( 15.39 ) X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (hechtb[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Magnus Damm , Simon Horman , Will Deacon , Dietmar Eggemann X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org We must not declare dbg_cpu_pm_nb as __cpuinitdata as we need it after system initialization for Suspend and CPUIdle. This was done in commit 9a6eb310eaa5336b89a27a0bbb78da4bba35f6f1 ARM: hw_breakpoint: Debug powerdown support for self-hosted debug Signed-off-by: Bastian Hecht --- Hi, I've experienced a kernel oops while working on Suspend-To-Ram and CPUIdle on the Armadillo800EVA from Renesas. After echo mem >/sys/power/state I get: Unable to handle kernel paging request at virtual address e7fddef0 PC is at 0xe7fddef0 LR is at notifier_call_chain+0x40/0x70 I've bisected the kernel to the commit 9a6eb310eaa5336b89a27a0bbb78da4bba35f6f1 ARM: hw_breakpoint: Debug powerdown support for self-hosted debug and succeeded to fix it by removing the __cpuinitdata tag. Cheers, Bastian arch/arm/kernel/hw_breakpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/kernel/hw_breakpoint.c b/arch/arm/kernel/hw_breakpoint.c index 96093b7..8eb67bc 100644 --- a/arch/arm/kernel/hw_breakpoint.c +++ b/arch/arm/kernel/hw_breakpoint.c @@ -1043,7 +1043,7 @@ static int dbg_cpu_pm_notify(struct notifier_block *self, unsigned long action, return NOTIFY_OK; } -static struct notifier_block __cpuinitdata dbg_cpu_pm_nb = { +static struct notifier_block dbg_cpu_pm_nb = { .notifier_call = dbg_cpu_pm_notify, };