From patchwork Tue Apr 23 16:30:53 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 2479151 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork2.kernel.org (Postfix) with ESMTP id 8E492DF2E5 for ; Tue, 23 Apr 2013 16:39:56 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UUgCf-0003db-84; Tue, 23 Apr 2013 16:36:28 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UUgAE-0005tu-Ll; Tue, 23 Apr 2013 16:33:54 +0000 Received: from moutng.kundenserver.de ([212.227.126.187]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UUg8L-0005eN-5B; Tue, 23 Apr 2013 16:32:10 +0000 Received: from wuerfel.lan (HSI-KBW-095-208-002-043.hsi5.kabel-badenwuerttemberg.de [95.208.2.43]) by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis) id 0MYrHb-1TzcRU0LTP-00VSS0; Tue, 23 Apr 2013 18:31:55 +0200 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 21/21] mtd: omap2: allow bulding as a module Date: Tue, 23 Apr 2013 18:30:53 +0200 Message-Id: <1366734653-488286-22-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1366734653-488286-1-git-send-email-arnd@arndb.de> References: <1366734653-488286-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:jSw43+b2wBQopcqhCAgpICIfzknybLWIAtb4xhsVVF6 6JaGL8peoUStjISuMGKT2xqTyAabV+iSmqJ6bmtEfmmqqKJ9Mz 6j5GGa3zdQSdQkhxx9s3gYLM/w7ypjUqCzD1GN/Y7Q/AZ3xXPV 1tkM0FTIYUF4tNXg55ZCQGW19znGY8PVURXowTGj1UxQv1FGXK uPocPj1qkFIW0QHo31fw3zCuKWSQDSSf4ZrzwUYrfxJe7Hi7sH kWIQKRi7BDVisBcFw0NSyLsFrypRtjWycfTsMgMVipl0pROdRp 1D7ndiIXlfNgsYSkOibJovbpkNeL6Byej7OhtyyFB0LrrVzsjV tR9nPB5LtMVupJzHVlr46io2GaKvqP26nrQPbGgeC X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130423_123157_662795_ED877614 X-CRM114-Status: GOOD ( 11.56 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.187 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Afzal Mohammed , Arnd Bergmann , Tony Lindgren , Artem Bityutskiy , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Russell King , David Woodhouse X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The omap2 nand device driver calls into the the elm code, which can be a loadable module, and in that case it cannot be built-in itself. I can see no reason why the omap2 driver cannot also be a module, so let's make the option "tristate" in Kconfig to fix this allmodconfig build error: ERROR: "elm_config" [drivers/mtd/nand/omap2.ko] undefined! ERROR: "elm_decode_bch_error_page" [drivers/mtd/nand/omap2.ko] undefined! Signed-off-by: Arnd Bergmann Cc: David Woodhouse Cc: Artem Bityutskiy Cc: Tony Lindgren Cc: Afzal Mohammed Cc: Russell King Cc: linux-mtd@lists.infradead.org Acked-by: Tony Lindgren --- drivers/mtd/nand/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 81bf5e5..106b55e 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig @@ -109,7 +109,7 @@ config MTD_NAND_OMAP2 config MTD_NAND_OMAP_BCH depends on MTD_NAND && MTD_NAND_OMAP2 && ARCH_OMAP3 - bool "Enable support for hardware BCH error correction" + tristate "Enable support for hardware BCH error correction" default n select BCH select BCH_CONST_PARAMS