| Message ID | 1366910944-3033663-11-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2013/4/25 Arnd Bergmann <arnd@arndb.de> > > ARM cannot handle udelay for more than 2 miliseconds, so we > should use mdelay instead for those. > Singed-off-by: GOTO Masanori <gotom@debian.or.jp> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: GOTO Masanori <gotom@debian.or.jp> > Cc: YOKOTA Hiroshi <yokota@netlab.is.tsukuba.ac.jp> > Cc: "James E.J. Bottomley" <JBottomley@parallels.com> > Cc: linux-scsi@vger.kernel.org > --- > drivers/scsi/nsp32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c > index 1e3879d..0665f9c 100644 > --- a/drivers/scsi/nsp32.c > +++ b/drivers/scsi/nsp32.c > @@ -2899,7 +2899,7 @@ static void nsp32_do_bus_reset(nsp32_hw_data *data) > * reset SCSI bus > */ > nsp32_write1(base, SCSI_BUS_CONTROL, BUSCTL_RST); > - udelay(RESET_HOLD_TIME); > + mdelay(RESET_HOLD_TIME / 1000); > nsp32_write1(base, SCSI_BUS_CONTROL, 0); > for(i = 0; i < 5; i++) { > intrdat = nsp32_read2(base, IRQ_STATUS); /* dummy read */ > -- > 1.8.1.2 >
On Friday 26 April 2013, Masanori Goto wrote: > 2013/4/25 Arnd Bergmann <arnd@arndb.de> > > > > ARM cannot handle udelay for more than 2 miliseconds, so we > > should use mdelay instead for those. > > > > Singed-off-by: GOTO Masanori <gotom@debian.or.jp> Thanks. I assume you mean "Acked-by", not "Singed-off" as in "burnt" or "Signed-off" as a notification that you have applied it to your own git tree. I'll keep the patch with an your "Acked-by" line in my tree unless James wants to apply to the scsi tree. Arnd
Oops, you're absolutely correct. Thanks for the follow up! Please change it as follow as you mentioned: Acked-by: GOTO Masanori <gotom@debian.or.jp> Best regrads, -- gotom 2013/4/29 Arnd Bergmann <arnd@arndb.de>: > On Friday 26 April 2013, Masanori Goto wrote: >> 2013/4/25 Arnd Bergmann <arnd@arndb.de> >> > >> > ARM cannot handle udelay for more than 2 miliseconds, so we >> > should use mdelay instead for those. >> > >> >> Singed-off-by: GOTO Masanori <gotom@debian.or.jp> > > Thanks. I assume you mean "Acked-by", not "Singed-off" as in "burnt" > or "Signed-off" as a notification that you have applied it to your > own git tree. > > I'll keep the patch with an your "Acked-by" line in my tree unless > James wants to apply to the scsi tree. > > Arnd >
On Mon, 2013-04-29 at 15:21 +0200, Arnd Bergmann wrote: > On Friday 26 April 2013, Masanori Goto wrote: > > 2013/4/25 Arnd Bergmann <arnd@arndb.de> > > > > > > ARM cannot handle udelay for more than 2 miliseconds, so we > > > should use mdelay instead for those. > > > > > > > Singed-off-by: GOTO Masanori <gotom@debian.or.jp> > > Thanks. I assume you mean "Acked-by", not "Singed-off" as in "burnt" > or "Signed-off" as a notification that you have applied it to your > own git tree. > > I'll keep the patch with an your "Acked-by" line in my tree unless > James wants to apply to the scsi tree. I can, certainly. I'll be sending the first scsi set today, but I'll be doing another one for just before the close of the merge window. Goto-san, while I have your attention, is the nsp_cs driver orphaned? I know it's not your driver, but you did once work with its author (YOKOTA Hiroshi <yokota@netlab.is.tsukuba.ac.jp>) and I'm trying to get some cleanup on the static functions in the header files. Thanks, James
diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c index 1e3879d..0665f9c 100644 --- a/drivers/scsi/nsp32.c +++ b/drivers/scsi/nsp32.c @@ -2899,7 +2899,7 @@ static void nsp32_do_bus_reset(nsp32_hw_data *data) * reset SCSI bus */ nsp32_write1(base, SCSI_BUS_CONTROL, BUSCTL_RST); - udelay(RESET_HOLD_TIME); + mdelay(RESET_HOLD_TIME / 1000); nsp32_write1(base, SCSI_BUS_CONTROL, 0); for(i = 0; i < 5; i++) { intrdat = nsp32_read2(base, IRQ_STATUS); /* dummy read */
ARM cannot handle udelay for more than 2 miliseconds, so we should use mdelay instead for those. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: GOTO Masanori <gotom@debian.or.jp> Cc: YOKOTA Hiroshi <yokota@netlab.is.tsukuba.ac.jp> Cc: "James E.J. Bottomley" <JBottomley@parallels.com> Cc: linux-scsi@vger.kernel.org --- drivers/scsi/nsp32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)