| Message ID | 1366910944-3033663-2-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Apr 25, 2013 at 06:28:44PM +0100, Arnd Bergmann wrote: > The cpu_topology symbol is required by any driver using the topology > interfaces, which leads to a couple of build errors: > > ERROR: "cpu_topology" [drivers/net/ethernet/sfc/sfc.ko] undefined! > ERROR: "cpu_topology" [drivers/cpufreq/arm_big_little.ko] undefined! Are these first two in mainline? > ERROR: "cpu_topology" [drivers/block/mtip32xx/mtip32xx.ko] undefined! > > The obvious solution is to export this symbol. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Russell King <rmk+kernel@arm.linux.org.uk> > Cc: Will Deacon <will.deacon@arm.com> > Cc: Nicolas Pitre <nico@linaro.org> > Cc: Vincent Guittot <vincent.guittot@linaro.org> > --- > arch/arm/kernel/topology.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c > index f10316b..7ac5714 100644 > --- a/arch/arm/kernel/topology.c > +++ b/arch/arm/kernel/topology.c > @@ -200,6 +200,7 @@ static inline void update_cpu_power(unsigned int cpuid, unsigned int mpidr) {} > * cpu topology table > */ > struct cputopo_arm cpu_topology[NR_CPUS]; > +EXPORT_SYMBOL_GPL(cpu_topology); Make sense: Acked-by: Will Deacon <will.deacon@arm.com> Probably best to put it in the patch system. Will
On Friday 26 April 2013, Will Deacon wrote: > On Thu, Apr 25, 2013 at 06:28:44PM +0100, Arnd Bergmann wrote: > > The cpu_topology symbol is required by any driver using the topology > > interfaces, which leads to a couple of build errors: > > > > ERROR: "cpu_topology" [drivers/net/ethernet/sfc/sfc.ko] undefined! > > ERROR: "cpu_topology" [drivers/cpufreq/arm_big_little.ko] undefined! > > Are these first two in mainline? I think they are both newly added in linux-next. Arnd
diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c index f10316b..7ac5714 100644 --- a/arch/arm/kernel/topology.c +++ b/arch/arm/kernel/topology.c @@ -200,6 +200,7 @@ static inline void update_cpu_power(unsigned int cpuid, unsigned int mpidr) {} * cpu topology table */ struct cputopo_arm cpu_topology[NR_CPUS]; +EXPORT_SYMBOL_GPL(cpu_topology); const struct cpumask *cpu_coregroup_mask(int cpu) {
The cpu_topology symbol is required by any driver using the topology interfaces, which leads to a couple of build errors: ERROR: "cpu_topology" [drivers/net/ethernet/sfc/sfc.ko] undefined! ERROR: "cpu_topology" [drivers/cpufreq/arm_big_little.ko] undefined! ERROR: "cpu_topology" [drivers/block/mtip32xx/mtip32xx.ko] undefined! The obvious solution is to export this symbol. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Russell King <rmk+kernel@arm.linux.org.uk> Cc: Will Deacon <will.deacon@arm.com> Cc: Nicolas Pitre <nico@linaro.org> Cc: Vincent Guittot <vincent.guittot@linaro.org> --- arch/arm/kernel/topology.c | 1 + 1 file changed, 1 insertion(+)