| Message ID | 1367507786-505303-2-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/02/2013 05:16 PM, Arnd Bergmann wrote: > CONFIG_HAVE_CAN_FLEXCAN is a silect symbol that is meant to be selected > by platforms that support this driver, but that is not possible without > also selecting CAN_DEV, unless we move it out of the "if CAN_DEV" > section of the Kconfig file. > > warning: (SOC_IMX28 && SOC_IMX25 && SOC_IMX35 && > IMX_HAVE_PLATFORM_FLEXCAN && SOC_IMX53 && SOC_IMX6Q) selects HAVE_CAN_FLEXCAN > which has unmet direct dependencies (NET && CAN && CAN_DEV) With the advent of multi platform kernels I like to get rid of HAVE_CAN_FLEXCAN completely. Marc
On Friday 03 May 2013, Marc Kleine-Budde wrote: > On 05/02/2013 05:16 PM, Arnd Bergmann wrote: > > CONFIG_HAVE_CAN_FLEXCAN is a silect symbol that is meant to be selected > > by platforms that support this driver, but that is not possible without > > also selecting CAN_DEV, unless we move it out of the "if CAN_DEV" > > section of the Kconfig file. > > > > warning: (SOC_IMX28 && SOC_IMX25 && SOC_IMX35 && > > IMX_HAVE_PLATFORM_FLEXCAN && SOC_IMX53 && SOC_IMX6Q) selects HAVE_CAN_FLEXCAN > > which has unmet direct dependencies (NET && CAN && CAN_DEV) > > With the advent of multi platform kernels I like to get rid of > HAVE_CAN_FLEXCAN completely. Yes, good idea. Are there any other dependencies we need to add then? I assume FLEXCAN needs to depend on HAS_IOMEM and OF at least, but there might be more. Arnd
On 05/03/2013 05:24 PM, Arnd Bergmann wrote: > On Friday 03 May 2013, Marc Kleine-Budde wrote: >> On 05/02/2013 05:16 PM, Arnd Bergmann wrote: >>> CONFIG_HAVE_CAN_FLEXCAN is a silect symbol that is meant to be selected >>> by platforms that support this driver, but that is not possible without >>> also selecting CAN_DEV, unless we move it out of the "if CAN_DEV" >>> section of the Kconfig file. >>> >>> warning: (SOC_IMX28 && SOC_IMX25 && SOC_IMX35 && >>> IMX_HAVE_PLATFORM_FLEXCAN && SOC_IMX53 && SOC_IMX6Q) selects HAVE_CAN_FLEXCAN >>> which has unmet direct dependencies (NET && CAN && CAN_DEV) >> >> With the advent of multi platform kernels I like to get rid of >> HAVE_CAN_FLEXCAN completely. > > Yes, good idea. Are there any other dependencies we need to add then? > I assume FLEXCAN needs to depend on HAS_IOMEM and OF at least, but > there might be more. The driver compiles (tested on SH and blacksfin) and works without CONFIG_OF (on non DT arm platforms). Marc
diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig index e456b70..3941a7d 100644 --- a/drivers/net/can/Kconfig +++ b/drivers/net/can/Kconfig @@ -29,6 +29,9 @@ config CAN_SLCAN can be changed by the 'maxdev=xx' module option. This driver can also be built as a module. If so, the module will be called slcan. +config HAVE_CAN_FLEXCAN + bool + config CAN_DEV tristate "Platform CAN drivers with Netlink support" default y @@ -102,9 +105,6 @@ config CAN_JANZ_ICAN3 This driver can also be built as a module. If so, the module will be called janz-ican3.ko. -config HAVE_CAN_FLEXCAN - bool - config CAN_FLEXCAN tristate "Support for Freescale FLEXCAN based chips" depends on HAVE_CAN_FLEXCAN
CONFIG_HAVE_CAN_FLEXCAN is a silect symbol that is meant to be selected by platforms that support this driver, but that is not possible without also selecting CAN_DEV, unless we move it out of the "if CAN_DEV" section of the Kconfig file. warning: (SOC_IMX28 && SOC_IMX25 && SOC_IMX35 && IMX_HAVE_PLATFORM_FLEXCAN && SOC_IMX53 && SOC_IMX6Q) selects HAVE_CAN_FLEXCAN which has unmet direct dependencies (NET && CAN && CAN_DEV) Cc: Oliver Hartkopp <socketcan@hartkopp.net> Cc: linux-can@vger.kernel.org Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/can/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)