From patchwork Thu May 2 15:16:05 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 2512191 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id C622A3FCA5 for ; Thu, 2 May 2013 15:17:14 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UXvFb-0000Gy-J7; Thu, 02 May 2013 15:16:52 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UXvFM-0002Ik-5h; Thu, 02 May 2013 15:16:36 +0000 Received: from moutng.kundenserver.de ([212.227.126.186]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UXvFJ-0002Hq-Jr for linux-arm-kernel@lists.infradead.org; Thu, 02 May 2013 15:16:34 +0000 Received: from wuerfel.lan (HSI-KBW-095-208-002-043.hsi5.kabel-badenwuerttemberg.de [95.208.2.43]) by mrelayeu.kundenserver.de (node=mreu4) with ESMTP (Nemesis) id 0MhJnJ-1UuHTW2caH-00MM6c; Thu, 02 May 2013 17:16:11 +0200 From: Arnd Bergmann To: linux-kernel@vger.kernel.org Subject: [PATCH, RFC 01/22] can: move CONFIG_HAVE_CAN_FLEXCAN out of CAN_DEV Date: Thu, 2 May 2013 17:16:05 +0200 Message-Id: <1367507786-505303-2-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1367507786-505303-1-git-send-email-arnd@arndb.de> References: <1367507786-505303-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:dCMZOPzb5TLq74yE3gFuXAJVsp+5oBIssPOavcuD8iu HJBailOn5phjcvQ5XGLEwGZAVgTqye8dqejv5jmDYy5vyUkcEI Wy18OLg20sn8++gcWJHV6z5UeabFfkOU+R+0iBv5/jBrUV78+9 iFeaEWPAl3gWxENAAjE9JAKeRlB1G+eEaa/OZganpqoiJ3MoJ6 F/hN+g6m1ohWu2VD+9egN8+NNk8FlAbS8+zVV0kBLkiYNgsYpo e+tNOUDF2h5gBhfCYt3/M4rTDIBoEY4xCzdZ+9Mzplvo6rl9Dx vIsRl+Go7u7nEH+Gkeyg+AA+hVDQFQSVMd8tXasmnJa8qHzgte IOg56eOC7rIzsegS6jhJBqSn7hjSTyUF3cMyCzvSa X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130502_111633_871653_AEB9ABFC X-CRM114-Status: UNSURE ( 8.20 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.186 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Oliver Hartkopp , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org CONFIG_HAVE_CAN_FLEXCAN is a silect symbol that is meant to be selected by platforms that support this driver, but that is not possible without also selecting CAN_DEV, unless we move it out of the "if CAN_DEV" section of the Kconfig file. warning: (SOC_IMX28 && SOC_IMX25 && SOC_IMX35 && IMX_HAVE_PLATFORM_FLEXCAN && SOC_IMX53 && SOC_IMX6Q) selects HAVE_CAN_FLEXCAN which has unmet direct dependencies (NET && CAN && CAN_DEV) Cc: Oliver Hartkopp Cc: linux-can@vger.kernel.org Signed-off-by: Arnd Bergmann --- drivers/net/can/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig index e456b70..3941a7d 100644 --- a/drivers/net/can/Kconfig +++ b/drivers/net/can/Kconfig @@ -29,6 +29,9 @@ config CAN_SLCAN can be changed by the 'maxdev=xx' module option. This driver can also be built as a module. If so, the module will be called slcan. +config HAVE_CAN_FLEXCAN + bool + config CAN_DEV tristate "Platform CAN drivers with Netlink support" default y @@ -102,9 +105,6 @@ config CAN_JANZ_ICAN3 This driver can also be built as a module. If so, the module will be called janz-ican3.ko. -config HAVE_CAN_FLEXCAN - bool - config CAN_FLEXCAN tristate "Support for Freescale FLEXCAN based chips" depends on HAVE_CAN_FLEXCAN