| Message ID | 1367507786-505303-5-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, May 02, 2013 at 05:16:08PM +0200, Arnd Bergmann wrote: > The imx DRM driver needs a couple of extra Kconfig dependencies > to avoid random build failures: > > drivers/staging/imx-drm/ipuv3-crtc.c:448: > undefined reference to `ipu_idmac_put' > drivers/staging/imx-drm/ipuv3-crtc.c:450: undefined reference to > `ipu_dmfc_put' drivers/staging/imx-drm/ipuv3-crtc.c:452: > undefined reference to `ipu_dp_put' > drivers/staging/imx-drm/ipuv3-crtc.c:454: undefined reference to > `ipu_di_put' > drivers/built-in.o: In function `ipu_probe': > :(.text+0x4b4174): undefined reference to `device_reset' > drivers/built-in.o: In function `imx_tve_probe': > drivers/staging/imx-drm/imx-tve.c:648: undefined reference to > `devm_regmap_init_mmio_clk' > drivers/built-in.o: In function > `imx_pd_connector_get_modes': > drivers/staging/imx-drm/parallel-display.c:78: undefined > reference to `of_get_drm_display_mode' There is a patch [1] from Marek fixing this one. Shawn [1] http://thread.gmane.org/gmane.linux.ports.arm.kernel/233449 > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Shawn Guo <shawn.guo@linaro.org> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/staging/imx-drm/Kconfig | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/staging/imx-drm/Kconfig b/drivers/staging/imx-drm/Kconfig > index 8c9e403..35ccda5 100644 > --- a/drivers/staging/imx-drm/Kconfig > +++ b/drivers/staging/imx-drm/Kconfig > @@ -1,6 +1,7 @@ > config DRM_IMX > tristate "DRM Support for Freescale i.MX" > select DRM_KMS_HELPER > + select VIDEOMODE_HELPERS > select DRM_GEM_CMA_HELPER > select DRM_KMS_CMA_HELPER > depends on DRM && (ARCH_MXC || ARCH_MULTIPLATFORM) > @@ -23,6 +24,7 @@ config DRM_IMX_PARALLEL_DISPLAY > config DRM_IMX_TVE > tristate "Support for TV and VGA displays" > depends on DRM_IMX > + select REGMAP_MMIO > help > Choose this to enable the internal Television Encoder (TVe) > found on i.MX53 processors. > @@ -30,6 +32,7 @@ config DRM_IMX_TVE > config DRM_IMX_IPUV3_CORE > tristate "IPUv3 core support" > depends on DRM_IMX > + depends on RESET_CONTROLLER > help > Choose this if you have a i.MX5/6 system and want > to use the IPU. This option only enables IPU base > @@ -38,5 +41,6 @@ config DRM_IMX_IPUV3_CORE > config DRM_IMX_IPUV3 > tristate "DRM Support for i.MX IPUv3" > depends on DRM_IMX > + depends on DRM_IMX_IPUV3_CORE > help > Choose this if you have a i.MX5 or i.MX6 processor. > -- > 1.8.1.2 >
On Friday 03 May 2013, Shawn Guo wrote: > On Thu, May 02, 2013 at 05:16:08PM +0200, Arnd Bergmann wrote: > > The imx DRM driver needs a couple of extra Kconfig dependencies > > to avoid random build failures: > > > > drivers/staging/imx-drm/ipuv3-crtc.c:448: > > undefined reference to `ipu_idmac_put' > > drivers/staging/imx-drm/ipuv3-crtc.c:450: undefined reference to > > `ipu_dmfc_put' drivers/staging/imx-drm/ipuv3-crtc.c:452: > > undefined reference to `ipu_dp_put' > > drivers/staging/imx-drm/ipuv3-crtc.c:454: undefined reference to > > `ipu_di_put' > > drivers/built-in.o: In function `ipu_probe': > > :(.text+0x4b4174): undefined reference to `device_reset' > > drivers/built-in.o: In function `imx_tve_probe': > > drivers/staging/imx-drm/imx-tve.c:648: undefined reference to > > `devm_regmap_init_mmio_clk' > > drivers/built-in.o: In function > > `imx_pd_connector_get_modes': > > > drivers/staging/imx-drm/parallel-display.c:78: undefined > > reference to `of_get_drm_display_mode' > > There is a patch [1] from Marek fixing this one. > > Shawn > > [1] http://thread.gmane.org/gmane.linux.ports.arm.kernel/233449 > That patch only addresses one of the four missing dependencies. I originally had four separate patches, but did not want to bother everyone with those so I combined them into one. Arnd
On Fri, May 03, 2013 at 05:21:37PM +0200, Arnd Bergmann wrote: > On Friday 03 May 2013, Shawn Guo wrote: > > On Thu, May 02, 2013 at 05:16:08PM +0200, Arnd Bergmann wrote: > > > The imx DRM driver needs a couple of extra Kconfig dependencies > > > to avoid random build failures: > > > > > > drivers/staging/imx-drm/ipuv3-crtc.c:448: > > > undefined reference to `ipu_idmac_put' > > > drivers/staging/imx-drm/ipuv3-crtc.c:450: undefined reference to > > > `ipu_dmfc_put' drivers/staging/imx-drm/ipuv3-crtc.c:452: > > > undefined reference to `ipu_dp_put' > > > drivers/staging/imx-drm/ipuv3-crtc.c:454: undefined reference to > > > `ipu_di_put' > > > drivers/built-in.o: In function `ipu_probe': > > > :(.text+0x4b4174): undefined reference to `device_reset' > > > drivers/built-in.o: In function `imx_tve_probe': > > > drivers/staging/imx-drm/imx-tve.c:648: undefined reference to > > > `devm_regmap_init_mmio_clk' > > > drivers/built-in.o: In function > > > `imx_pd_connector_get_modes': > > > > > drivers/staging/imx-drm/parallel-display.c:78: undefined > > > reference to `of_get_drm_display_mode' > > > > There is a patch [1] from Marek fixing this one. > > > > Shawn > > > > [1] http://thread.gmane.org/gmane.linux.ports.arm.kernel/233449 > > > > That patch only addresses one of the four missing dependencies. > I originally had four separate patches, but did not want to > bother everyone with those so I combined them into one. Yea, I agree we can address all of them in one patch. But it seems people agreed that there is a more correct way [1] to fix of_get_drm_display_mode one, and that's how v2 of Marek's patch comes. Shawn [1] http://thread.gmane.org/gmane.linux.ports.arm.kernel/232861/focus=232898
diff --git a/drivers/staging/imx-drm/Kconfig b/drivers/staging/imx-drm/Kconfig index 8c9e403..35ccda5 100644 --- a/drivers/staging/imx-drm/Kconfig +++ b/drivers/staging/imx-drm/Kconfig @@ -1,6 +1,7 @@ config DRM_IMX tristate "DRM Support for Freescale i.MX" select DRM_KMS_HELPER + select VIDEOMODE_HELPERS select DRM_GEM_CMA_HELPER select DRM_KMS_CMA_HELPER depends on DRM && (ARCH_MXC || ARCH_MULTIPLATFORM) @@ -23,6 +24,7 @@ config DRM_IMX_PARALLEL_DISPLAY config DRM_IMX_TVE tristate "Support for TV and VGA displays" depends on DRM_IMX + select REGMAP_MMIO help Choose this to enable the internal Television Encoder (TVe) found on i.MX53 processors. @@ -30,6 +32,7 @@ config DRM_IMX_TVE config DRM_IMX_IPUV3_CORE tristate "IPUv3 core support" depends on DRM_IMX + depends on RESET_CONTROLLER help Choose this if you have a i.MX5/6 system and want to use the IPU. This option only enables IPU base @@ -38,5 +41,6 @@ config DRM_IMX_IPUV3_CORE config DRM_IMX_IPUV3 tristate "DRM Support for i.MX IPUv3" depends on DRM_IMX + depends on DRM_IMX_IPUV3_CORE help Choose this if you have a i.MX5 or i.MX6 processor.
The imx DRM driver needs a couple of extra Kconfig dependencies to avoid random build failures: drivers/staging/imx-drm/ipuv3-crtc.c:448: undefined reference to `ipu_idmac_put' drivers/staging/imx-drm/ipuv3-crtc.c:450: undefined reference to `ipu_dmfc_put' drivers/staging/imx-drm/ipuv3-crtc.c:452: undefined reference to `ipu_dp_put' drivers/staging/imx-drm/ipuv3-crtc.c:454: undefined reference to `ipu_di_put' drivers/built-in.o: In function `ipu_probe': :(.text+0x4b4174): undefined reference to `device_reset' drivers/built-in.o: In function `imx_tve_probe': drivers/staging/imx-drm/imx-tve.c:648: undefined reference to `devm_regmap_init_mmio_clk' drivers/built-in.o: In function `imx_pd_connector_get_modes': drivers/staging/imx-drm/parallel-display.c:78: undefined reference to `of_get_drm_display_mode' Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Shawn Guo <shawn.guo@linaro.org> Cc: Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/staging/imx-drm/Kconfig | 4 ++++ 1 file changed, 4 insertions(+)