| Message ID | 1367507786-505303-9-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Arnd, On 05/02/2013 06:16 PM, Arnd Bergmann wrote: > The dpi.c file cannot be build correctly when the dsi.c file is > disabled in Kconfig. This clarifies the dependency in Kconfig > to avoid build errors: > > drivers/video/omap2/dss/dpi.c: In function 'dpi_calc_pll_cb': > drivers/video/omap2/dss/dpi.c:181:2: error: implicit declaration of function 'dsi_hsdiv_calc' [-Werror=implicit-function-declaration] > drivers/video/omap2/dss/dpi.c: In function 'dpi_dsi_clk_calc': > drivers/video/omap2/dss/dpi.c:201:2: error: implicit declaration of function 'dsi_get_pll_clkin' [-Werror=implicit-function-declaration] I've sent a patch for this to DRM maintainer, hopefully merged soon. Tomi
On Thursday 02 May 2013, Tomi Valkeinen wrote: > On 05/02/2013 06:16 PM, Arnd Bergmann wrote: > > The dpi.c file cannot be build correctly when the dsi.c file is > > disabled in Kconfig. This clarifies the dependency in Kconfig > > to avoid build errors: > > > > drivers/video/omap2/dss/dpi.c: In function 'dpi_calc_pll_cb': > > drivers/video/omap2/dss/dpi.c:181:2: error: implicit declaration of function 'dsi_hsdiv_calc' [-Werror=implicit-function-declaration] > > drivers/video/omap2/dss/dpi.c: In function 'dpi_dsi_clk_calc': > > drivers/video/omap2/dss/dpi.c:201:2: error: implicit declaration of function 'dsi_get_pll_clkin' [-Werror=implicit-function-declaration] > > I've sent a patch for this to DRM maintainer, hopefully merged soon. > Ok, thanks! Arnd
diff --git a/drivers/video/omap2/dss/Kconfig b/drivers/video/omap2/dss/Kconfig index cb0f145..4b30084 100644 --- a/drivers/video/omap2/dss/Kconfig +++ b/drivers/video/omap2/dss/Kconfig @@ -35,6 +35,7 @@ config OMAP2_DSS_COLLECT_IRQ_STATS config OMAP2_DSS_DPI bool "DPI support" + depends on OMAP2_DSS_DSI default y help DPI Interface. This is the Parallel Display Interface.
The dpi.c file cannot be build correctly when the dsi.c file is disabled in Kconfig. This clarifies the dependency in Kconfig to avoid build errors: drivers/video/omap2/dss/dpi.c: In function 'dpi_calc_pll_cb': drivers/video/omap2/dss/dpi.c:181:2: error: implicit declaration of function 'dsi_hsdiv_calc' [-Werror=implicit-function-declaration] drivers/video/omap2/dss/dpi.c: In function 'dpi_dsi_clk_calc': drivers/video/omap2/dss/dpi.c:201:2: error: implicit declaration of function 'dsi_get_pll_clkin' [-Werror=implicit-function-declaration] Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/video/omap2/dss/Kconfig | 1 + 1 file changed, 1 insertion(+)