| Message ID | 1367528578-518090-2-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, May 3, 2013 at 2:32 AM, Arnd Bergmann <arnd@arndb.de> wrote: > Like the other Tegra SoCs using the same cpufreq driver, we > have to enable CPU_FREQ_TABLE for this one. > > drivers/built-in.o: In function `tegra_cpu_exit': > drivers/cpufreq/tegra-cpufreq.c:237: undefined reference to > `cpufreq_frequency_table_cpuinfo' > > Cc: Stephen Warren <swarren@nvidia.com> > Cc: Hiroshi Doyu <hdoyu@nvidia.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/mach-tegra/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig > index 597e76b..9878503 100644 > --- a/arch/arm/mach-tegra/Kconfig > +++ b/arch/arm/mach-tegra/Kconfig > @@ -63,6 +63,7 @@ config ARCH_TEGRA_114_SOC > select ARM_ARCH_TIMER > select ARM_GIC > select ARM_L1_CACHE_SHIFT_6 > + select CPU_FREQ_TABLE if CPU_FREQ > select CPU_V7 > select PINCTRL > select PINCTRL_TEGRA114 I doubt which is the best place for doing this? This one or cpufreq/Kconfig.arm with select CPU_FREQ_TABLE for tegra?
On Friday 03 May 2013 10:27:17 Viresh Kumar wrote: > > diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig > > index 597e76b..9878503 100644 > > --- a/arch/arm/mach-tegra/Kconfig > > +++ b/arch/arm/mach-tegra/Kconfig > > @@ -63,6 +63,7 @@ config ARCH_TEGRA_114_SOC > > select ARM_ARCH_TIMER > > select ARM_GIC > > select ARM_L1_CACHE_SHIFT_6 > > + select CPU_FREQ_TABLE if CPU_FREQ > > select CPU_V7 > > select PINCTRL > > select PINCTRL_TEGRA114 > > I doubt which is the best place for doing this? This one or > cpufreq/Kconfig.arm with select CPU_FREQ_TABLE for > tegra? It would be much better IMHO to have an entry for TEGRA_CPUFREQ in drivers/cpufreq/Kcofnig.arm and move the select there. However, creating that entry has some (small) regression potential and I didn't want to do that now but instead just made sure that all three Tegra SoCs do the same thing for now. Arnd
On 3 May 2013 16:50, Arnd Bergmann <arnd@arndb.de> wrote: > On Friday 03 May 2013 10:27:17 Viresh Kumar wrote: >> > diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig >> > index 597e76b..9878503 100644 >> > --- a/arch/arm/mach-tegra/Kconfig >> > +++ b/arch/arm/mach-tegra/Kconfig >> > @@ -63,6 +63,7 @@ config ARCH_TEGRA_114_SOC >> > select ARM_ARCH_TIMER >> > select ARM_GIC >> > select ARM_L1_CACHE_SHIFT_6 >> > + select CPU_FREQ_TABLE if CPU_FREQ >> > select CPU_V7 >> > select PINCTRL >> > select PINCTRL_TEGRA114 >> >> I doubt which is the best place for doing this? This one or >> cpufreq/Kconfig.arm with select CPU_FREQ_TABLE for >> tegra? > > It would be much better IMHO to have an entry for TEGRA_CPUFREQ > in drivers/cpufreq/Kcofnig.arm and move the select there. However, > creating that entry has some (small) regression potential and I > didn't want to do that now but instead just made sure that all > three Tegra SoCs do the same thing for now. I was under the impression that this entry is already there. Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig index 597e76b..9878503 100644 --- a/arch/arm/mach-tegra/Kconfig +++ b/arch/arm/mach-tegra/Kconfig @@ -63,6 +63,7 @@ config ARCH_TEGRA_114_SOC select ARM_ARCH_TIMER select ARM_GIC select ARM_L1_CACHE_SHIFT_6 + select CPU_FREQ_TABLE if CPU_FREQ select CPU_V7 select PINCTRL select PINCTRL_TEGRA114
Like the other Tegra SoCs using the same cpufreq driver, we have to enable CPU_FREQ_TABLE for this one. drivers/built-in.o: In function `tegra_cpu_exit': drivers/cpufreq/tegra-cpufreq.c:237: undefined reference to `cpufreq_frequency_table_cpuinfo' Cc: Stephen Warren <swarren@nvidia.com> Cc: Hiroshi Doyu <hdoyu@nvidia.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/mach-tegra/Kconfig | 1 + 1 file changed, 1 insertion(+)