From patchwork Fri May 3 15:14:55 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 2518161 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id A26653FD1A for ; Fri, 3 May 2013 15:15:25 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UYHhk-0005oE-Gc; Fri, 03 May 2013 15:15:24 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UYHhh-0002ZD-VN; Fri, 03 May 2013 15:15:21 +0000 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UYHhe-0002Ye-9O for linux-arm-kernel@lists.infradead.org; Fri, 03 May 2013 15:15:18 +0000 X-Authority-Analysis: v=2.0 cv=cOZiQyiN c=1 sm=0 a=rXTBtCOcEpjy1lPqhTCpEQ==:17 a=mNMOxpOpBa8A:10 a=O4Sx1LqlDMUA:10 a=5SG0PmZfjMsA:10 a=IkcTkHD0fZMA:10 a=meVymXHHAAAA:8 a=IGil-QtXnCsA:10 a=zxyhxeHiEAsVogvHwHIA:9 a=QEXdDO2ut3YA:10 a=rXTBtCOcEpjy1lPqhTCpEQ==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 74.67.115.198 Received: from [74.67.115.198] ([74.67.115.198:50074] helo=[192.168.23.10]) by hrndva-oedge04.mail.rr.com (envelope-from ) (ecelerity 2.2.3.46 r()) with ESMTP id 7C/63-17243-F64D3815; Fri, 03 May 2013 15:14:56 +0000 Message-ID: <1367594095.7373.14.camel@gandalf.local.home> Subject: Re: [PATCH, RFC 14/22] oprofile: always enable IRQ_WORK From: Steven Rostedt To: Robert Richter Date: Fri, 03 May 2013 11:14:55 -0400 In-Reply-To: <20130503115332.GT8356@rric.localhost> References: <1367507786-505303-1-git-send-email-arnd@arndb.de> <1367507786-505303-15-git-send-email-arnd@arndb.de> <20130503115332.GT8356@rric.localhost> X-Mailer: Evolution 3.4.4-2 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130503_111518_508105_C232B432 X-CRM114-Status: GOOD ( 13.19 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [71.74.56.122 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-arm-kernel@lists.infradead.org, oprofile-list@lists.sf.net, linux-kernel@vger.kernel.org, Arnd Bergmann X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Fri, 2013-05-03 at 13:53 +0200, Robert Richter wrote: > On 02.05.13 17:16:18, Arnd Bergmann wrote: > > oprofile fails to build if CONFIG_IRQ_WORK is not already enabled, > > because of the dependency on the RING_BUFFER code that now uses > > the irq work library. > > > > kernel/built-in.o: In function `ring_buffer_unlock_commit': > > :(.text+0x5b8f0): undefined reference to `irq_work_queue' > > kernel/built-in.o: In function `ring_buffer_write': > > :(.text+0x5bd10): undefined reference to `irq_work_queue' > > Shouldn't this be fixed in the ring_buffer implementation? Does this patch fix it? -- Steve diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig index 5e9efd4..015f85a 100644 --- a/kernel/trace/Kconfig +++ b/kernel/trace/Kconfig @@ -71,6 +71,7 @@ config TRACE_CLOCK config RING_BUFFER bool select TRACE_CLOCK + select IRQ_WORK config FTRACE_NMI_ENTER bool @@ -107,7 +108,6 @@ config TRACING select BINARY_PRINTF select EVENT_TRACING select TRACE_CLOCK - select IRQ_WORK config GENERIC_TRACER bool