From patchwork Thu May 16 09:57:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Figa X-Patchwork-Id: 2576131 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork2.kernel.org (Postfix) with ESMTP id B1E35DFB7B for ; Thu, 16 May 2013 09:59:15 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UcuxC-000105-IO; Thu, 16 May 2013 09:58:31 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Ucux0-0007Ff-Cy; Thu, 16 May 2013 09:58:18 +0000 Received: from mailout2.w1.samsung.com ([210.118.77.12]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Ucuwe-0007Bj-Ni for linux-arm-kernel@lists.infradead.org; Thu, 16 May 2013 09:57:57 +0000 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMV003ATY28UL50@mailout2.w1.samsung.com> for linux-arm-kernel@lists.infradead.org; Thu, 16 May 2013 10:57:28 +0100 (BST) X-AuditID: cbfec7f5-b7f376d000001ec6-23-5194ad888bae Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 17.FB.07878.88DA4915; Thu, 16 May 2013 10:57:28 +0100 (BST) Received: from amdc1227.digital.local ([106.116.147.199]) by eusync2.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0MMV00J8RYBOHX80@eusync2.samsung.com>; Thu, 16 May 2013 10:57:28 +0100 (BST) From: Tomasz Figa To: linux-samsung-soc@vger.kernel.org Subject: [PATCH v2 2/6] usb: phy: samsung: Use clk_get to get reference clock Date: Thu, 16 May 2013 11:57:07 +0200 Message-id: <1368698231-24268-3-git-send-email-t.figa@samsung.com> X-Mailer: git-send-email 1.8.2.1 In-reply-to: <1368698231-24268-1-git-send-email-t.figa@samsung.com> References: <1368698231-24268-1-git-send-email-t.figa@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHJMWRmVeSWpSXmKPExsVy+t/xK7oda6cEGly9bGxx8H69RduVg+wW zYvXs1mcbXrDbrHp8TVWixnn9zFZLFrWymxxfksnk8X6Ga9ZHDg99s9dw+6xeUm9R9+WVYwe x29sZ/L4vEkugDWKyyYlNSezLLVI3y6BK+PvsalMBe84KnZv/cvawLiDvYuRk0NCwERix4P/ LBC2mMSFe+vZuhi5OIQEljJKrFz3mgXC6WOSOHnwGFgHm4CaxOeGR2wgtoiAqsTntgXsIEXM Ag1MEmfXzWUESQgL+EpM23INqIiDgwWo6PQ/eZAwr4CTRNe2y4wQ2xQkjm/fBmZzCjhLHNm/ ghXEFgKqeXztKcsERt4FjAyrGEVTS5MLipPSc430ihNzi0vz0vWS83M3MULC7OsOxqXHrA4x CnAwKvHwWk6fHCjEmlhWXJl7iFGCg1lJhHdG6pRAId6UxMqq1KL8+KLSnNTiQ4xMHJxSDYwN z7on5ztfDrX6Miku7NWE7et5Ymu+bH2gnRziK5clnP1KWnfNStsptilP68WL5C2tDZ0/Xeny qGa7l3fh83Nb74TPO69eLFxa2px2a3a2p6Vb8bRtOywD+K/l3HuT7/lp50ad+pfszkqxglp+ 7SUfpt19+V7Qynb1zZ+GDBqPLafrXLtsnKfEUpyRaKjFXFScCAC15/HoEQIAAA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130516_055756_848671_5CFB1C7B X-CRM114-Status: GOOD ( 10.77 ) X-Spam-Score: -7.5 (-------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-7.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [210.118.77.12 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Praveen Paneri , gregkh@linuxfoundation.org, Tomasz Figa , linux-usb@vger.kernel.org, balbi@ti.com, kyungmin.park@samsung.com, Vivek Gautam , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org There is no need to use devm_clk_get to get a clock that is being put at the end of the function. This patch changes the code getting reference clock to use clk_get instead of useless in this case devm_clk_get. Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/usb/phy/phy-samsung-usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/phy/phy-samsung-usb.c b/drivers/usb/phy/phy-samsung-usb.c index 7b118ee5..62cdb7e 100644 --- a/drivers/usb/phy/phy-samsung-usb.c +++ b/drivers/usb/phy/phy-samsung-usb.c @@ -175,9 +175,9 @@ int samsung_usbphy_get_refclk_freq(struct samsung_usbphy *sphy) * external crystal clock XXTI */ if (sphy->drv_data->cpu_type == TYPE_EXYNOS5250) - ref_clk = devm_clk_get(sphy->dev, "ext_xtal"); + ref_clk = clk_get(sphy->dev, "ext_xtal"); else - ref_clk = devm_clk_get(sphy->dev, "xusbxti"); + ref_clk = clk_get(sphy->dev, "xusbxti"); if (IS_ERR(ref_clk)) { dev_err(sphy->dev, "Failed to get reference clock\n"); return PTR_ERR(ref_clk);