| Message ID | 1368702961-4325-31-git-send-email-wsa@the-dreams.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/16/13 20:15, Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang<wsa@the-dreams.de> Looks good to me, applied into Samsung tree. Wolfram, if you want to take this into your tree, let me know. Thanks. - Kukjin > --- > arch/arm/plat-samsung/adc.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arm/plat-samsung/adc.c b/arch/arm/plat-samsung/adc.c > index ca07cb1..79690f2 100644 > --- a/arch/arm/plat-samsung/adc.c > +++ b/arch/arm/plat-samsung/adc.c > @@ -381,11 +381,6 @@ static int s3c_adc_probe(struct platform_device *pdev) > } > > regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!regs) { > - dev_err(dev, "failed to find registers\n"); > - return -ENXIO; > - } > - > adc->regs = devm_ioremap_resource(dev, regs); > if (IS_ERR(adc->regs)) > return PTR_ERR(adc->regs);
On Tue, May 21, 2013 at 01:38:23AM +0900, Kukjin Kim wrote: > On 05/16/13 20:15, Wolfram Sang wrote: > >devm_ioremap_resource does sanity checks on the given resource. No need to > >duplicate this in the driver. > > > >Signed-off-by: Wolfram Sang<wsa@the-dreams.de> > > Looks good to me, applied into Samsung tree. > > Wolfram, if you want to take this into your tree, let me know. It is already upstream :)
On 05/21/13 02:11, Wolfram Sang wrote: > On Tue, May 21, 2013 at 01:38:23AM +0900, Kukjin Kim wrote: >> On 05/16/13 20:15, Wolfram Sang wrote: >>> devm_ioremap_resource does sanity checks on the given resource. No need to >>> duplicate this in the driver. >>> >>> Signed-off-by: Wolfram Sang<wsa@the-dreams.de> >> >> Looks good to me, applied into Samsung tree. >> >> Wolfram, if you want to take this into your tree, let me know. > > It is already upstream :) > Oh, OK. Let me drop it in my tree ;-) Thanks. - Kukjin
diff --git a/arch/arm/plat-samsung/adc.c b/arch/arm/plat-samsung/adc.c index ca07cb1..79690f2 100644 --- a/arch/arm/plat-samsung/adc.c +++ b/arch/arm/plat-samsung/adc.c @@ -381,11 +381,6 @@ static int s3c_adc_probe(struct platform_device *pdev) } regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!regs) { - dev_err(dev, "failed to find registers\n"); - return -ENXIO; - } - adc->regs = devm_ioremap_resource(dev, regs); if (IS_ERR(adc->regs)) return PTR_ERR(adc->regs);
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang <wsa@the-dreams.de> --- arch/arm/plat-samsung/adc.c | 5 ----- 1 file changed, 5 deletions(-)