From patchwork Fri May 17 13:43:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Emilio_L=C3=B3pez?= X-Patchwork-Id: 2582961 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork2.kernel.org (Postfix) with ESMTP id BE7ACDF215 for ; Fri, 17 May 2013 13:45:41 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UdKy8-0002Qh-GK; Fri, 17 May 2013 13:45:12 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UdKxx-0006Hd-5T; Fri, 17 May 2013 13:45:01 +0000 Received: from [2606:3f00:60:21c:d00d:c0de:4:f00d] (helo=zetta.elopez.com.ar) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UdKxu-0006GG-4o for linux-arm-kernel@lists.infradead.org; Fri, 17 May 2013 13:44:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=elopez.com.ar; s=mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=g4/27PM88M6S+mjCvsLFKKZsP2qvVyO/00Ko8u9bRQM=; b=v9P9Nd7MzhpjiRtPO5CurUQ7wrTqomBGM1AtFOPJqyeM7/sVlRs/SxK6y2rvs1SGomtyywZqBU25ExZgGljAHcIrPpld/axa2oXVSfWVc+fUiVGT2aPgef+fbKPCe7+cpkok0eqX8MJ97Ujr6Opv+FFWkc1CfVh/NfNJa1DVOzi0Fs2mFFjbekkkYWX1UqAkbUOLnaOipvvGOh0nhqzXIfvGh/UIt7Z/D8Q5Q+SEJeZLiCrgYuTT5WCBGYGSW2wxBnrLH0n+PfMqiiv0Vu640PihvSwVCVwp/UCCGgAzw1GDNMFaLd4qMjJqD36cqY7kU8Bkdbxbre/dPebeilIACQ==; Received: from 201-212-118-238.prima.net.ar ([201.212.118.238] helo=desktop.lan) by zetta.elopez.com.ar with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) id 1UdKxS-0007Vs-GS; Fri, 17 May 2013 10:44:31 -0300 From: =?UTF-8?q?Emilio=20L=C3=B3pez?= To: Mike Turquette , cate@cateee.net Subject: [PATCH] clk: sunxi: "cpu_data" is defined in header files of some architectures Date: Fri, 17 May 2013 10:43:20 -0300 Message-Id: <1368798200-7063-1-git-send-email-emilio@elopez.com.ar> X-Mailer: git-send-email 1.8.2.3 In-Reply-To: <5195D615.70608@cateee.net> References: <5195D615.70608@cateee.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130517_094458_293953_159BE5AC X-CRM114-Status: GOOD ( 12.67 ) X-Spam-Score: -1.2 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.8 RDNS_NONE Delivered to internal network by a host with no rDNS Cc: =?UTF-8?q?Emilio=20L=C3=B3pez?= , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: "Giacomo A. Catenazzi" In some architectures, the #define cpu_data is not a "macro-function", so the compiler will substitute the identifier with probably something wrong. Signed-off-by: Giacomo A. Catenazzi Signed-off-by: Emilio López [emilio@elopez.com.ar: use cpu_mux_data instead of this_cpu_data] --- Hi Giacomo, I have taken your patch and resent it to linux-arm-kernel and Mike Turquette this time, but please try to use git send-email on your next patch. Here is a video from Greg that explains how to use it as well as other things (checkpatch.pl, get_maintainer.pl, etc) http://www.youtube.com/watch?v=LLBrBBImJt4 Thanks! :) Emilio drivers/clk/sunxi/clk-sunxi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c index 930d36f..412912b 100644 --- a/drivers/clk/sunxi/clk-sunxi.c +++ b/drivers/clk/sunxi/clk-sunxi.c @@ -239,7 +239,7 @@ struct mux_data { u8 shift; }; -static const __initconst struct mux_data cpu_data = { +static const __initconst struct mux_data cpu_mux_data = { .shift = 16, }; @@ -433,7 +433,7 @@ static const __initconst struct of_device_id clk_div_match[] = { /* Matches for mux clocks */ static const __initconst struct of_device_id clk_mux_match[] = { - {.compatible = "allwinner,sun4i-cpu-clk", .data = &cpu_data,}, + {.compatible = "allwinner,sun4i-cpu-clk", .data = &cpu_mux_data,}, {.compatible = "allwinner,sun4i-apb1-mux-clk", .data = &apb1_mux_data,}, {} };