From patchwork Fri May 31 21:44:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 2645681 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id D9EEE3FD2B for ; Fri, 31 May 2013 21:45:40 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UiX8d-0003vz-2S; Fri, 31 May 2013 21:45:31 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UiX8a-0003bP-CH; Fri, 31 May 2013 21:45:28 +0000 Received: from mail-pb0-x235.google.com ([2607:f8b0:400e:c01::235]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UiX8X-0003ao-1k for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2013 21:45:25 +0000 Received: by mail-pb0-f53.google.com with SMTP id un4so2849904pbc.26 for ; Fri, 31 May 2013 14:44:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=+fBFjEVE2evMr0QKT5VJ4xFGrFU6tgDa95GU1Oh4c7U=; b=pvcHCHTbOCI3+Gk82EezZpN/plbzAr29rlSSj/0LvRqjq6tT4eJdEjAFxkXdRre43j TGJX93RhF/Ff8bjdIaE7Oa4bQRy2bN87SiiJNdjviGIKlIJzmhZJ7sZaFAXAbemTpz+d Jb3yRurFArLQ+O3X3KUS8Gul+eHWT1ERe4+1wTYjwjOpuzCP/a8mJ0PpXUmRHuF/iU0a 3Uv59DTrReRv8aHZmj+PDzYKiS1eVecY3d/trAPL9y1qIB/XQS/9a+GoRpbnRaeMmLxw 50fcMFZnEyIr4oxK2oS8TS++/hCrSiaoiTe3TBn9FXCL/DKJlt0aL21QLqtBXQxvHWnT t60w== X-Received: by 10.66.157.67 with SMTP id wk3mr15520687pab.88.1370036697892; Fri, 31 May 2013 14:44:57 -0700 (PDT) Received: from localhost (c-24-19-7-36.hsd1.wa.comcast.net. [24.19.7.36]) by mx.google.com with ESMTPSA id qp4sm48177942pbc.41.2013.05.31.14.44.56 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 31 May 2013 14:44:56 -0700 (PDT) From: Kevin Hilman To: Samuel Ortiz , Tony Lindgren Subject: [PATCH] mfd: twl4030: allow IRQ wake enable to succeed on subchip IRQs Date: Fri, 31 May 2013 14:44:54 -0700 Message-Id: <1370036694-26210-1-git-send-email-khilman@linaro.org> X-Mailer: git-send-email 1.8.2 X-Gm-Message-State: ALoCoQk4nBXFX7uJB7SWIY2cGuiO+weGOawKhLPE7MeCRud9YGvo4HL31p/Kn4yyx64AcotOzY29 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130531_174525_204707_5EE751D1 X-CRM114-Status: UNSURE ( 9.86 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-omap@vger.kernel.org, open list , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The genirq IRQ wake method will default to failure if the irq_chip does not provide a set_wake method. However, for TWL4030 sub-chip IRQs, we want the wake enable to succeed even though we don't provide a set_wake method. This allows sub-chip IRQs to still be flagged as wakeup capable, and allow them to wakeup from suspend (or abort suspend if they fire during suspend.) To fix, use the IRQCHIP_SKIP_SET_WAKE flag in the irq_chip. Signed-off-by: Kevin Hilman --- drivers/mfd/twl4030-irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c index a5f9888..3fa7df2 100644 --- a/drivers/mfd/twl4030-irq.c +++ b/drivers/mfd/twl4030-irq.c @@ -573,6 +573,7 @@ static struct irq_chip twl4030_sih_irq_chip = { .irq_set_type = twl4030_sih_set_type, .irq_bus_lock = twl4030_sih_bus_lock, .irq_bus_sync_unlock = twl4030_sih_bus_sync_unlock, + .flags = IRQCHIP_SKIP_SET_WAKE, }; /*----------------------------------------------------------------------*/