From patchwork Fri May 31 22:22:39 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 2646181 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork2.kernel.org (Postfix) with ESMTP id 0DD1BDFB79 for ; Fri, 31 May 2013 23:08:46 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UiXp4-0008CZ-Hs; Fri, 31 May 2013 22:29:27 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UiXm6-0004Ss-BO; Fri, 31 May 2013 22:26:18 +0000 Received: from bombadil.infradead.org ([2001:1868:205::9]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UiXjo-0004HX-QL; Fri, 31 May 2013 22:23:56 +0000 Received: from moutng.kundenserver.de ([212.227.126.186]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UiXjm-0000Ed-Ah; Fri, 31 May 2013 22:23:55 +0000 Received: from wuerfel.lan (HSI-KBW-095-208-002-043.hsi5.kabel-badenwuerttemberg.de [95.208.2.43]) by mrelayeu.kundenserver.de (node=mreu3) with ESMTP (Nemesis) id 0MQCPv-1UnEYg03fP-005Edl; Sat, 01 Jun 2013 00:23:01 +0200 From: Arnd Bergmann To: linux-kernel@vger.kernel.org Subject: [PATCH 02/15] mtd: omap2: allow bulding as a module Date: Sat, 1 Jun 2013 00:22:39 +0200 Message-Id: <1370038972-2318779-3-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1370038972-2318779-1-git-send-email-arnd@arndb.de> References: <1370038972-2318779-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:omNpzOYNZemm/kAyH171xaWXumPVxbytGvEAIt8wzeZ L47DLywV/AK0cghBeiCfzYCTbPgEanUhkap4L5TiNwxzY+c1CF uB9HxsyjN6YX5e0LQz+h61UYEVsXcMuy8fw4FePcGAFL0DvRZb WiN0DpCejGRVgqw5aZB0V0goEW6DuxlrNO0yYQkA6JO+WD8I/t ak+mfOIRRxVgFOOxawRq7cLLZHvm/qjPC0XJyBR6dxwaWC0dnf 7tShmnGsKVfoFhjF+LFIEbMLKsgpE+NSc35CmTD+aTZ/mCX0Z3 JKn9958x8XcdIqd28FMHhVHbqqRqDeKBLaD6JY0EVWaQW2GLGw cR6B128BGJzneeJqZc9ATb1WuB6b2LrfezWy/ZUjH X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130531_152354_712144_7D072425 X-CRM114-Status: GOOD ( 11.24 ) X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.3.2 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.186 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record Cc: Afzal Mohammed , Arnd Bergmann , Artem Bityutskiy , linux-mtd@lists.infradead.org, Russell King , patches@lists.linaro.org, David Woodhouse , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The omap2 nand device driver calls into the the elm code, which can be a loadable module, and in that case it cannot be built-in itself. I can see no reason why the omap2 driver cannot also be a module, so let's make the option "tristate" in Kconfig to fix this allmodconfig build error: ERROR: "elm_config" [drivers/mtd/nand/omap2.ko] undefined! ERROR: "elm_decode_bch_error_page" [drivers/mtd/nand/omap2.ko] undefined! Signed-off-by: Arnd Bergmann Acked-by: Tony Lindgren Cc: David Woodhouse Cc: Artem Bityutskiy Cc: Afzal Mohammed Cc: Russell King Cc: linux-mtd@lists.infradead.org --- drivers/mtd/nand/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 3ae9105..5ef8f5e 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig @@ -95,7 +95,7 @@ config MTD_NAND_OMAP2 config MTD_NAND_OMAP_BCH depends on MTD_NAND && MTD_NAND_OMAP2 && ARCH_OMAP3 - bool "Enable support for hardware BCH error correction" + tristate "Enable support for hardware BCH error correction" default n select BCH select BCH_CONST_PARAMS