| Message ID | 1370038972-2318779-8-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 1 June 2013 03:52, Arnd Bergmann <arnd@arndb.de> wrote: > Like a lot of the other cpufreq drivers, this one needs to > select CONFIG_CPU_FREQ_TABLE to avoid a build error like > > drivers/built-in.o: In function `spear_cpufreq_exit': > spear-cpufreq.c:198: undefined reference to `cpufreq_frequency_table_put_attr' > drivers/built-in.o: In function `spear_cpufreq_verify': > spear-cpufreq.c:35: undefined reference to `cpufreq_frequency_table_verify' > drivers/built-in.o: In function `spear_cpufreq_init': > spear-cpufreq.c:181: undefined reference to `cpufreq_frequency_table_cpuinfo' > spear-cpufreq.c:187: undefined reference to `cpufreq_frequency_table_get_attr' > drivers/built-in.o: In function `spear_cpufreq_target': > spear-cpufreq.c:120: undefined reference to `cpufreq_frequency_table_target' > drivers/built-in.o:(.data+0x5e63c): undefined reference to `cpufreq_freq_attr_scaling_available_freqs' > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Rafael J. Wysocki <rjw@sisk.pl> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: cpufreq@vger.kernel.org > Cc: linux-pm@vger.kernel.org > --- > drivers/cpufreq/Kconfig.arm | 1 + > 1 file changed, 1 insertion(+) Acked-by: Viresh Kumar <viresh.kumar@linaro.org> BTW, you want me to apply this one or take it through arm-soc tree?
On Fri, May 31, 2013 at 7:22 PM, Arnd Bergmann <arnd@arndb.de> wrote: > Like a lot of the other cpufreq drivers, this one needs to > select CONFIG_CPU_FREQ_TABLE to avoid a build error like > Indeed. I found the same thing while playing with Kirkwood's. @Andrew, I have a patch sitting here, but feel free to send it if you want.
On Saturday 01 June 2013 07:28:01 Viresh Kumar wrote: > On 1 June 2013 03:52, Arnd Bergmann <arnd@arndb.de> wrote: > > Like a lot of the other cpufreq drivers, this one needs to > > select CONFIG_CPU_FREQ_TABLE to avoid a build error like > > > > drivers/built-in.o: In function `spear_cpufreq_exit': > > spear-cpufreq.c:198: undefined reference to `cpufreq_frequency_table_put_attr' > > drivers/built-in.o: In function `spear_cpufreq_verify': > > spear-cpufreq.c:35: undefined reference to `cpufreq_frequency_table_verify' > > drivers/built-in.o: In function `spear_cpufreq_init': > > spear-cpufreq.c:181: undefined reference to `cpufreq_frequency_table_cpuinfo' > > spear-cpufreq.c:187: undefined reference to `cpufreq_frequency_table_get_attr' > > drivers/built-in.o: In function `spear_cpufreq_target': > > spear-cpufreq.c:120: undefined reference to `cpufreq_frequency_table_target' > > drivers/built-in.o:(.data+0x5e63c): undefined reference to `cpufreq_freq_attr_scaling_available_freqs' > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Cc: Rafael J. Wysocki <rjw@sisk.pl> > > Cc: Viresh Kumar <viresh.kumar@linaro.org> > > Cc: cpufreq@vger.kernel.org > > Cc: linux-pm@vger.kernel.org > > --- > > drivers/cpufreq/Kconfig.arm | 1 + > > 1 file changed, 1 insertion(+) > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > > BTW, you want me to apply this one or take it through arm-soc tree? As I said in the introductory mail, I would prefer it if you can pick it up. Thanks! Arnd
On 1 June 2013 14:33, Arnd Bergmann <arnd@arndb.de> wrote: > On Saturday 01 June 2013 07:28:01 Viresh Kumar wrote: >> On 1 June 2013 03:52, Arnd Bergmann <arnd@arndb.de> wrote: >> > Like a lot of the other cpufreq drivers, this one needs to >> > select CONFIG_CPU_FREQ_TABLE to avoid a build error like >> > >> > drivers/built-in.o: In function `spear_cpufreq_exit': >> > spear-cpufreq.c:198: undefined reference to `cpufreq_frequency_table_put_attr' >> > drivers/built-in.o: In function `spear_cpufreq_verify': >> > spear-cpufreq.c:35: undefined reference to `cpufreq_frequency_table_verify' >> > drivers/built-in.o: In function `spear_cpufreq_init': >> > spear-cpufreq.c:181: undefined reference to `cpufreq_frequency_table_cpuinfo' >> > spear-cpufreq.c:187: undefined reference to `cpufreq_frequency_table_get_attr' >> > drivers/built-in.o: In function `spear_cpufreq_target': >> > spear-cpufreq.c:120: undefined reference to `cpufreq_frequency_table_target' >> > drivers/built-in.o:(.data+0x5e63c): undefined reference to `cpufreq_freq_attr_scaling_available_freqs' >> > >> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> > Cc: Rafael J. Wysocki <rjw@sisk.pl> >> > Cc: Viresh Kumar <viresh.kumar@linaro.org> >> > Cc: cpufreq@vger.kernel.org >> > Cc: linux-pm@vger.kernel.org >> > --- >> > drivers/cpufreq/Kconfig.arm | 1 + >> > 1 file changed, 1 insertion(+) >> >> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> >> >> BTW, you want me to apply this one or take it through arm-soc tree? > > As I said in the introductory mail, I would prefer it if you > can pick it up. Thanks! I saw that mail later :( Applied to cpufreq-next. Thanks.
On Fri, May 31, 2013 at 11:17:48PM -0300, Ezequiel Garcia wrote: > On Fri, May 31, 2013 at 7:22 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > Like a lot of the other cpufreq drivers, this one needs to > > select CONFIG_CPU_FREQ_TABLE to avoid a build error like > > > > Indeed. I found the same thing while playing with Kirkwood's. > > @Andrew, I have a patch sitting here, but feel free to send it if you want. Hi Ezequiel Please send your patch. Thanks Andrew
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index a924408..d3f2c6b 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -205,6 +205,7 @@ config ARM_SA1110_CPUFREQ config ARM_SPEAR_CPUFREQ bool "SPEAr CPUFreq support" depends on PLAT_SPEAR + select CPU_FREQ_TABLE default y help This adds the CPUFreq driver support for SPEAr SOCs.
Like a lot of the other cpufreq drivers, this one needs to select CONFIG_CPU_FREQ_TABLE to avoid a build error like drivers/built-in.o: In function `spear_cpufreq_exit': spear-cpufreq.c:198: undefined reference to `cpufreq_frequency_table_put_attr' drivers/built-in.o: In function `spear_cpufreq_verify': spear-cpufreq.c:35: undefined reference to `cpufreq_frequency_table_verify' drivers/built-in.o: In function `spear_cpufreq_init': spear-cpufreq.c:181: undefined reference to `cpufreq_frequency_table_cpuinfo' spear-cpufreq.c:187: undefined reference to `cpufreq_frequency_table_get_attr' drivers/built-in.o: In function `spear_cpufreq_target': spear-cpufreq.c:120: undefined reference to `cpufreq_frequency_table_target' drivers/built-in.o:(.data+0x5e63c): undefined reference to `cpufreq_freq_attr_scaling_available_freqs' Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Rafael J. Wysocki <rjw@sisk.pl> Cc: Viresh Kumar <viresh.kumar@linaro.org> Cc: cpufreq@vger.kernel.org Cc: linux-pm@vger.kernel.org --- drivers/cpufreq/Kconfig.arm | 1 + 1 file changed, 1 insertion(+)