diff mbox

[V1,4/7] video: mmp: fix memcpy wrong size for mmp_addr issue

Message ID 1370767470-11615-1-git-send-email-jtzhou@marvell.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jett.Zhou June 9, 2013, 8:44 a.m. UTC 
From: Jing Xiang <jxiang@marvell.com>

Memcpy used wrong struct of mmp_addr, fix it.

Signed-off-by: Jing Xiang <jxiang@marvell.com>
Signed-off-by: Jett.Zhou <jtzhou@marvell.com>
---
 drivers/video/mmp/hw/mmp_ctrl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Sergei Shtylyov June 9, 2013, 12:01 p.m. UTC | #1 
Hello.

On 09-06-2013 12:44, Jett.Zhou wrote:

> From: Jing Xiang <jxiang@marvell.com>

> Memcpy used wrong struct of mmp_addr, fix it.

     From the patch it follows that 'struct mmp_addr' is the right one. :-)

> Signed-off-by: Jing Xiang <jxiang@marvell.com>
> Signed-off-by: Jett.Zhou <jtzhou@marvell.com>
> ---
>   drivers/video/mmp/hw/mmp_ctrl.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)

> diff --git a/drivers/video/mmp/hw/mmp_ctrl.c b/drivers/video/mmp/hw/mmp_ctrl.c
> index 8836053..92a5f44 100644
> --- a/drivers/video/mmp/hw/mmp_ctrl.c
> +++ b/drivers/video/mmp/hw/mmp_ctrl.c
> @@ -233,7 +233,7 @@ static int overlay_set_addr(struct mmp_overlay *overlay, struct mmp_addr *addr)
>   	struct lcd_regs *regs = path_regs(overlay->path);
>
>   	/* FIXME: assert addr supported */
> -	memcpy(&overlay->addr, addr, sizeof(struct mmp_win));
> +	memcpy(&overlay->addr, addr, sizeof(struct mmp_addr));
>   	writel(addr->phys[0], &regs->g_0);
>
>   	return overlay->addr.phys[0];

WBR, Sergei
diff mbox

Patch

diff --git a/drivers/video/mmp/hw/mmp_ctrl.c b/drivers/video/mmp/hw/mmp_ctrl.c
index 8836053..92a5f44 100644
--- a/drivers/video/mmp/hw/mmp_ctrl.c
+++ b/drivers/video/mmp/hw/mmp_ctrl.c
@@ -233,7 +233,7 @@  static int overlay_set_addr(struct mmp_overlay *overlay, struct mmp_addr *addr)
 	struct lcd_regs *regs = path_regs(overlay->path);
 
 	/* FIXME: assert addr supported */
-	memcpy(&overlay->addr, addr, sizeof(struct mmp_win));
+	memcpy(&overlay->addr, addr, sizeof(struct mmp_addr));
 	writel(addr->phys[0], &regs->g_0);
 
 	return overlay->addr.phys[0];