diff mbox

[V2,4/7] video: mmp: fix memcpy wrong size for mmp_addr issue

Message ID 1370879562-11342-1-git-send-email-jtzhou@marvell.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jett.Zhou June 10, 2013, 3:52 p.m. UTC 
From: Jing Xiang <jxiang@marvell.com>

Memcpy used wrong struct of mmp_win, fix it.

Signed-off-by: Jing Xiang <jxiang@marvell.com>
Signed-off-by: Jett.Zhou <jtzhou@marvell.com>
---
 drivers/video/mmp/hw/mmp_ctrl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Daniel Drake June 21, 2013, 5:13 p.m. UTC | #1 
On Mon, Jun 10, 2013 at 9:52 AM, Jett.Zhou <jtzhou@marvell.com> wrote:
> From: Jing Xiang <jxiang@marvell.com>
>
> Memcpy used wrong struct of mmp_win, fix it.
>
> Signed-off-by: Jing Xiang <jxiang@marvell.com>
> Signed-off-by: Jett.Zhou <jtzhou@marvell.com>

Reviewed-by: Daniel Drake <dsd@laptop.org>
diff mbox

Patch

diff --git a/drivers/video/mmp/hw/mmp_ctrl.c b/drivers/video/mmp/hw/mmp_ctrl.c
index 8836053..92a5f44 100644
--- a/drivers/video/mmp/hw/mmp_ctrl.c
+++ b/drivers/video/mmp/hw/mmp_ctrl.c
@@ -233,7 +233,7 @@  static int overlay_set_addr(struct mmp_overlay *overlay, struct mmp_addr *addr)
 	struct lcd_regs *regs = path_regs(overlay->path);
 
 	/* FIXME: assert addr supported */
-	memcpy(&overlay->addr, addr, sizeof(struct mmp_win));
+	memcpy(&overlay->addr, addr, sizeof(struct mmp_addr));
 	writel(addr->phys[0], &regs->g_0);
 
 	return overlay->addr.phys[0];