From patchwork Thu Jun 13 13:56:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Baltieri X-Patchwork-Id: 2716971 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8CF50C1459 for ; Thu, 13 Jun 2013 13:56:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5558620363 for ; Thu, 13 Jun 2013 13:56:58 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20D3020335 for ; Thu, 13 Jun 2013 13:56:57 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Un81C-0006xt-Ju; Thu, 13 Jun 2013 13:56:50 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Un819-0005Wz-Pe; Thu, 13 Jun 2013 13:56:47 +0000 Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Un816-0005Vy-UC for linux-arm-kernel@lists.infradead.org; Thu, 13 Jun 2013 13:56:45 +0000 Received: by mail-wg0-f52.google.com with SMTP id b12so1624431wgh.31 for ; Thu, 13 Jun 2013 06:56:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=HFpWOiiXu3YeUKO5UXLzu5uDuSLa7UUnVoO37v++cvc=; b=Pnfr4YJPMctguTQko4Qpcuro0DdwIj3SRb4PcDX55ypumrORjmc+viIu5DGGd6DLLA oUYUYKKk5Z9JcvWBvJQ9jBRslN2GNokbNvLKJoEaW5vu6Ii2IzXiqwU2/4NpdaGWqhbd On7GgvnsaYbwVgXHIJuWyFK6p+Gq6IpxvvgLMv9QqvC6vOB+B3eIlOXFiu4lxP8G/tss Uu3VHGME5kbj1xvHVykdvx5IpIyDcVHwN2u1Et+zurdNQl5l53c0Rg26e5fnTRKrgkAu 9eLvVfEBzWK2NLVS9V1XflMmeJj5K6FIiv3Ex4Yop99w9OaNW+gfQ6VLfE6leUq+kD9F Ilpg== X-Received: by 10.180.101.170 with SMTP id fh10mr7412925wib.22.1371131781383; Thu, 13 Jun 2013 06:56:21 -0700 (PDT) Received: from localhost ([2a01:2003:1:1e74:8e70:5aff:feac:ad8]) by mx.google.com with ESMTPSA id ft10sm31549284wib.7.2013.06.13.06.56.18 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 13 Jun 2013 06:56:20 -0700 (PDT) From: Fabio Baltieri To: Linus Walleij , Lee Jones Subject: [PATCH] ARM: ux500: set coherent_dma_mask for dma40 Date: Thu, 13 Jun 2013 15:56:03 +0200 Message-Id: <1371131763-6288-1-git-send-email-fabio.baltieri@linaro.org> X-Mailer: git-send-email 1.8.2 X-Gm-Message-State: ALoCoQn/t7prKFotd9+i4DZLzO7MipWVvCeSwM99ahBtfIMGR6C6uMBGRRh65YfAUgQ7O/AYThE6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130613_095645_089956_FFFF65CA X-CRM114-Status: GOOD ( 12.02 ) X-Spam-Score: -1.9 (-) Cc: Vinod Koul , Fabio Baltieri , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Srinidhi Kasagar X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Set coherent_dma_mask to DMA_BIT_MASK(32) for dma40 platform_device, as without this DMA allocations were failing with the error: dma40 dma40.0: coherent DMA mask is unset when booting without device-tree. Signed-off-by: Fabio Baltieri --- Hi Linus, Lee, I found this while removing the last hack I was keeping in my ASoC tree. I originally thought that I had to set this on the driver's pdata, but it turns out it's needed on the DMA controller one instead. When booting with device-tree enabled the mask seems to be set automatically. Would you consider applying this with the other dma40 patches? Thanks, Fabio arch/arm/mach-ux500/devices-db8500.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-ux500/devices-db8500.c b/arch/arm/mach-ux500/devices-db8500.c index e21ffd8..fa8f7a5 100644 --- a/arch/arm/mach-ux500/devices-db8500.c +++ b/arch/arm/mach-ux500/devices-db8500.c @@ -49,6 +49,7 @@ struct stedma40_platform_data dma40_plat_data = { struct platform_device u8500_dma40_device = { .dev = { .platform_data = &dma40_plat_data, + .coherent_dma_mask = DMA_BIT_MASK(32), }, .name = "dma40", .id = 0,