| Message ID | 1371416058-22047-10-git-send-email-tomasz.figa@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Jun 16, 2013 at 10:54 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote: > With support for amba-pl08x driver, on S3C64xx the generic DMA engine API > can be used instead of the private s3c-dma interface. > > Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com> (...) > - select S3C64XX_DMA if ARCH_S3C64XX > + select S3C64XX_DMA if ARCH_S3C64XX && !S3C64XX_PL080 I guess this means the SPI driver does not work without DMA. But is the SPI driver already augmented to handle generic DMA engine? Anyway: Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Mon, Jun 17, 2013 at 03:59:39PM +0200, Linus Walleij wrote: > On Sun, Jun 16, 2013 at 10:54 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote: > > - select S3C64XX_DMA if ARCH_S3C64XX > > + select S3C64XX_DMA if ARCH_S3C64XX && !S3C64XX_PL080 > I guess this means the SPI driver does not work without DMA. > But is the SPI driver already augmented to handle generic DMA engine? > Anyway: Yes, the driver currently relies on DMA. There are some pending patches for non-DMA operation that I need to test. To be honest for both this and the ASoC driver I'd be more inclined to just either select or depend on the DMA controller rather than leaving the option of using the old code.
On Monday 17 of June 2013 17:06:30 Mark Brown wrote: > On Mon, Jun 17, 2013 at 03:59:39PM +0200, Linus Walleij wrote: > > On Sun, Jun 16, 2013 at 10:54 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote: > > > - select S3C64XX_DMA if ARCH_S3C64XX > > > + select S3C64XX_DMA if ARCH_S3C64XX && !S3C64XX_PL080 > > > > I guess this means the SPI driver does not work without DMA. > > But is the SPI driver already augmented to handle generic DMA engine? > > > Anyway: > Yes, the driver currently relies on DMA. There are some pending patches > for non-DMA operation that I need to test. To be honest for both this > and the ASoC driver I'd be more inclined to just either select or > depend on the DMA controller rather than leaving the option of using > the old code. Well, I just left this for the purpose of this RFC, so testing things on both drivers would be possible (to see if any problems are caused by new driver or just by things that don't work). If this driver turns out to be working correctly, I will happily remove the old private one and after s3c24xx moves to Heiko's DMA engine driver (or as it already moved?) we will be able to completely drop the private s3c-dma API. Best regards, Tomasz
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 2015897..8da1c22 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -366,7 +366,7 @@ config SPI_S3C24XX_FIQ config SPI_S3C64XX tristate "Samsung S3C64XX series type SPI" depends on (ARCH_S3C24XX || ARCH_S3C64XX || ARCH_S5P64X0 || ARCH_EXYNOS) - select S3C64XX_DMA if ARCH_S3C64XX + select S3C64XX_DMA if ARCH_S3C64XX && !S3C64XX_PL080 help SPI driver for Samsung S3C64XX and newer SoCs.
With support for amba-pl08x driver, on S3C64xx the generic DMA engine API can be used instead of the private s3c-dma interface. Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com> --- drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)