| Message ID | 1371490999-15501-7-git-send-email-sboyd@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Sending to correct Joerg address. On 06/17, Stephen Boyd wrote: > Calling clk_set_min_rate() is no better than just calling > clk_set_rate() because MSM clock code already takes care of > calling the min_rate ops if the clock really needs > clk_set_min_rate() called on it. > > Cc: Joerg Roedel <joerg.roedel@amd.com> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> > --- > drivers/iommu/msm_iommu_dev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/iommu/msm_iommu_dev.c b/drivers/iommu/msm_iommu_dev.c > index d344f6a..9144a6b 100644 > --- a/drivers/iommu/msm_iommu_dev.c > +++ b/drivers/iommu/msm_iommu_dev.c > @@ -29,7 +29,6 @@ > > #include <mach/iommu_hw-8xxx.h> > #include <mach/iommu.h> > -#include <mach/clk.h> > > struct iommu_ctx_iter_data { > /* input */ > @@ -168,7 +167,7 @@ static int msm_iommu_probe(struct platform_device *pdev) > > if (!IS_ERR(iommu_clk)) { > if (clk_get_rate(iommu_clk) == 0) > - clk_set_min_rate(iommu_clk, 1); > + clk_set_rate(iommu_clk, 1); > > ret = clk_prepare_enable(iommu_clk); > if (ret) { > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jun 20, 2013 at 09:41:42AM -0700, Stephen Boyd wrote: > Sending to correct Joerg address. > > On 06/17, Stephen Boyd wrote: > > Calling clk_set_min_rate() is no better than just calling > > clk_set_rate() because MSM clock code already takes care of > > calling the min_rate ops if the clock really needs > > clk_set_min_rate() called on it. > > > > Cc: Joerg Roedel <joerg.roedel@amd.com> > > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Acked-by: Joerg Roedel <joro@8bytes.org>
diff --git a/drivers/iommu/msm_iommu_dev.c b/drivers/iommu/msm_iommu_dev.c index d344f6a..9144a6b 100644 --- a/drivers/iommu/msm_iommu_dev.c +++ b/drivers/iommu/msm_iommu_dev.c @@ -29,7 +29,6 @@ #include <mach/iommu_hw-8xxx.h> #include <mach/iommu.h> -#include <mach/clk.h> struct iommu_ctx_iter_data { /* input */ @@ -168,7 +167,7 @@ static int msm_iommu_probe(struct platform_device *pdev) if (!IS_ERR(iommu_clk)) { if (clk_get_rate(iommu_clk) == 0) - clk_set_min_rate(iommu_clk, 1); + clk_set_rate(iommu_clk, 1); ret = clk_prepare_enable(iommu_clk); if (ret) {
Calling clk_set_min_rate() is no better than just calling clk_set_rate() because MSM clock code already takes care of calling the min_rate ops if the clock really needs clk_set_min_rate() called on it. Cc: Joerg Roedel <joerg.roedel@amd.com> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> --- drivers/iommu/msm_iommu_dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)