| Message ID | 1371739815-6666-2-git-send-email-mpa@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> From: Fabio Estevam <fabio.estevam@freescale.com> > > Similarly as it was done for mx6q, use a DT lookup in order to make maintainance > task for the clock devices easier. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > [Markus Pargmann: Add gpio clocks] > Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > --- > arch/arm/boot/dts/imx27.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi > index 0695264..48c263c 100644 > --- a/arch/arm/boot/dts/imx27.dtsi > +++ b/arch/arm/boot/dts/imx27.dtsi > @@ -208,6 +208,8 @@ > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > + clocks = <&clks 47>; > + clock-names = "ipg"; Clock is not used in the gpio driver, so I doubt the usefulness of this patch. ---
On Thu, Jun 20, 2013 at 12:28 PM, Alexander Shiyan <shc_work@mail.ru> wrote: >> From: Fabio Estevam <fabio.estevam@freescale.com> >> >> Similarly as it was done for mx6q, use a DT lookup in order to make maintainance >> task for the clock devices easier. >> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> >> [Markus Pargmann: Add gpio clocks] >> Signed-off-by: Markus Pargmann <mpa@pengutronix.de> >> --- >> arch/arm/boot/dts/imx27.dtsi | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi >> index 0695264..48c263c 100644 >> --- a/arch/arm/boot/dts/imx27.dtsi >> +++ b/arch/arm/boot/dts/imx27.dtsi >> @@ -208,6 +208,8 @@ >> #gpio-cells = <2>; >> interrupt-controller; >> #interrupt-cells = <2>; >> + clocks = <&clks 47>; >> + clock-names = "ipg"; > > Clock is not used in the gpio driver, so I doubt the usefulness of this patch. I think you meant "this hunk", right? My original patch did not have this part. It was added by Markus as mentioned in the commit log, and I agree we should go with the original version that did not add the gpio clock.
On Thu, Jun 20, 2013 at 12:35 PM, Fabio Estevam <festevam@gmail.com> wrote: > On Thu, Jun 20, 2013 at 12:28 PM, Alexander Shiyan <shc_work@mail.ru> wrote: >>> From: Fabio Estevam <fabio.estevam@freescale.com> >>> >>> Similarly as it was done for mx6q, use a DT lookup in order to make maintainance >>> task for the clock devices easier. >>> >>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> >>> [Markus Pargmann: Add gpio clocks] >>> Signed-off-by: Markus Pargmann <mpa@pengutronix.de> >>> --- >>> arch/arm/boot/dts/imx27.dtsi | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi >>> index 0695264..48c263c 100644 >>> --- a/arch/arm/boot/dts/imx27.dtsi >>> +++ b/arch/arm/boot/dts/imx27.dtsi >>> @@ -208,6 +208,8 @@ >>> #gpio-cells = <2>; >>> interrupt-controller; >>> #interrupt-cells = <2>; >>> + clocks = <&clks 47>; >>> + clock-names = "ipg"; >> >> Clock is not used in the gpio driver, so I doubt the usefulness of this patch. > > I think you meant "this hunk", right? > > My original patch did not have this part. It was added by Markus as > mentioned in the commit log, and I agree we should go with the > original version that did not add the gpio clock. Just checked and my original patch has already been applied: commit c20736f1aba75bd4251e96ef3f487beebbaf41cc Author: Fabio Estevam <fabio.estevam@freescale.com> Date: Wed Nov 28 15:55:30 2012 -0200 ARM: mx27: Replace clk_register_clkdev with clock DT lookup Similarly as it was done for mx6q, use a DT lookup in order to make maintain task for the clock devices easier. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Tested-by: Markus Pargmann <mpa@pengutronix.de> Signed-off-by: Shawn Guo <shawn.guo@linaro.org> , and it does not add the gpio clocks.
On Thu, Jun 20, 2013 at 12:35:10PM -0300, Fabio Estevam wrote: > On Thu, Jun 20, 2013 at 12:28 PM, Alexander Shiyan <shc_work@mail.ru> wrote: > >> From: Fabio Estevam <fabio.estevam@freescale.com> > >> > >> Similarly as it was done for mx6q, use a DT lookup in order to make maintainance > >> task for the clock devices easier. > >> > >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > >> [Markus Pargmann: Add gpio clocks] > >> Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > >> --- > >> arch/arm/boot/dts/imx27.dtsi | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi > >> index 0695264..48c263c 100644 > >> --- a/arch/arm/boot/dts/imx27.dtsi > >> +++ b/arch/arm/boot/dts/imx27.dtsi > >> @@ -208,6 +208,8 @@ > >> #gpio-cells = <2>; > >> interrupt-controller; > >> #interrupt-cells = <2>; > >> + clocks = <&clks 47>; > >> + clock-names = "ipg"; > > > > Clock is not used in the gpio driver, so I doubt the usefulness of this patch. > > I think you meant "this hunk", right? > > My original patch did not have this part. It was added by Markus as > mentioned in the commit log, and I agree we should go with the > original version that did not add the gpio clock. I somehow missed that your patch was applied in march. gpio clocks are not mentioned in the binding documentation, so I drop this one completely. Thanks, Markus
diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi index 0695264..48c263c 100644 --- a/arch/arm/boot/dts/imx27.dtsi +++ b/arch/arm/boot/dts/imx27.dtsi @@ -208,6 +208,8 @@ #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>; + clocks = <&clks 47>; + clock-names = "ipg"; }; gpio2: gpio@10015100 { @@ -218,6 +220,8 @@ #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>; + clocks = <&clks 47>; + clock-names = "ipg"; }; gpio3: gpio@10015200 { @@ -228,6 +232,8 @@ #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>; + clocks = <&clks 47>; + clock-names = "ipg"; }; gpio4: gpio@10015300 { @@ -238,6 +244,8 @@ #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>; + clocks = <&clks 47>; + clock-names = "ipg"; }; gpio5: gpio@10015400 { @@ -248,6 +256,8 @@ #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>; + clocks = <&clks 47>; + clock-names = "ipg"; }; gpio6: gpio@10015500 { @@ -258,6 +268,8 @@ #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>; + clocks = <&clks 47>; + clock-names = "ipg"; }; cspi3: cspi@10017000 {