| Message ID | 1371739815-6666-6-git-send-email-mpa@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jun 20, 2013 at 04:50:14PM +0200, Markus Pargmann wrote: > Set operating-points for imx27. There is no regulator support, so the > voltages are 0. The frequencies should be the same for all imx27 boards, > so it is defined here and can be overwritten if necessary. > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > --- > arch/arm/boot/dts/imx27.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi > index e883e77..3ebd98a 100644 > --- a/arch/arm/boot/dts/imx27.dtsi > +++ b/arch/arm/boot/dts/imx27.dtsi > @@ -47,6 +47,25 @@ > }; > }; > > + cpus { > + #size-cells = <0>; > + #address-cells = <1>; > + > + cpu@0 { > + device_type = "cpu"; > + compatible = "fsl,imx27", "arm,arm926ejs"; From what Documentation/devicetree/bindings/arm/cpus.txt tells, it should be "arm,arm926". Also, why do you put "fsl,imx27" there? "imx27" is a SoC name not cpu core. Shawn > + reg = <0>; > + operating-points = < > + /* kHz uV (No regulator support) */ > + 133000 0 > + 399000 0 > + >; > + clock-latency = <61036>; /* two CLK32 periods */ > + clocks = <&clks 18>; > + clock-names = "cpu"; > + }; > + }; > + > soc { > #address-cells = <1>; > #size-cells = <1>; > -- > 1.8.2.1 >
> On Thu, Jun 20, 2013 at 04:50:14PM +0200, Markus Pargmann wrote: > > Set operating-points for imx27. There is no regulator support, so the > > voltages are 0. The frequencies should be the same for all imx27 boards, > > so it is defined here and can be overwritten if necessary. > > > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > > --- > > arch/arm/boot/dts/imx27.dtsi | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi > > index e883e77..3ebd98a 100644 > > --- a/arch/arm/boot/dts/imx27.dtsi > > +++ b/arch/arm/boot/dts/imx27.dtsi > > @@ -47,6 +47,25 @@ > > }; > > }; > > > > + cpus { > > + #size-cells = <0>; > > + #address-cells = <1>; > > + > > + cpu@0 { > > + device_type = "cpu"; > > + compatible = "fsl,imx27", "arm,arm926ejs"; > > From what Documentation/devicetree/bindings/arm/cpus.txt tells, it > should be "arm,arm926". Also, why do you put "fsl,imx27" there? > "imx27" is a SoC name not cpu core. I think Markus take this ARM property from one of existing DTS. shc@shc /home/git/linux-mx27/arch/arm/boot/dts $ grep arm926 *.dtsi at91sam9260.dtsi: compatible = "arm,arm926ejs"; at91sam9263.dtsi: compatible = "arm,arm926ejs"; at91sam9g45.dtsi: compatible = "arm,arm926ejs"; at91sam9n12.dtsi: compatible = "arm,arm926ejs"; at91sam9x5.dtsi: compatible = "arm,arm926ejs"; imx23.dtsi: compatible = "arm,arm926ejs"; imx28.dtsi: compatible = "arm,arm926ejs"; lpc32xx.dtsi: compatible = "arm,arm926ejs"; s3c2416.dtsi: compatible = "arm,arm926ejs"; spear3xx.dtsi: compatible = "arm,arm926ejs"; spear600.dtsi: compatible = "arm,arm926ejs"; wm8505.dtsi: compatible = "arm,arm926ejs"; So, documentation need to be updated or these values should be fixed. Another solution is specify compatible string as: compatible = "arm,arm926ejs", "arm,arm926"; What you think about this? ---
On Fri, Jun 21, 2013 at 08:54:53AM +0400, Alexander Shiyan wrote: > > On Thu, Jun 20, 2013 at 04:50:14PM +0200, Markus Pargmann wrote: > > > + cpus { > > > + #size-cells = <0>; > > > + #address-cells = <1>; > > > + > > > + cpu@0 { > > > + device_type = "cpu"; > > > + compatible = "fsl,imx27", "arm,arm926ejs"; > > > > From what Documentation/devicetree/bindings/arm/cpus.txt tells, it > > should be "arm,arm926". Also, why do you put "fsl,imx27" there? > > "imx27" is a SoC name not cpu core. > > I think Markus take this ARM property from one of existing DTS. > > shc@shc /home/git/linux-mx27/arch/arm/boot/dts $ grep arm926 *.dtsi > at91sam9260.dtsi: compatible = "arm,arm926ejs"; > at91sam9263.dtsi: compatible = "arm,arm926ejs"; > at91sam9g45.dtsi: compatible = "arm,arm926ejs"; > at91sam9n12.dtsi: compatible = "arm,arm926ejs"; > at91sam9x5.dtsi: compatible = "arm,arm926ejs"; > imx23.dtsi: compatible = "arm,arm926ejs"; > imx28.dtsi: compatible = "arm,arm926ejs"; > lpc32xx.dtsi: compatible = "arm,arm926ejs"; > s3c2416.dtsi: compatible = "arm,arm926ejs"; > spear3xx.dtsi: compatible = "arm,arm926ejs"; > spear600.dtsi: compatible = "arm,arm926ejs"; > wm8505.dtsi: compatible = "arm,arm926ejs"; > > So, documentation need to be updated or these values should be fixed. > Another solution is specify compatible string as: > compatible = "arm,arm926ejs", "arm,arm926"; > What you think about this? I assume that the compatible string in the binding doc has been reviewed and agreed by people, so we should fix the existing users before kernel starts using it to for matching something. Lorenzo, comment? Shawn
On Fri, Jun 21, 2013 at 06:23:46AM +0100, Shawn Guo wrote: > On Fri, Jun 21, 2013 at 08:54:53AM +0400, Alexander Shiyan wrote: > > > On Thu, Jun 20, 2013 at 04:50:14PM +0200, Markus Pargmann wrote: > > > > + cpus { > > > > + #size-cells = <0>; > > > > + #address-cells = <1>; > > > > + > > > > + cpu@0 { > > > > + device_type = "cpu"; > > > > + compatible = "fsl,imx27", "arm,arm926ejs"; > > > > > > From what Documentation/devicetree/bindings/arm/cpus.txt tells, it > > > should be "arm,arm926". Also, why do you put "fsl,imx27" there? > > > "imx27" is a SoC name not cpu core. > > > > I think Markus take this ARM property from one of existing DTS. > > > > shc@shc /home/git/linux-mx27/arch/arm/boot/dts $ grep arm926 *.dtsi > > at91sam9260.dtsi: compatible = "arm,arm926ejs"; > > at91sam9263.dtsi: compatible = "arm,arm926ejs"; > > at91sam9g45.dtsi: compatible = "arm,arm926ejs"; > > at91sam9n12.dtsi: compatible = "arm,arm926ejs"; > > at91sam9x5.dtsi: compatible = "arm,arm926ejs"; > > imx23.dtsi: compatible = "arm,arm926ejs"; > > imx28.dtsi: compatible = "arm,arm926ejs"; > > lpc32xx.dtsi: compatible = "arm,arm926ejs"; > > s3c2416.dtsi: compatible = "arm,arm926ejs"; > > spear3xx.dtsi: compatible = "arm,arm926ejs"; > > spear600.dtsi: compatible = "arm,arm926ejs"; > > wm8505.dtsi: compatible = "arm,arm926ejs"; > > > > So, documentation need to be updated or these values should be fixed. > > Another solution is specify compatible string as: > > compatible = "arm,arm926ejs", "arm,arm926"; > > What you think about this? > > I assume that the compatible string in the binding doc has been reviewed > and agreed by people, so we should fix the existing users before kernel > starts using it to for matching something. > > Lorenzo, comment? I patched them all and changes are queued through arm-soc, according to the latest bindings that should get merged this cycle and are available here: git://linux-arm.org/linux-2.6-lp.git dt-cpus-bindings If you are queuing dts updates please follow rules in there, waiting for that document to get merged. Lorenzo
On Fri, Jun 21, 2013 at 09:47:40AM +0100, Lorenzo Pieralisi wrote: > On Fri, Jun 21, 2013 at 06:23:46AM +0100, Shawn Guo wrote: > > On Fri, Jun 21, 2013 at 08:54:53AM +0400, Alexander Shiyan wrote: > > > > On Thu, Jun 20, 2013 at 04:50:14PM +0200, Markus Pargmann wrote: > > > > > + cpus { > > > > > + #size-cells = <0>; > > > > > + #address-cells = <1>; > > > > > + > > > > > + cpu@0 { > > > > > + device_type = "cpu"; > > > > > + compatible = "fsl,imx27", "arm,arm926ejs"; > > > > > > > > From what Documentation/devicetree/bindings/arm/cpus.txt tells, it > > > > should be "arm,arm926". Also, why do you put "fsl,imx27" there? > > > > "imx27" is a SoC name not cpu core. > > > > > > I think Markus take this ARM property from one of existing DTS. > > > > > > shc@shc /home/git/linux-mx27/arch/arm/boot/dts $ grep arm926 *.dtsi > > > at91sam9260.dtsi: compatible = "arm,arm926ejs"; > > > at91sam9263.dtsi: compatible = "arm,arm926ejs"; > > > at91sam9g45.dtsi: compatible = "arm,arm926ejs"; > > > at91sam9n12.dtsi: compatible = "arm,arm926ejs"; > > > at91sam9x5.dtsi: compatible = "arm,arm926ejs"; > > > imx23.dtsi: compatible = "arm,arm926ejs"; > > > imx28.dtsi: compatible = "arm,arm926ejs"; > > > lpc32xx.dtsi: compatible = "arm,arm926ejs"; > > > s3c2416.dtsi: compatible = "arm,arm926ejs"; > > > spear3xx.dtsi: compatible = "arm,arm926ejs"; > > > spear600.dtsi: compatible = "arm,arm926ejs"; > > > wm8505.dtsi: compatible = "arm,arm926ejs"; > > > > > > So, documentation need to be updated or these values should be fixed. > > > Another solution is specify compatible string as: > > > compatible = "arm,arm926ejs", "arm,arm926"; > > > What you think about this? > > > > I assume that the compatible string in the binding doc has been reviewed > > and agreed by people, so we should fix the existing users before kernel > > starts using it to for matching something. > > > > Lorenzo, comment? > > I patched them all and changes are queued through arm-soc, according to the > latest bindings that should get merged this cycle and are available here: > > git://linux-arm.org/linux-2.6-lp.git dt-cpus-bindings > > If you are queuing dts updates please follow rules in there, waiting for > that document to get merged. > > Lorenzo > Okay, I changed it to "arm,arm926ej-s" and removed "reg" as described in the dt-cpus-bindings branch documentation. Thanks, Markus >
diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi index e883e77..3ebd98a 100644 --- a/arch/arm/boot/dts/imx27.dtsi +++ b/arch/arm/boot/dts/imx27.dtsi @@ -47,6 +47,25 @@ }; }; + cpus { + #size-cells = <0>; + #address-cells = <1>; + + cpu@0 { + device_type = "cpu"; + compatible = "fsl,imx27", "arm,arm926ejs"; + reg = <0>; + operating-points = < + /* kHz uV (No regulator support) */ + 133000 0 + 399000 0 + >; + clock-latency = <61036>; /* two CLK32 periods */ + clocks = <&clks 18>; + clock-names = "cpu"; + }; + }; + soc { #address-cells = <1>; #size-cells = <1>;
Set operating-points for imx27. There is no regulator support, so the voltages are 0. The frequencies should be the same for all imx27 boards, so it is defined here and can be overwritten if necessary. Signed-off-by: Markus Pargmann <mpa@pengutronix.de> --- arch/arm/boot/dts/imx27.dtsi | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)