From patchwork Sat Jun 22 16:52:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 2765911 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7F7BDC0AB1 for ; Sat, 22 Jun 2013 16:53:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9B06520106 for ; Sat, 22 Jun 2013 16:53:32 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C8C120105 for ; Sat, 22 Jun 2013 16:53:31 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UqR3w-0005Af-9k; Sat, 22 Jun 2013 16:53:20 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UqR3t-0001R7-O2; Sat, 22 Jun 2013 16:53:17 +0000 Received: from mail-ea0-f179.google.com ([209.85.215.179]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UqR3q-0001Ql-91 for linux-arm-kernel@lists.infradead.org; Sat, 22 Jun 2013 16:53:15 +0000 Received: by mail-ea0-f179.google.com with SMTP id b15so5244387eae.24 for ; Sat, 22 Jun 2013 09:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=y2QZlCZaf4L2yLaYQOUsFg7O8DcZK8SFRFoxusTM4pY=; b=zVGR2PJP546xU1Bh8pseVUao7i6I+7tY4r7nt5/mWlvcwSGuAYObUVhnUPAvDiEQN/ IBMAetCCv8YI9g9EPso/J/u/yPKZjs52CNH0MqMZ0RygTXEhK+176+UOVvBiLnvrucP6 wHE7vti1t0M2hwSBXJaRlNZ2lXc+UCk7UPDFFG9VQo03LPWoFWM+bs9VI5SkGw8+YYG7 jA+mYVwO1e3pv+Pg1dJnPfAvRBaZj3mTCDH+TDlzVj3XCn95uVwVUiHGzd0amRyrZFdm EbNedXsb6/Z1rFGNGZ+qzqEDF8n6HnEJ9jOwOqGoccbWG4Nej9nzWTPBbxqqXJYug6S1 +ulw== X-Received: by 10.14.95.135 with SMTP id p7mr17679872eef.16.1371919963451; Sat, 22 Jun 2013 09:52:43 -0700 (PDT) Received: from localhost.localdomain ([190.2.109.15]) by mx.google.com with ESMTPSA id w43sm15638039eez.6.2013.06.22.09.52.37 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 22 Jun 2013 09:52:42 -0700 (PDT) From: Ezequiel Garcia To: Subject: [PATCH for v3.11] ARM: mvebu: fix length of ethernet registers in mv78260 dtsi Date: Sat, 22 Jun 2013 13:52:27 -0300 Message-Id: <1371919947-28872-1-git-send-email-elezegarcia@gmail.com> X-Mailer: git-send-email 1.8.1.5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130622_125314_505075_CF66E24A X-CRM114-Status: GOOD ( 13.69 ) X-Spam-Score: -2.7 (--) Cc: Thomas Petazzoni , Lior Amsalem , Jason Cooper , Arnd Bergmann , Maen Suleiman , Gregory Clement , Andrew Lunn , Ezequiel Garcia , Olof Johansson X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Ezequiel Garcia The length of the registers area for the Marvell 370/XP Ethernet controller was incorrect in the .dtsi: 0x2500, while it should have been 0x4000. This problem wasn't noticed because there used to be a static mapping for all the MMIO register region set up by ->map_io(). The register length was fixed in all the other device tree files, except from the armada-xp-mv78260.dtsi, in the following commit: commit cf8088c5cac6ce20d914b9131533844b9291a054 Author: Thomas Petazzoni Date: Tue May 21 12:33:27 2013 +0200 arm: mvebu: fix length of Ethernet registers area in .dtsi This commit fixes a kernel panic in mvneta_probe(), when the kernel tries to access the unmapped registers: [ 163.639092] mvneta d0070000.ethernet eth0: mac: 6e:3c:4f:87:17:2e [ 163.646962] mvneta d0074000.ethernet eth1: mac: 6a:04:4e:6f:f5:ef [ 163.654853] mvneta d0030000.ethernet eth2: mac: 2a:99:19:19:fc:4c [ 163.661258] Unable to handle kernel paging request at virtual address f011bcf0 [ 163.668523] pgd = c0004000 [ 163.671237] [f011bcf0] *pgd=2f006811, *pte=00000000, *ppte=00000000 [ 163.677565] Internal error: Oops: 807 [#1] SMP ARM [ 163.682370] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.10.0-rc6-01850-gba0682e #11 [ 163.690046] task: ef04c000 ti: ef03e000 task.ti: ef03e000 [ 163.695467] PC is at mvneta_probe+0x34c/0xabc [...] Signed-off-by: Ezequiel Garcia Acked-by: Thomas Petazzoni --- arch/arm/boot/dts/armada-xp-mv78260.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/armada-xp-mv78260.dtsi b/arch/arm/boot/dts/armada-xp-mv78260.dtsi index f4029f0..2d9335d 100644 --- a/arch/arm/boot/dts/armada-xp-mv78260.dtsi +++ b/arch/arm/boot/dts/armada-xp-mv78260.dtsi @@ -92,7 +92,7 @@ ethernet@34000 { compatible = "marvell,armada-370-neta"; - reg = <0x34000 0x2500>; + reg = <0x34000 0x4000>; interrupts = <14>; clocks = <&gateclk 1>; status = "disabled";