diff mbox

arm: dts: AM43x: Add usb_otg_hs node

Message ID 1372401887-19422-1-git-send-email-george.cherian@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

George Cherian June 28, 2013, 6:44 a.m. UTC
Adds device node for HS USB Host module for AM437x

Signed-off-by: George Cherian <george.cherian@ti.com>
---
 This patch is on top of 
 git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git for_3.11/dts

 arch/arm/boot/dts/am4372.dtsi | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

Comments

Felipe Balbi July 7, 2013, 8:35 a.m. UTC | #1
Hi,

On Fri, Jun 28, 2013 at 12:14:47PM +0530, George Cherian wrote:
> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> index ddc1df7..e4f5eb8 100644
> --- a/arch/arm/boot/dts/am4372.dtsi
> +++ b/arch/arm/boot/dts/am4372.dtsi
> @@ -64,5 +64,24 @@
>  			compatible = "ti,am4372-counter32k","ti,omap-counter32k";
>  			reg = <0x44e86000 0x40>;
>  		};
> +
> +		usb_otg_hs1: am4372_dwc3@48380000 {
> +			compatible = "ti,am437x-dwc3";
> +			reg = <0x48380000 0x1ff>;
> +			interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			utmi-mode = <1>;
> +			ranges;
> +
> +			dwc3@48390000 {
> +				compatible = "synopsys,dwc3";

let's us snps,dwc3. I recently posted a patch converting synopsys to
snps like all other DesignWare drivers. Support for synopsys,dwc3 is
still there, but shouldn't be used.

> +				reg = <0x48390000 0xcfff>;
> +				interrupts = <GIC_SPI  168 IRQ_TYPE_LEVEL_HIGH>;
> +				tx-fifo-resize;

is this flag *really* necessary, I asked you and didn't get an answer.
George Cherian July 8, 2013, 5:20 a.m. UTC | #2
On 7/7/2013 2:05 PM, Felipe Balbi wrote:
> Hi,
>
> On Fri, Jun 28, 2013 at 12:14:47PM +0530, George Cherian wrote:
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index ddc1df7..e4f5eb8 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -64,5 +64,24 @@
>>   			compatible = "ti,am4372-counter32k","ti,omap-counter32k";
>>   			reg = <0x44e86000 0x40>;
>>   		};
>> +
>> +		usb_otg_hs1: am4372_dwc3@48380000 {
>> +			compatible = "ti,am437x-dwc3";
>> +			reg = <0x48380000 0x1ff>;
>> +			interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +			utmi-mode = <1>;
>> +			ranges;
>> +
>> +			dwc3@48390000 {
>> +				compatible = "synopsys,dwc3";
> let's us snps,dwc3. I recently posted a patch converting synopsys to
> snps like all other DesignWare drivers. Support for synopsys,dwc3 is
> still there, but shouldn't be used.
okay
>
>> +				reg = <0x48390000 0xcfff>;
>> +				interrupts = <GIC_SPI  168 IRQ_TYPE_LEVEL_HIGH>;
>> +				tx-fifo-resize;
> is this flag *really* necessary, I asked you and didn't get an answer.
We will not be needing this flag , since each EP has 3K tx fifo size. 
Also given the fact that we will be operating only
in 2.0 mode the default values are only sufficient.
I will re-send the patch with above changes.

Regards,
-George
diff mbox

Patch

diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
index ddc1df7..e4f5eb8 100644
--- a/arch/arm/boot/dts/am4372.dtsi
+++ b/arch/arm/boot/dts/am4372.dtsi
@@ -64,5 +64,24 @@ 
 			compatible = "ti,am4372-counter32k","ti,omap-counter32k";
 			reg = <0x44e86000 0x40>;
 		};
+
+		usb_otg_hs1: am4372_dwc3@48380000 {
+			compatible = "ti,am437x-dwc3";
+			reg = <0x48380000 0x1ff>;
+			interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			utmi-mode = <1>;
+			ranges;
+
+			dwc3@48390000 {
+				compatible = "synopsys,dwc3";
+				reg = <0x48390000 0xcfff>;
+				interrupts = <GIC_SPI  168 IRQ_TYPE_LEVEL_HIGH>;
+				tx-fifo-resize;
+			};
+
+		};
+
 	};
 };