| Message ID | 1372431037-13519-3-git-send-email-mpa@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > --- > arch/arm/boot/dts/imx27.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi > index 8603886..10dcbd3 100644 > --- a/arch/arm/boot/dts/imx27.dtsi > +++ b/arch/arm/boot/dts/imx27.dtsi > @@ -342,6 +342,15 @@ > reg = <0x10020000 0x20000>; > ranges; > > + imxfb: fb@10021000 { If it can be fixed while applying, it would be right to use just "fb" here. We now use a lot of devices without "imx"-prefix, so I do not see any need to use it here. > + compatible = "fsl,imx27-fb", "fsl,imx21-fb"; > + interrupts = <61>; > + reg = <0x10021000 0x1000>; > + clocks = <&clks 36>, <&clks 65>, <&clks 59>; > + clock-names = "ipg", "ahb", "per"; > + status = "disabled"; > + }; > + ---
On Fri, Jun 28, 2013 at 07:10:06PM +0400, Alexander Shiyan wrote: > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > > --- > > arch/arm/boot/dts/imx27.dtsi | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi > > index 8603886..10dcbd3 100644 > > --- a/arch/arm/boot/dts/imx27.dtsi > > +++ b/arch/arm/boot/dts/imx27.dtsi > > @@ -342,6 +342,15 @@ > > reg = <0x10020000 0x20000>; > > ranges; > > > > + imxfb: fb@10021000 { > > If it can be fixed while applying, it would be right to use just "fb" here. > We now use a lot of devices without "imx"-prefix, so I do not see any need to use it here. I actually prefer to use the block name if it's not a thing defined by ePAPR. In this case, it's "lcdc". But since "fb" is already used in compatible. Okay, I fixed it up by dropping "imx" prefix. Applied the whole series, thanks. Shawn
> On Fri, Jun 28, 2013 at 07:10:06PM +0400, Alexander Shiyan wrote: > > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > > > --- > > > arch/arm/boot/dts/imx27.dtsi | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi > > > index 8603886..10dcbd3 100644 > > > --- a/arch/arm/boot/dts/imx27.dtsi > > > +++ b/arch/arm/boot/dts/imx27.dtsi > > > @@ -342,6 +342,15 @@ > > > reg = <0x10020000 0x20000>; > > > ranges; > > > > > > + imxfb: fb@10021000 { > > > > If it can be fixed while applying, it would be right to use just "fb" here. > > We now use a lot of devices without "imx"-prefix, so I do not see any need to use it here. > > I actually prefer to use the block name if it's not a thing defined by > ePAPR. In this case, it's "lcdc". But since "fb" is already used in > compatible. Okay, I fixed it up by dropping "imx" prefix. i.MX27 have a SLCDC module, so perhaps your proposed option (lcdc) is better. ---
diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi index 8603886..10dcbd3 100644 --- a/arch/arm/boot/dts/imx27.dtsi +++ b/arch/arm/boot/dts/imx27.dtsi @@ -342,6 +342,15 @@ reg = <0x10020000 0x20000>; ranges; + imxfb: fb@10021000 { + compatible = "fsl,imx27-fb", "fsl,imx21-fb"; + interrupts = <61>; + reg = <0x10021000 0x1000>; + clocks = <&clks 36>, <&clks 65>, <&clks 59>; + clock-names = "ipg", "ahb", "per"; + status = "disabled"; + }; + coda: coda@10023000 { compatible = "fsl,imx27-vpu"; reg = <0x10023000 0x0200>;
Signed-off-by: Markus Pargmann <mpa@pengutronix.de> --- arch/arm/boot/dts/imx27.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)