| Message ID | 1374490361-25769-1-git-send-email-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 22 July 2013 16:22, Lee Jones <lee.jones@linaro.org> wrote: > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > arch/arm/boot/dts/spear300.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) For all three SPEAr Patches. Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On 22/07/13 11:52, Lee Jones wrote: > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > arch/arm/boot/dts/hrefv60plus.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/hrefv60plus.dts b/arch/arm/boot/dts/hrefv60plus.dts > index 3d580d6..46fd8af 100644 > --- a/arch/arm/boot/dts/hrefv60plus.dts > +++ b/arch/arm/boot/dts/hrefv60plus.dts > @@ -26,7 +26,7 @@ > > soc { > i2c@80110000 { > - bu21013_tp@0x5c { > + bu21013_tp@5c { Just a query ... why this one .... ^^^ ... > reset-gpio = <&gpio4 15 0x4>; ... and not this one .................................. ^^^ ? > }; > }; > The same for all the other patches in this series. If this is by design, it might be worth mentioning why some are removed and not others. Mark J.
On Mon, 22 Jul 2013, Mark Jackson wrote: > On 22/07/13 11:52, Lee Jones wrote: > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > arch/arm/boot/dts/hrefv60plus.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/hrefv60plus.dts b/arch/arm/boot/dts/hrefv60plus.dts > > index 3d580d6..46fd8af 100644 > > --- a/arch/arm/boot/dts/hrefv60plus.dts > > +++ b/arch/arm/boot/dts/hrefv60plus.dts > > @@ -26,7 +26,7 @@ > > > > soc { > > i2c@80110000 { > > - bu21013_tp@0x5c { > > + bu21013_tp@5c { > > Just a query ... why this one .... ^^^ ... > > > reset-gpio = <&gpio4 15 0x4>; > > ... and not this one .................................. ^^^ ? > > > }; > > }; > > > > The same for all the other patches in this series. > > If this is by design, it might be worth mentioning why some are > removed and not others. I can't explain why there seems to be inconsistencies between node names and the remaining properties. The best I can do is refer you to the documentation where you can see that this is the standard: Documentation/devicetree/usage-model.txt and http://www.devicetree.org/Device_Tree_Usage
On 22/07/13 14:41, Lee Jones wrote: > On Mon, 22 Jul 2013, Mark Jackson wrote: > >> On 22/07/13 11:52, Lee Jones wrote: >>> Signed-off-by: Lee Jones <lee.jones@linaro.org> >>> --- >>> arch/arm/boot/dts/hrefv60plus.dts | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/hrefv60plus.dts b/arch/arm/boot/dts/hrefv60plus.dts >>> index 3d580d6..46fd8af 100644 >>> --- a/arch/arm/boot/dts/hrefv60plus.dts >>> +++ b/arch/arm/boot/dts/hrefv60plus.dts >>> @@ -26,7 +26,7 @@ >>> >>> soc { >>> i2c@80110000 { >>> - bu21013_tp@0x5c { >>> + bu21013_tp@5c { >> >> Just a query ... why this one .... ^^^ ... >> >>> reset-gpio = <&gpio4 15 0x4>; >> >> ... and not this one .................................. ^^^ ? >> >>> }; >>> }; >>> >> >> The same for all the other patches in this series. >> >> If this is by design, it might be worth mentioning why some are >> removed and not others. > > I can't explain why there seems to be inconsistencies between node > names and the remaining properties. The best I can do is refer you to > the documentation where you can see that this is the standard: > > Documentation/devicetree/usage-model.txt > and > http://www.devicetree.org/Device_Tree_Usage Ho, ho ... don't you just love "standards" !!
On Mon, Jul 22, 2013 at 12:52 PM, Lee Jones <lee.jones@linaro.org> wrote:
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
None of these patches apply since I applied your other patch series
that rename all the files ... can you respin the ux500 "0x"-strip patches
on top of the rename set? My ux500-devicetree branch can be used
as a baseline.
Yours,
Linus Walleij
On Wed, 07 Aug 2013, Linus Walleij wrote: > On Mon, Jul 22, 2013 at 12:52 PM, Lee Jones <lee.jones@linaro.org> wrote: > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > None of these patches apply since I applied your other patch series > that rename all the files ... can you respin the ux500 "0x"-strip patches > on top of the rename set? My ux500-devicetree branch can be used > as a baseline. I can do that. Although, would you prefer that I fixed-up my renaming patches, then applied the 0x patches on top instead?
diff --git a/arch/arm/boot/dts/hrefv60plus.dts b/arch/arm/boot/dts/hrefv60plus.dts index 3d580d6..46fd8af 100644 --- a/arch/arm/boot/dts/hrefv60plus.dts +++ b/arch/arm/boot/dts/hrefv60plus.dts @@ -26,7 +26,7 @@ soc { i2c@80110000 { - bu21013_tp@0x5c { + bu21013_tp@5c { reset-gpio = <&gpio4 15 0x4>; }; };
Signed-off-by: Lee Jones <lee.jones@linaro.org> --- arch/arm/boot/dts/hrefv60plus.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)