| Message ID | 1374766502-14823-2-git-send-email-a.motakis@virtualopensystems.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> -----Original Message----- > From: Antonios Motakis [mailto:a.motakis@virtualopensystems.com] > Sent: Friday, July 26, 2013 12:35 AM > > On success, the __sysmmu_enable returns 1 instead of 0, which does not > respect the convention described in Chapter 16 of the Linux kernel coding > style. > > In fact, this return value is propagated all the way up to > iommu_attach_device() and iommu_attach_device() in drivers/iommu.c, > which results into inconsistent behavior of the IOMMU API with Exynos > systems, compared to other IOMMUs. > > This patch replaces the return value with 0, which makes the Exynos' > IOMMU driver behavior consistent with that of other IOMMUs. > > Signed-off-by: Antonios Motakis <a.motakis@virtualopensystems.com> > --- > drivers/iommu/exynos-iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index c7dd4b5..4ea3abb 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -504,7 +504,7 @@ static int __sysmmu_enable(struct sysmmu_drvdata *data, > > dev_dbg(data->sysmmu, "Enabled\n"); > } else { > - ret = (pgtable == data->pgtable) ? 1 : -EBUSY; > + ret = (pgtable == data->pgtable) ? 0 : -EBUSY; > Ok. __sysmmu_enable() must return 1 if it is called with the same page table. I have fixed it exynos_iommu_attach_device() to always return zero on success in the next patchset which I will post today. Thank you. > dev_dbg(data->sysmmu, "already enabled\n"); > } > -- > 1.8.1.2
KyongHo, On Fri, Jul 26, 2013 at 07:46:01PM +0900, Cho KyongHo wrote: > __sysmmu_enable() must return 1 if it is called with the same page table. > I have fixed it exynos_iommu_attach_device() to always return zero on success > in the next patchset which I will post today. > > Thank you. When you are fine with these patches please put them on-top of your patch-set when you re-submit. I will take them from there then. Joerg
On Wed, 14 Aug 2013 15:15:49 +0200, 'Joerg Roedel' wrote: > KyongHo, > > On Fri, Jul 26, 2013 at 07:46:01PM +0900, Cho KyongHo wrote: > > __sysmmu_enable() must return 1 if it is called with the same page table. > > I have fixed it exynos_iommu_attach_device() to always return zero on success > > in the next patchset which I will post today. > > > > Thank you. > > When you are fine with these patches please put them on-top of your > patch-set when you re-submit. I will take them from there then. > Ok. Antonios, Would you mind if I submit your 2 patches on top of my patches with your signed-off? KyongHo. > > Joerg > >
Yes, of course, I have no objections. On Fri, Aug 16, 2013 at 1:21 PM, Cho KyongHo <pullip.cho@samsung.com> wrote: > On Wed, 14 Aug 2013 15:15:49 +0200, 'Joerg Roedel' wrote: >> KyongHo, >> >> On Fri, Jul 26, 2013 at 07:46:01PM +0900, Cho KyongHo wrote: >> > __sysmmu_enable() must return 1 if it is called with the same page table. >> > I have fixed it exynos_iommu_attach_device() to always return zero on success >> > in the next patchset which I will post today. >> > >> > Thank you. >> >> When you are fine with these patches please put them on-top of your >> patch-set when you re-submit. I will take them from there then. >> > > Ok. > > Antonios, > > Would you mind > if I submit your 2 patches on top of my patches with your signed-off? > > KyongHo. > >> >> Joerg >> >>
diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index c7dd4b5..4ea3abb 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -504,7 +504,7 @@ static int __sysmmu_enable(struct sysmmu_drvdata *data, dev_dbg(data->sysmmu, "Enabled\n"); } else { - ret = (pgtable == data->pgtable) ? 1 : -EBUSY; + ret = (pgtable == data->pgtable) ? 0 : -EBUSY; dev_dbg(data->sysmmu, "already enabled\n"); }
On success, the __sysmmu_enable returns 1 instead of 0, which does not respect the convention described in Chapter 16 of the Linux kernel coding style. In fact, this return value is propagated all the way up to iommu_attach_device() and iommu_attach_device() in drivers/iommu.c, which results into inconsistent behavior of the IOMMU API with Exynos systems, compared to other IOMMUs. This patch replaces the return value with 0, which makes the Exynos' IOMMU driver behavior consistent with that of other IOMMUs. Signed-off-by: Antonios Motakis <a.motakis@virtualopensystems.com> --- drivers/iommu/exynos-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)