| Message ID | 1375281480-25775-1-git-send-email-LW@KARO-electronics.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/31/2013 08:37 AM, Lothar Waßmann wrote: These really need patch descriptions. I'm not sure if doing multiple things at once in a patch is a good idea, although admittedly otherwise it'd mean a lot of trivial patches.
Hello. On 07/31/2013 06:37 PM, Lothar Waßmann wrote: > Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de> > --- > arch/arm/boot/dts/imx28.dtsi | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi > index 47fc5ef..0360acc 100644 > --- a/arch/arm/boot/dts/imx28.dtsi > +++ b/arch/arm/boot/dts/imx28.dtsi > @@ -731,9 +731,9 @@ > }; > > dcp@80028000 { > + compatible = "fsl-dcp"; Hm, why not the usual "fsl,dcp", where "fsl" is Freescale's stock ticker? > reg = <0x80028000 0x2000>; > interrupts = <52 53 54>; > - compatible = "fsl-dcp"; > }; WBR, Sergei
Hi, Sergei Shtylyov writes: > Hello. > > On 07/31/2013 06:37 PM, Lothar Waßmann wrote: > > > Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de> > > --- > > arch/arm/boot/dts/imx28.dtsi | 5 ++--- > > 1 files changed, 2 insertions(+), 3 deletions(-) > > > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi > > index 47fc5ef..0360acc 100644 > > --- a/arch/arm/boot/dts/imx28.dtsi > > +++ b/arch/arm/boot/dts/imx28.dtsi > > @@ -731,9 +731,9 @@ > > }; > > > > dcp@80028000 { > > + compatible = "fsl-dcp"; > > Hm, why not the usual "fsl,dcp", where "fsl" is Freescale's stock ticker? > Don't ask me, but the author of the patch that introduced this (CC'ed), or the maintainer who accepted this in the first place. Lothar Waßmann
On 01.08.2013 07:57, Lothar Waßmann wrote: > Hi, > > Sergei Shtylyov writes: >> Hello. >> >> On 07/31/2013 06:37 PM, Lothar Waßmann wrote: >>> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi >>> index 47fc5ef..0360acc 100644 >>> --- a/arch/arm/boot/dts/imx28.dtsi >>> +++ b/arch/arm/boot/dts/imx28.dtsi >>> @@ -731,9 +731,9 @@ >>> }; >>> >>> dcp@80028000 { >>> + compatible = "fsl-dcp"; >> Hm, why not the usual "fsl,dcp", where "fsl" is Freescale's stock ticker? >> > Don't ask me, but the author of the patch that introduced this > (CC'ed), or the maintainer who accepted this in the first place. Hi! The simple reason is that I didn't know it better when I wrote this. I think I can send a patch until Monday. But feel free to change it yourself if you want. Tobias
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 47fc5ef..0360acc 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -731,9 +731,9 @@ }; dcp@80028000 { + compatible = "fsl-dcp"; reg = <0x80028000 0x2000>; interrupts = <52 53 54>; - compatible = "fsl-dcp"; }; pxp@8002a000 { @@ -815,7 +815,7 @@ reg = <0x8003c800 0x100>; status = "disabled"; }; - }; + }; apbx@80040000 { compatible = "simple-bus"; @@ -1045,6 +1045,5 @@ reg = <0x800f8000 0x8000>; status = "disabled"; }; - }; };
Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de> --- arch/arm/boot/dts/imx28.dtsi | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)