From patchwork Thu Aug 1 12:36:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas KANDAGATLA X-Patchwork-Id: 2836970 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 10E1E9F9FA for ; Thu, 1 Aug 2013 12:49:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EAFD020290 for ; Thu, 1 Aug 2013 12:49:21 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAF57201DD for ; Thu, 1 Aug 2013 12:49:19 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1V4sJf-00072E-MD; Thu, 01 Aug 2013 12:49:15 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1V4sJd-0006kG-BB; Thu, 01 Aug 2013 12:49:13 +0000 Received: from eu1sys200aog117.obsmtp.com ([207.126.144.143]) by merlin.infradead.org with smtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1V4sJZ-0006ib-Bk for linux-arm-kernel@lists.infradead.org; Thu, 01 Aug 2013 12:49:11 +0000 Received: from beta.dmz-eu.st.com ([164.129.1.35]) (using TLSv1) by eu1sys200aob117.postini.com ([207.126.147.11]) with SMTP ID DSNKUfpZKo15zYQOLnbnnJojuGlp2vjFUECX@postini.com; Thu, 01 Aug 2013 12:49:09 UTC Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 7096D136; Thu, 1 Aug 2013 12:48:36 +0000 (GMT) Received: from mail7.sgp.st.com (unknown [164.129.223.81]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 9061551FB; Thu, 1 Aug 2013 12:48:07 +0000 (GMT) Received: from localhost (king.bri.st.com [10.65.51.59]) by mail7.sgp.st.com (MOS 4.3.3-GA) with ESMTP id BIW75204 (AUTH srinivak); Thu, 1 Aug 2013 14:48:41 +0200 From: Srinivas KANDAGATLA To: linux-arm-kernel@lists.infradead.org Subject: [RFC] ARM: spear: remove spear13xx_secondary_startup from INIT section. Date: Thu, 1 Aug 2013 13:36:41 +0100 Message-Id: <1375360601-24591-1-git-send-email-srinivas.kandagatla@st.com> X-Mailer: git-send-email 1.7.6.5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130801_084909_982219_E6837824 X-CRM114-Status: GOOD ( 17.93 ) X-Spam-Score: -4.2 (----) Cc: Olof Johansson , viresh.linux@gmail.com, Russell King , Arnd Bergmann , Srinivas Kandagatla X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Srinivas Kandagatla This patch removes spear13xx_secondary_startup fromm _INIT section, there are two reasons for this removal. 1. discarding such a small code does not save much, given the RAM sizes. 2. Having this code discarded, creates corruption issue when we boot smp-kernel with nr_cpus=1 or with single cpu node in DT. Signed-off-by: Srinivas Kandagatla --- Hi, I did encounter corruption issues on STi CA9 SOCs when a SMP kernel is booted with nr_cpus=1. This boiled down to freeing the __INIT section of the secondary startup code. It looks like two other SOCs(Spear and ux500) might have same issue. Do you think this patch is valid for Spear? Thanks, srini arch/arm/mach-spear/headsmp.S | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-spear/headsmp.S b/arch/arm/mach-spear/headsmp.S index ed85473..aad3253 100644 --- a/arch/arm/mach-spear/headsmp.S +++ b/arch/arm/mach-spear/headsmp.S @@ -13,8 +13,6 @@ #include #include - __INIT - /* * spear13xx specific entry point for secondary CPUs. This provides * a "holding pen" into which all secondary cores are held until we're