| Message ID | 1376841688.11104.8.camel@t520.redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Aug 18, 2013 at 6:01 PM, Mark Salter <msalter@redhat.com> wrote: > The arm64 port doesn't provide a parport.h which causes a build failure > with some configurations: > > drivers/parport/parport_pc.c:67:25: fatal error: asm/parport.h: No such file or directory > #include <asm/parport.h> > > This patch wires in the generic parport.h for arm64. Can arm64 have a PC-style parport? If not, you're better off disabling it in drivers/parport/Kconfig. You will receive bonus points for introducing ARCH_MAY_HAVE_PC_PARPORT, cfr. ARCH_MAY_HAVE_PC_FDC. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Sun, 2013-08-18 at 22:25 +0200, Geert Uytterhoeven wrote: > On Sun, Aug 18, 2013 at 6:01 PM, Mark Salter <msalter@redhat.com> wrote: > > The arm64 port doesn't provide a parport.h which causes a build failure > > with some configurations: > > > > drivers/parport/parport_pc.c:67:25: fatal error: asm/parport.h: No such file or directory > > #include <asm/parport.h> > > > > This patch wires in the generic parport.h for arm64. > > Can arm64 have a PC-style parport? Good question. I'm not sure, but really doubt it. > > If not, you're better off disabling it in drivers/parport/Kconfig. > > You will receive bonus points for introducing ARCH_MAY_HAVE_PC_PARPORT, > cfr. ARCH_MAY_HAVE_PC_FDC. > Yes, good point. I'll work up a new patch. I can use some bonus points. --Mark
On Sun, 2013-08-18 at 22:25 +0200, Geert Uytterhoeven wrote: > On Sun, Aug 18, 2013 at 6:01 PM, Mark Salter <msalter@redhat.com> wrote: > > The arm64 port doesn't provide a parport.h which causes a build failure > > with some configurations: > > > > drivers/parport/parport_pc.c:67:25: fatal error: asm/parport.h: No such file or directory > > #include <asm/parport.h> > > > > This patch wires in the generic parport.h for arm64. > > Can arm64 have a PC-style parport? > > If not, you're better off disabling it in drivers/parport/Kconfig. > > You will receive bonus points for introducing ARCH_MAY_HAVE_PC_PARPORT, > cfr. ARCH_MAY_HAVE_PC_FDC. Okay, I have two versions of the patch. One which follows the PC_FDC patch and adds something like this to arch/<somearch>/Kconfig: config ARCH_MAY_HAVE_PC_PARPORT def_bool y The other version adds: config ARCH_MAY_HAVE_PC_PARPORT bool to arch/Kconfig (or maybe that should be in drivers/parport/Kconfig) so that the various arches just need to select it. Is there any preference for one over the other? --Mark
diff --git a/arch/arm64/include/asm/Kbuild b/arch/arm64/include/asm/Kbuild index 79a642d..487b0a2 100644 --- a/arch/arm64/include/asm/Kbuild +++ b/arch/arm64/include/asm/Kbuild @@ -25,6 +25,7 @@ generic-y += local64.h generic-y += mman.h generic-y += msgbuf.h generic-y += mutex.h +generic-y += parport.h generic-y += pci.h generic-y += percpu.h generic-y += poll.h
The arm64 port doesn't provide a parport.h which causes a build failure with some configurations: drivers/parport/parport_pc.c:67:25: fatal error: asm/parport.h: No such file or directory #include <asm/parport.h> This patch wires in the generic parport.h for arm64. Signed-off-by: Mark Salter <msalter@redhat.com> --- arch/arm64/include/asm/Kbuild | 1 + 1 file changed, 1 insertion(+)