| Message ID | 1377171448-27924-3-git-send-email-zonque@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. On 08/22/2013 03:37 PM, Daniel Mack wrote: > At least the AM33xx SoC has a control module register to configure > details such as the hardware ethernet interface mode. > I'm not sure whether all SoCs which feature the cpsw block have such a > register, so that third memory region is considered optional for now. > Signed-off-by: Daniel Mack <zonque@gmail.com> > --- > Documentation/devicetree/bindings/net/cpsw.txt | 5 ++++- > drivers/net/ethernet/ti/cpsw.c | 22 ++++++++++++++++++++++ > 2 files changed, 26 insertions(+), 1 deletion(-) > diff --git a/Documentation/devicetree/bindings/net/cpsw.txt b/Documentation/devicetree/bindings/net/cpsw.txt > index 05d660e..4e5ca54 100644 > --- a/Documentation/devicetree/bindings/net/cpsw.txt > +++ b/Documentation/devicetree/bindings/net/cpsw.txt [...] > diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c > index 63feaae..4855d8e 100644 > --- a/drivers/net/ethernet/ti/cpsw.c > +++ b/drivers/net/ethernet/ti/cpsw.c [...] > @@ -2012,6 +2013,27 @@ static int cpsw_probe(struct platform_device *pdev) > goto clean_runtime_disable_ret; > } > > + /* If the control memory region is unspecified, continue without it. > + * If it is specified, but we're unable to reserve it, bail. */ According to Documentation/CodingStyle, the networking code's preferred style of multi-line comments is this: /* Bla * bla */ > + res = platform_get_resource(pdev, IORESOURCE_MEM, 2); > + if (!res) { > + dev_err(priv->dev, "error getting control i/o resource\n"); > + goto no_gmii_sel; > + } > + if (!devm_request_mem_region(&pdev->dev, res->start, resource_size(res), > + ndev->name)) { Not dev_name(&pdev->dev)? > + dev_err(priv->dev, "failed request control i/o region\n"); > + ret = -ENXIO; Rather -EBUSY. > + goto clean_runtime_disable_ret; > + } > + priv->gmii_sel_reg = devm_ioremap(&pdev->dev, res->start, > + resource_size(res)); > + if (!priv->gmii_sel_reg) { > + dev_err(priv->dev, "unable to map control i/o region\n"); > + goto clean_runtime_disable_ret; > + } Why not use devm_ioremap_resource() instead of the above sequence? > + > +no_gmii_sel: WBR, Sergei
Hi Sergei, On 22.08.2013 20:12, Sergei Shtylyov wrote: >> @@ -2012,6 +2013,27 @@ static int cpsw_probe(struct platform_device *pdev) >> goto clean_runtime_disable_ret; >> } >> >> + /* If the control memory region is unspecified, continue without it. >> + * If it is specified, but we're unable to reserve it, bail. */ > > According to Documentation/CodingStyle, the networking code's preferred > style of multi-line comments is this: > > /* Bla > * bla > */ Ok, thanks. Will fix. >> + goto clean_runtime_disable_ret; >> + } >> + priv->gmii_sel_reg = devm_ioremap(&pdev->dev, res->start, >> + resource_size(res)); >> + if (!priv->gmii_sel_reg) { >> + dev_err(priv->dev, "unable to map control i/o region\n"); >> + goto clean_runtime_disable_ret; >> + } > > Why not use devm_ioremap_resource() instead of the above sequence? Right, that's much nicer. I'll also do that for the devm rework patch. Thank you for your review! Daniel
diff --git a/Documentation/devicetree/bindings/net/cpsw.txt b/Documentation/devicetree/bindings/net/cpsw.txt index 05d660e..4e5ca54 100644 --- a/Documentation/devicetree/bindings/net/cpsw.txt +++ b/Documentation/devicetree/bindings/net/cpsw.txt @@ -4,7 +4,10 @@ TI SoC Ethernet Switch Controller Device Tree Bindings Required properties: - compatible : Should be "ti,cpsw" - reg : physical base address and size of the cpsw - registers map + registers map. + An optional third memory region can be supplied if + the platform has a control module register to + configure phy interface details - interrupts : property with a value describing the interrupt number - interrupt-parent : The parent interrupt controller diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 63feaae..4855d8e 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -372,6 +372,7 @@ struct cpsw_priv { struct cpsw_platform_data data; struct cpsw_ss_regs __iomem *regs; struct cpsw_wr_regs __iomem *wr_regs; + u32 __iomem *gmii_sel_reg; u8 __iomem *hw_stats; struct cpsw_host_regs __iomem *host_port_regs; u32 msg_enable; @@ -2012,6 +2013,27 @@ static int cpsw_probe(struct platform_device *pdev) goto clean_runtime_disable_ret; } + /* If the control memory region is unspecified, continue without it. + * If it is specified, but we're unable to reserve it, bail. */ + res = platform_get_resource(pdev, IORESOURCE_MEM, 2); + if (!res) { + dev_err(priv->dev, "error getting control i/o resource\n"); + goto no_gmii_sel; + } + if (!devm_request_mem_region(&pdev->dev, res->start, resource_size(res), + ndev->name)) { + dev_err(priv->dev, "failed request control i/o region\n"); + ret = -ENXIO; + goto clean_runtime_disable_ret; + } + priv->gmii_sel_reg = devm_ioremap(&pdev->dev, res->start, + resource_size(res)); + if (!priv->gmii_sel_reg) { + dev_err(priv->dev, "unable to map control i/o region\n"); + goto clean_runtime_disable_ret; + } + +no_gmii_sel: memset(&dma_params, 0, sizeof(dma_params)); memset(&ale_params, 0, sizeof(ale_params));
At least the AM33xx SoC has a control module register to configure details such as the hardware ethernet interface mode. I'm not sure whether all SoCs which feature the cpsw block have such a register, so that third memory region is considered optional for now. Signed-off-by: Daniel Mack <zonque@gmail.com> --- Documentation/devicetree/bindings/net/cpsw.txt | 5 ++++- drivers/net/ethernet/ti/cpsw.c | 22 ++++++++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-)