| Message ID | 1377801154-29215-3-git-send-email-stefano.stabellini@eu.citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Aug 29, 2013 at 07:32:24PM +0100, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > CC: catalin.marinas@arm.com > CC: will.deacon@arm.com > --- > arch/arm64/include/asm/dma-mapping.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/include/asm/dma-mapping.h b/arch/arm64/include/asm/dma-mapping.h > index 8d18100..c2cb8a0 100644 > --- a/arch/arm64/include/asm/dma-mapping.h > +++ b/arch/arm64/include/asm/dma-mapping.h > @@ -25,6 +25,7 @@ > > #define ARCH_HAS_DMA_GET_REQUIRED_MASK > > +#define DMA_ERROR_CODE (~0) I wonder why this isn't more generic. It looks like most (all?) architectures define it in the same way.
On Thu, 5 Sep 2013, Catalin Marinas wrote: > On Thu, Aug 29, 2013 at 07:32:24PM +0100, Stefano Stabellini wrote: > > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > > CC: catalin.marinas@arm.com > > CC: will.deacon@arm.com > > --- > > arch/arm64/include/asm/dma-mapping.h | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm64/include/asm/dma-mapping.h b/arch/arm64/include/asm/dma-mapping.h > > index 8d18100..c2cb8a0 100644 > > --- a/arch/arm64/include/asm/dma-mapping.h > > +++ b/arch/arm64/include/asm/dma-mapping.h > > @@ -25,6 +25,7 @@ > > > > #define ARCH_HAS_DMA_GET_REQUIRED_MASK > > > > +#define DMA_ERROR_CODE (~0) > > I wonder why this isn't more generic. It looks like most (all?) > architectures define it in the same way. Actually it's defined as 0 on x86 and ia64. All the others define it as ~0.
diff --git a/arch/arm64/include/asm/dma-mapping.h b/arch/arm64/include/asm/dma-mapping.h index 8d18100..c2cb8a0 100644 --- a/arch/arm64/include/asm/dma-mapping.h +++ b/arch/arm64/include/asm/dma-mapping.h @@ -25,6 +25,7 @@ #define ARCH_HAS_DMA_GET_REQUIRED_MASK +#define DMA_ERROR_CODE (~0) extern struct dma_map_ops *dma_ops; static inline struct dma_map_ops *get_dma_ops(struct device *dev)
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> CC: catalin.marinas@arm.com CC: will.deacon@arm.com --- arch/arm64/include/asm/dma-mapping.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)