| Message ID | 1379434985-25294-1-git-send-email-dinguyen@altera.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue 2013-09-17 11:23:05, dinguyen@altera.com wrote: > From: Dinh Nguyen <dinguyen@altera.com> > > The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk". Because of this, > the SD driver was getting the incorrect clock value. This prevented the > SD driver from initializing correctly. > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com> > Cc: Mike Turquette <mturquette@linaro.org> > CC: Arnd Bergmann <arnd@arndb.de> > CC: Olof Johansson <olof@lixom.net> Reviewed-by: Pavel Machek <pavel@denx.de> Thanks! Pavel
Hi, Just wondering if I can solicit any comments for this patch? It's small, so I'm not sure if I need at least a good Ack-by and put it in my tree for a pull request, or ask to be applied to the arm-soc or Mike's clock tree? Thanks, Dinh On Tue, 2013-09-17 at 11:23 -0500, Dinh Nguyen wrote: > From: Dinh Nguyen <dinguyen@altera.com> > > The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk". Because of this, > the SD driver was getting the incorrect clock value. This prevented the > SD driver from initializing correctly. > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com> > Cc: Mike Turquette <mturquette@linaro.org> > CC: Arnd Bergmann <arnd@arndb.de> > CC: Olof Johansson <olof@lixom.net> > Cc: Pavel Machek <pavel@denx.de> > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/clk/socfpga/clk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/socfpga/clk.c b/drivers/clk/socfpga/clk.c > index 5bb848c..81dd31a 100644 > --- a/drivers/clk/socfpga/clk.c > +++ b/drivers/clk/socfpga/clk.c > @@ -49,7 +49,7 @@ > #define SOCFPGA_L4_SP_CLK "l4_sp_clk" > #define SOCFPGA_NAND_CLK "nand_clk" > #define SOCFPGA_NAND_X_CLK "nand_x_clk" > -#define SOCFPGA_MMC_CLK "mmc_clk" > +#define SOCFPGA_MMC_CLK "sdmmc_clk" > #define SOCFPGA_DB_CLK "gpio_db_clk" > > #define div_mask(width) ((1 << (width)) - 1)
Quoting Dinh Nguyen (2013-10-01 12:28:56) > Hi, > > Just wondering if I can solicit any comments for this patch? It's small, > so I'm not sure if I need at least a good Ack-by and put it in my tree > for a pull request, or ask to be applied to the arm-soc or Mike's clock > tree? I've taken this into clk-fixes for 3.12. Regards, Mike > > Thanks, > Dinh > > On Tue, 2013-09-17 at 11:23 -0500, Dinh Nguyen wrote: > > From: Dinh Nguyen <dinguyen@altera.com> > > > > The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk". Because of this, > > the SD driver was getting the incorrect clock value. This prevented the > > SD driver from initializing correctly. > > > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com> > > Cc: Mike Turquette <mturquette@linaro.org> > > CC: Arnd Bergmann <arnd@arndb.de> > > CC: Olof Johansson <olof@lixom.net> > > Cc: Pavel Machek <pavel@denx.de> > > Cc: linux-arm-kernel@lists.infradead.org > > --- > > drivers/clk/socfpga/clk.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/clk/socfpga/clk.c b/drivers/clk/socfpga/clk.c > > index 5bb848c..81dd31a 100644 > > --- a/drivers/clk/socfpga/clk.c > > +++ b/drivers/clk/socfpga/clk.c > > @@ -49,7 +49,7 @@ > > #define SOCFPGA_L4_SP_CLK "l4_sp_clk" > > #define SOCFPGA_NAND_CLK "nand_clk" > > #define SOCFPGA_NAND_X_CLK "nand_x_clk" > > -#define SOCFPGA_MMC_CLK "mmc_clk" > > +#define SOCFPGA_MMC_CLK "sdmmc_clk" > > #define SOCFPGA_DB_CLK "gpio_db_clk" > > > > #define div_mask(width) ((1 << (width)) - 1)
diff --git a/drivers/clk/socfpga/clk.c b/drivers/clk/socfpga/clk.c index 5bb848c..81dd31a 100644 --- a/drivers/clk/socfpga/clk.c +++ b/drivers/clk/socfpga/clk.c @@ -49,7 +49,7 @@ #define SOCFPGA_L4_SP_CLK "l4_sp_clk" #define SOCFPGA_NAND_CLK "nand_clk" #define SOCFPGA_NAND_X_CLK "nand_x_clk" -#define SOCFPGA_MMC_CLK "mmc_clk" +#define SOCFPGA_MMC_CLK "sdmmc_clk" #define SOCFPGA_DB_CLK "gpio_db_clk" #define div_mask(width) ((1 << (width)) - 1)