diff mbox

[1/2] arm: socfpga: Add clock for smp_twd timer

Message ID 1379435541-26338-1-git-send-email-dinguyen@altera.com (mailing list archive)
State New, archived
Headers show

Commit Message

Dinh Nguyen Sept. 17, 2013, 4:32 p.m. UTC 
From: Dinh Nguyen <dinguyen@altera.com>

Assign a clock for the twd-timer.

Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Ian Campbell <ian.campbell@citrix.com>
CC: linux-arm-kernel@lists.infradead.org
---
 arch/arm/boot/dts/socfpga.dtsi |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Dinh Nguyen Oct. 1, 2013, 7:15 p.m. UTC | #1 
Hi,

Just wondering if I can get any comments on this patchset?

Thanks,
Dinh

On Tue, 2013-09-17 at 11:32 -0500, Dinh Nguyen wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
> 
> Assign a clock for the twd-timer.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> CC: linux-arm-kernel@lists.infradead.org
> ---
>  arch/arm/boot/dts/socfpga.dtsi |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index acd6c3a..e28df94 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -480,11 +480,11 @@
>  			clock-names = "biu", "ciu";
>  		};
>  
> -		/* Local timer */
> -		timer@fffec600 {
> +		local-timer@fffec600 {
>  			compatible = "arm,cortex-a9-twd-timer";
>  			reg = <0xfffec600 0x100>;
>  			interrupts = <1 13 0xf04>;
> +			clocks = <&mpu_periph_clk>;
>  		};
>  
>  		timer0: timer0@ffc08000 {
Rob Herring Oct. 1, 2013, 7:23 p.m. UTC | #2 
On 09/17/2013 11:32 AM, dinguyen@altera.com wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
> 
> Assign a clock for the twd-timer.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> CC: linux-arm-kernel@lists.infradead.org
> ---
>  arch/arm/boot/dts/socfpga.dtsi |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index acd6c3a..e28df94 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -480,11 +480,11 @@
>  			clock-names = "biu", "ciu";
>  		};
>  
> -		/* Local timer */
> -		timer@fffec600 {
> +		local-timer@fffec600 {

timer was the right name.

>  			compatible = "arm,cortex-a9-twd-timer";
>  			reg = <0xfffec600 0x100>;
>  			interrupts = <1 13 0xf04>;
> +			clocks = <&mpu_periph_clk>;

Otherwise, this looks fine and I wouldn't expect much input on a change
that doesn't add a new binding.

Acked-by: Rob Herring <rob.herring@calxeda.com>

Rob

>  		};
>  
>  		timer0: timer0@ffc08000 {
>
Dinh Nguyen Oct. 1, 2013, 7:35 p.m. UTC | #3 
On Tue, 2013-10-01 at 14:23 -0500, Rob Herring wrote:
> On 09/17/2013 11:32 AM, dinguyen@altera.com wrote:
> > From: Dinh Nguyen <dinguyen@altera.com>
> > 
> > Assign a clock for the twd-timer.
> > 
> > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > Cc: Rob Herring <rob.herring@calxeda.com>
> > Cc: Pawel Moll <pawel.moll@arm.com>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Stephen Warren <swarren@wwwdotorg.org>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > CC: linux-arm-kernel@lists.infradead.org
> > ---
> >  arch/arm/boot/dts/socfpga.dtsi |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> > index acd6c3a..e28df94 100644
> > --- a/arch/arm/boot/dts/socfpga.dtsi
> > +++ b/arch/arm/boot/dts/socfpga.dtsi
> > @@ -480,11 +480,11 @@
> >  			clock-names = "biu", "ciu";
> >  		};
> >  
> > -		/* Local timer */
> > -		timer@fffec600 {
> > +		local-timer@fffec600 {
> 
> timer was the right name.

I'll put it back...

> 
> >  			compatible = "arm,cortex-a9-twd-timer";
> >  			reg = <0xfffec600 0x100>;
> >  			interrupts = <1 13 0xf04>;
> > +			clocks = <&mpu_periph_clk>;
> 
> Otherwise, this looks fine and I wouldn't expect much input on a change
> that doesn't add a new binding.
> 
> Acked-by: Rob Herring <rob.herring@calxeda.com>

Thanks Rob!

Dinh
> 
> Rob
> 
> >  		};
> >  
> >  		timer0: timer0@ffc08000 {
> > 
> 
>
Mike Turquette Nov. 27, 2013, 8:52 p.m. UTC | #4 
Quoting Dinh Nguyen (2013-10-01 12:35:55)
> On Tue, 2013-10-01 at 14:23 -0500, Rob Herring wrote:
> > On 09/17/2013 11:32 AM, dinguyen@altera.com wrote:
> > > From: Dinh Nguyen <dinguyen@altera.com>
> > > 
> > > Assign a clock for the twd-timer.
> > > 
> > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > > Cc: Rob Herring <rob.herring@calxeda.com>
> > > Cc: Pawel Moll <pawel.moll@arm.com>
> > > Cc: Mark Rutland <mark.rutland@arm.com>
> > > Cc: Stephen Warren <swarren@wwwdotorg.org>
> > > Cc: Ian Campbell <ian.campbell@citrix.com>
> > > CC: linux-arm-kernel@lists.infradead.org
> > > ---
> > >  arch/arm/boot/dts/socfpga.dtsi |    4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> > > index acd6c3a..e28df94 100644
> > > --- a/arch/arm/boot/dts/socfpga.dtsi
> > > +++ b/arch/arm/boot/dts/socfpga.dtsi
> > > @@ -480,11 +480,11 @@
> > >                     clock-names = "biu", "ciu";
> > >             };
> > >  
> > > -           /* Local timer */
> > > -           timer@fffec600 {
> > > +           local-timer@fffec600 {
> > 
> > timer was the right name.
> 
> I'll put it back...
> 
> > 
> > >                     compatible = "arm,cortex-a9-twd-timer";
> > >                     reg = <0xfffec600 0x100>;
> > >                     interrupts = <1 13 0xf04>;
> > > +                   clocks = <&mpu_periph_clk>;
> > 
> > Otherwise, this looks fine and I wouldn't expect much input on a change
> > that doesn't add a new binding.
> > 
> > Acked-by: Rob Herring <rob.herring@calxeda.com>
> 
> Thanks Rob!

Looks good to me too. Can you respin it with the fix for 'timer' and
I'll take it in?

Thanks,
Mike

> 
> Dinh
> > 
> > Rob
> > 
> > >             };
> > >  
> > >             timer0: timer0@ffc08000 {
> > > 
> > 
> > 
> 
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Dinh Nguyen Dec. 2, 2013, 5:10 p.m. UTC | #5 
On Wed, 2013-11-27 at 12:52 -0800, Mike Turquette wrote:
> Quoting Dinh Nguyen (2013-10-01 12:35:55)
> > On Tue, 2013-10-01 at 14:23 -0500, Rob Herring wrote:
> > > On 09/17/2013 11:32 AM, dinguyen@altera.com wrote:
> > > > From: Dinh Nguyen <dinguyen@altera.com>
> > > > 
> > > > Assign a clock for the twd-timer.
> > > > 
> > > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > > > Cc: Rob Herring <rob.herring@calxeda.com>
> > > > Cc: Pawel Moll <pawel.moll@arm.com>
> > > > Cc: Mark Rutland <mark.rutland@arm.com>
> > > > Cc: Stephen Warren <swarren@wwwdotorg.org>
> > > > Cc: Ian Campbell <ian.campbell@citrix.com>
> > > > CC: linux-arm-kernel@lists.infradead.org
> > > > ---
> > > >  arch/arm/boot/dts/socfpga.dtsi |    4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> > > > index acd6c3a..e28df94 100644
> > > > --- a/arch/arm/boot/dts/socfpga.dtsi
> > > > +++ b/arch/arm/boot/dts/socfpga.dtsi
> > > > @@ -480,11 +480,11 @@
> > > >                     clock-names = "biu", "ciu";
> > > >             };
> > > >  
> > > > -           /* Local timer */
> > > > -           timer@fffec600 {
> > > > +           local-timer@fffec600 {
> > > 
> > > timer was the right name.
> > 
> > I'll put it back...
> > 
> > > 
> > > >                     compatible = "arm,cortex-a9-twd-timer";
> > > >                     reg = <0xfffec600 0x100>;
> > > >                     interrupts = <1 13 0xf04>;
> > > > +                   clocks = <&mpu_periph_clk>;
> > > 
> > > Otherwise, this looks fine and I wouldn't expect much input on a change
> > > that doesn't add a new binding.
> > > 
> > > Acked-by: Rob Herring <rob.herring@calxeda.com>
> > 
> > Thanks Rob!
> 
> Looks good to me too. Can you respin it with the fix for 'timer' and
> I'll take it in?

This already went in through the DTS bindings tree.

Thanks,
Dinh
> 
> Thanks,
> Mike
> 
> > 
> > Dinh
> > > 
> > > Rob
> > > 
> > > >             };
> > > >  
> > > >             timer0: timer0@ffc08000 {
> > > > 
> > > 
> > > 
> > 
> > 
> > 
> > 
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
index acd6c3a..e28df94 100644
--- a/arch/arm/boot/dts/socfpga.dtsi
+++ b/arch/arm/boot/dts/socfpga.dtsi
@@ -480,11 +480,11 @@ 
 			clock-names = "biu", "ciu";
 		};
 
-		/* Local timer */
-		timer@fffec600 {
+		local-timer@fffec600 {
 			compatible = "arm,cortex-a9-twd-timer";
 			reg = <0xfffec600 0x100>;
 			interrupts = <1 13 0xf04>;
+			clocks = <&mpu_periph_clk>;
 		};
 
 		timer0: timer0@ffc08000 {