| Message ID | 1380192374-9531-2-git-send-email-p.zabel@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Sep 26, 2013 at 12:46:14PM +0200, Philipp Zabel wrote: > This patch enables the TVE which is driving the VGA connector on i.MX53-QSB. > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > --- > arch/arm/boot/dts/imx53-qsb.dts | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts > index cf1aef7..3bbedf7 100644 > --- a/arch/arm/boot/dts/imx53-qsb.dts > +++ b/arch/arm/boot/dts/imx53-qsb.dts > @@ -173,6 +173,15 @@ memgpu: /memreserve/ 0xb0000000 0x04000000; > }; > }; > > + tve { > + pinctrl_vga_sync_1: vgasync-grp1 { > + fsl,pins = < > + /* VGA_HSYNC, VSYNC with max drive strength */ > + MX53_PAD_EIM_OE__IPU_DI1_PIN7 0xe6 > + MX53_PAD_EIM_RW__IPU_DI1_PIN8 0xe6 > + >; > + }; > + }; > }; > > &uart1 { > @@ -280,8 +289,8 @@ memgpu: /memreserve/ 0xb0000000 0x04000000; > }; > > ldo8_reg: ldo8 { > - regulator-min-microvolt = <1200000>; > - regulator-max-microvolt = <3600000>; > + regulator-min-microvolt = <2750000>; > + regulator-max-microvolt = <2750000>; Why this change? Shawn > regulator-always-on; > }; > > @@ -318,6 +327,13 @@ memgpu: /memreserve/ 0xb0000000 0x04000000; > status = "okay"; > }; > > +&tve { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_vga_sync_1>; > + dac-supply = <&ldo7_reg>; > + status = "okay"; > +}; > + > &usbh1 { > vbus-supply = <®_usb_vbus>; > phy_type = "utmi"; > -- > 1.8.4.rc3 >
Am Freitag, den 27.09.2013, 09:16 +0800 schrieb Shawn Guo: > On Thu, Sep 26, 2013 at 12:46:14PM +0200, Philipp Zabel wrote: > > This patch enables the TVE which is driving the VGA connector on i.MX53-QSB. > > > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > > --- > > arch/arm/boot/dts/imx53-qsb.dts | 20 ++++++++++++++++++-- > > 1 file changed, 18 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts > > index cf1aef7..3bbedf7 100644 > > --- a/arch/arm/boot/dts/imx53-qsb.dts > > +++ b/arch/arm/boot/dts/imx53-qsb.dts > > @@ -173,6 +173,15 @@ memgpu: /memreserve/ 0xb0000000 0x04000000; > > }; > > }; > > > > + tve { > > + pinctrl_vga_sync_1: vgasync-grp1 { > > + fsl,pins = < > > + /* VGA_HSYNC, VSYNC with max drive strength */ > > + MX53_PAD_EIM_OE__IPU_DI1_PIN7 0xe6 > > + MX53_PAD_EIM_RW__IPU_DI1_PIN8 0xe6 > > + >; > > + }; > > + }; > > }; > > > > &uart1 { > > @@ -280,8 +289,8 @@ memgpu: /memreserve/ 0xb0000000 0x04000000; > > }; > > > > ldo8_reg: ldo8 { > > - regulator-min-microvolt = <1200000>; > > - regulator-max-microvolt = <3600000>; > > + regulator-min-microvolt = <2750000>; > > + regulator-max-microvolt = <2750000>; > > Why this change? According to the reference manual, the TVDAC supply should be 2.75 V. If there are no ill effects if this ldo is actually set to 3.6 V, this change could be dropped. regards Philipp
On Mon, Sep 30, 2013 at 04:40:08PM +0200, Philipp Zabel wrote: > > > @@ -280,8 +289,8 @@ memgpu: /memreserve/ 0xb0000000 0x04000000; > > > }; > > > > > > ldo8_reg: ldo8 { > > > - regulator-min-microvolt = <1200000>; > > > - regulator-max-microvolt = <3600000>; > > > + regulator-min-microvolt = <2750000>; > > > + regulator-max-microvolt = <2750000>; > > > > Why this change? > > According to the reference manual, the TVDAC supply should be 2.75 V. If > there are no ill effects if this ldo is actually set to 3.6 V, this > change could be dropped. So you either add a comment in commit log for the change or drop the change. Shawn
Hi Philipp, On Fri, Oct 4, 2013 at 10:58 PM, Shawn Guo <shawn.guo@linaro.org> wrote: > On Mon, Sep 30, 2013 at 04:40:08PM +0200, Philipp Zabel wrote: >> > > @@ -280,8 +289,8 @@ memgpu: /memreserve/ 0xb0000000 0x04000000; >> > > }; >> > > >> > > ldo8_reg: ldo8 { >> > > - regulator-min-microvolt = <1200000>; >> > > - regulator-max-microvolt = <3600000>; >> > > + regulator-min-microvolt = <2750000>; >> > > + regulator-max-microvolt = <2750000>; >> > >> > Why this change? >> >> According to the reference manual, the TVDAC supply should be 2.75 V. If >> there are no ill effects if this ldo is actually set to 3.6 V, this >> change could be dropped. > > So you either add a comment in commit log for the change or drop the > change. Do you plan to resubmit this patch? Regards, Fabio Estevam
diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts index cf1aef7..3bbedf7 100644 --- a/arch/arm/boot/dts/imx53-qsb.dts +++ b/arch/arm/boot/dts/imx53-qsb.dts @@ -173,6 +173,15 @@ memgpu: /memreserve/ 0xb0000000 0x04000000; }; }; + tve { + pinctrl_vga_sync_1: vgasync-grp1 { + fsl,pins = < + /* VGA_HSYNC, VSYNC with max drive strength */ + MX53_PAD_EIM_OE__IPU_DI1_PIN7 0xe6 + MX53_PAD_EIM_RW__IPU_DI1_PIN8 0xe6 + >; + }; + }; }; &uart1 { @@ -280,8 +289,8 @@ memgpu: /memreserve/ 0xb0000000 0x04000000; }; ldo8_reg: ldo8 { - regulator-min-microvolt = <1200000>; - regulator-max-microvolt = <3600000>; + regulator-min-microvolt = <2750000>; + regulator-max-microvolt = <2750000>; regulator-always-on; }; @@ -318,6 +327,13 @@ memgpu: /memreserve/ 0xb0000000 0x04000000; status = "okay"; }; +&tve { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_vga_sync_1>; + dac-supply = <&ldo7_reg>; + status = "okay"; +}; + &usbh1 { vbus-supply = <®_usb_vbus>; phy_type = "utmi";
This patch enables the TVE which is driving the VGA connector on i.MX53-QSB. Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> --- arch/arm/boot/dts/imx53-qsb.dts | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-)