| Message ID | 1380194038-5148-1-git-send-email-marex@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 26/09/13 14:13, Marek Vasut wrote: > Add missing break into the restore function. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Fabio Estevam <fabio.estevam@freescale.com> > Cc: Shawn Guo <shawn.guo@linaro.org> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > --- > drivers/video/mxsfb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c > index d250ed0..27197a8 100644 > --- a/drivers/video/mxsfb.c > +++ b/drivers/video/mxsfb.c > @@ -620,6 +620,7 @@ static int mxsfb_restore_mode(struct mxsfb_info *host) > break; > case 3: > bits_per_pixel = 32; > + break; > case 1: > default: > return -EINVAL; > Thanks, queued for 3.12 fixes. Tomi
Hi Tomi, > On 26/09/13 14:13, Marek Vasut wrote: > > Add missing break into the restore function. > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > Cc: Fabio Estevam <fabio.estevam@freescale.com> > > Cc: Shawn Guo <shawn.guo@linaro.org> > > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > > --- > > > > drivers/video/mxsfb.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c > > index d250ed0..27197a8 100644 > > --- a/drivers/video/mxsfb.c > > +++ b/drivers/video/mxsfb.c > > @@ -620,6 +620,7 @@ static int mxsfb_restore_mode(struct mxsfb_info > > *host) > > > > break; > > > > case 3: > > bits_per_pixel = 32; > > > > + break; > > > > case 1: > > > > default: > > return -EINVAL; > > Thanks, queued for 3.12 fixes. Can you please also queue this for stable 3.10? It's broken there too. Thanks! Best regards, Marek Vasut
On 15:04 Thu 26 Sep , Marek Vasut wrote: > Hi Tomi, > > > On 26/09/13 14:13, Marek Vasut wrote: > > > Add missing break into the restore function. > > > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > > Cc: Fabio Estevam <fabio.estevam@freescale.com> > > > Cc: Shawn Guo <shawn.guo@linaro.org> > > > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > > > --- > > > > > > drivers/video/mxsfb.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c > > > index d250ed0..27197a8 100644 > > > --- a/drivers/video/mxsfb.c > > > +++ b/drivers/video/mxsfb.c > > > @@ -620,6 +620,7 @@ static int mxsfb_restore_mode(struct mxsfb_info > > > *host) > > > > > > break; > > > > > > case 3: > > > bits_per_pixel = 32; > > > > > > + break; > > > > > > case 1: > > > > > > default: > > > return -EINVAL; > > > > Thanks, queued for 3.12 fixes. > > Can you please also queue this for stable 3.10? It's broken there too. this you have to do it by yourself by cc stable Greg will take it not us Best Regards, J. > > Thanks! > > Best regards, > Marek Vasut > -- > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index d250ed0..27197a8 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -620,6 +620,7 @@ static int mxsfb_restore_mode(struct mxsfb_info *host) break; case 3: bits_per_pixel = 32; + break; case 1: default: return -EINVAL;
Add missing break into the restore function. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Fabio Estevam <fabio.estevam@freescale.com> Cc: Shawn Guo <shawn.guo@linaro.org> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> --- drivers/video/mxsfb.c | 1 + 1 file changed, 1 insertion(+)