| Message ID | 1380194306-5243-3-git-send-email-marex@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, Marek Vasut writes: > Enable the DCP by default on both i.MX23 and i.MX28. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: David S. Miller <davem@davemloft.net> > Cc: Fabio Estevam <fabio.estevam@freescale.com> > Cc: Shawn Guo <shawn.guo@linaro.org> > To: linux-crypto@vger.kernel.org > --- > arch/arm/boot/dts/imx23.dtsi | 4 +++- > arch/arm/boot/dts/imx28.dtsi | 5 +++-- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi > index 87faa6e..0630a9a 100644 > --- a/arch/arm/boot/dts/imx23.dtsi > +++ b/arch/arm/boot/dts/imx23.dtsi > @@ -337,8 +337,10 @@ > }; > > dcp@80028000 { > + compatible = "fsl,mxs-dcp"; > reg = <0x80028000 0x2000>; > - status = "disabled"; > + interrupts = <53 54>; > + status = "okay"; > }; AFAICT the policy seems to be that nodes, that are always enabled don't get a 'status' property at all. > pxp@8002a000 { > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi > index 918d419..8b5ad60 100644 > --- a/arch/arm/boot/dts/imx28.dtsi > +++ b/arch/arm/boot/dts/imx28.dtsi > @@ -782,9 +782,10 @@ > }; > > dcp: dcp@80028000 { > + compatible = "fsl,mxs-dcp"; > reg = <0x80028000 0x2000>; > - interrupts = <52 53 54>; > - compatible = "fsl-dcp"; > What about drivers/crypto/dcp.c that is currently using this property? Lothar Waßmann
Dear Lothar Waßmann, > Hi, > > Marek Vasut writes: > > Enable the DCP by default on both i.MX23 and i.MX28. > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > Cc: Herbert Xu <herbert@gondor.apana.org.au> > > Cc: David S. Miller <davem@davemloft.net> > > Cc: Fabio Estevam <fabio.estevam@freescale.com> > > Cc: Shawn Guo <shawn.guo@linaro.org> > > To: linux-crypto@vger.kernel.org > > --- > > > > arch/arm/boot/dts/imx23.dtsi | 4 +++- > > arch/arm/boot/dts/imx28.dtsi | 5 +++-- > > 2 files changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi > > index 87faa6e..0630a9a 100644 > > --- a/arch/arm/boot/dts/imx23.dtsi > > +++ b/arch/arm/boot/dts/imx23.dtsi > > @@ -337,8 +337,10 @@ > > > > }; > > > > dcp@80028000 { > > > > + compatible = "fsl,mxs-dcp"; > > > > reg = <0x80028000 0x2000>; > > > > - status = "disabled"; > > + interrupts = <53 54>; > > + status = "okay"; > > > > }; > > AFAICT the policy seems to be that nodes, that are always enabled > don't get a 'status' property at all. This is new to me, thanks for letting me know! As for the current DCP, please see my reply to Fabio in this thread. Best regards, Marek Vasut
Dear Lothar Waßmann, > Hi, > > Marek Vasut writes: > > Enable the DCP by default on both i.MX23 and i.MX28. > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > Cc: Herbert Xu <herbert@gondor.apana.org.au> > > Cc: David S. Miller <davem@davemloft.net> > > Cc: Fabio Estevam <fabio.estevam@freescale.com> > > Cc: Shawn Guo <shawn.guo@linaro.org> > > To: linux-crypto@vger.kernel.org > > --- > > > > arch/arm/boot/dts/imx23.dtsi | 4 +++- > > arch/arm/boot/dts/imx28.dtsi | 5 +++-- > > 2 files changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi > > index 87faa6e..0630a9a 100644 > > --- a/arch/arm/boot/dts/imx23.dtsi > > +++ b/arch/arm/boot/dts/imx23.dtsi > > @@ -337,8 +337,10 @@ > > > > }; > > > > dcp@80028000 { > > > > + compatible = "fsl,mxs-dcp"; > > > > reg = <0x80028000 0x2000>; > > > > - status = "disabled"; > > + interrupts = <53 54>; > > + status = "okay"; > > > > }; > > AFAICT the policy seems to be that nodes, that are always enabled > don't get a 'status' property at all. Is this documented somewhere ? Best regards, Marek Vasut
diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi index 87faa6e..0630a9a 100644 --- a/arch/arm/boot/dts/imx23.dtsi +++ b/arch/arm/boot/dts/imx23.dtsi @@ -337,8 +337,10 @@ }; dcp@80028000 { + compatible = "fsl,mxs-dcp"; reg = <0x80028000 0x2000>; - status = "disabled"; + interrupts = <53 54>; + status = "okay"; }; pxp@8002a000 { diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 918d419..8b5ad60 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -782,9 +782,10 @@ }; dcp: dcp@80028000 { + compatible = "fsl,mxs-dcp"; reg = <0x80028000 0x2000>; - interrupts = <52 53 54>; - compatible = "fsl-dcp"; + interrupts = <53 54>; + status = "okay"; }; pxp: pxp@8002a000 {
Enable the DCP by default on both i.MX23 and i.MX28. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: David S. Miller <davem@davemloft.net> Cc: Fabio Estevam <fabio.estevam@freescale.com> Cc: Shawn Guo <shawn.guo@linaro.org> To: linux-crypto@vger.kernel.org --- arch/arm/boot/dts/imx23.dtsi | 4 +++- arch/arm/boot/dts/imx28.dtsi | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-)