diff mbox

video: mxsfb: Add missing break

Message ID 1380601350-6665-1-git-send-email-marex@denx.de (mailing list archive)
State New, archived
Headers show

Commit Message

Marek Vasut Oct. 1, 2013, 4:22 a.m. UTC
Add missing break into the restore function.

Upstream commit: 6d0bb818041a02be682abadb3ba35ff608f7d60a

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: stable@vger.kernel.org

---
 drivers/video/mxsfb.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Luis Henriques Oct. 3, 2013, 4:15 p.m. UTC | #1
Marek Vasut <marex@denx.de> writes:

> Add missing break into the restore function.
>
> Upstream commit: 6d0bb818041a02be682abadb3ba35ff608f7d60a
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: stable@vger.kernel.org
>
> ---
>  drivers/video/mxsfb.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> index 21223d4..75c5b4e 100644
> --- a/drivers/video/mxsfb.c
> +++ b/drivers/video/mxsfb.c
> @@ -647,6 +647,7 @@ static int mxsfb_restore_mode(struct mxsfb_info *host)
>  		break;
>  	case 3:
>  		bits_per_pixel = 32;
> +		break;
>  	case 1:
>  	default:
>  		return -EINVAL;

Thanks, I believe this fix is applicable to all the stable kernels.
I'm queuing it for the 3.5 kernel.

Cheers,
Marek Vasut Oct. 3, 2013, 4:26 p.m. UTC | #2
Dear Luis Henriques,

> Marek Vasut <marex@denx.de> writes:
> > Add missing break into the restore function.
> > 
> > Upstream commit: 6d0bb818041a02be682abadb3ba35ff608f7d60a
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: Shawn Guo <shawn.guo@linaro.org>
> > Cc: stable@vger.kernel.org
> > 
> > ---
> > 
> >  drivers/video/mxsfb.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> > index 21223d4..75c5b4e 100644
> > --- a/drivers/video/mxsfb.c
> > +++ b/drivers/video/mxsfb.c
> > @@ -647,6 +647,7 @@ static int mxsfb_restore_mode(struct mxsfb_info
> > *host)
> > 
> >  		break;
> >  	
> >  	case 3:
> >  		bits_per_pixel = 32;
> > 
> > +		break;
> > 
> >  	case 1:
> >  	
> >  	default:
> >  		return -EINVAL;
> 
> Thanks, I believe this fix is applicable to all the stable kernels.
> I'm queuing it for the 3.5 kernel.

Thanks!

btw. it'd be nice if you could push the kernel.ubuntu.com admins to fix their 
git server ( https://bugs.launchpad.net/ubuntu/+source/git/+bug/1228148 ) ;-)

Best regards,
Marek Vasut
diff mbox

Patch

diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 21223d4..75c5b4e 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -647,6 +647,7 @@  static int mxsfb_restore_mode(struct mxsfb_info *host)
 		break;
 	case 3:
 		bits_per_pixel = 32;
+		break;
 	case 1:
 	default:
 		return -EINVAL;