| Message ID | 1380794702-6191-1-git-send-email-simon.guinot@sequanux.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Simon, On Thu, Oct 03, 2013 at 12:05:02PM +0200, Simon Guinot wrote: > This patch fixes the tclk frequency array for the Armada-370 SoC. > This bug has been introduced by commit 6b72333d > ("clk: mvebu: add Armada 370 SoC-centric clock init"). > > A wrong tclk frequency affects the following drivers: mvsdio, mvneta, > i2c-mv64xxx and mvebu-devbus. This list may be incomplete. > > About the mvneta Ethernet driver, note that the tclk frequency is used > to compute the Rx time coalescence. Then, this bug harms the coalescence > configuration and also degrades the networking performances with the > default values. > > Signed-off-by: Simon Guinot <simon.guinot@sequanux.org> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: stable@vger.kernel.org > --- > drivers/clk/mvebu/armada-370.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Much better, thanks! Acked-by: Jason Cooper <jason@lakedaemon.net> This can be applied to v3.11 onwards. thx, Jason.
On Thu, Oct 03, 2013 at 08:23:07AM -0400, Jason Cooper wrote: > Simon, > > On Thu, Oct 03, 2013 at 12:05:02PM +0200, Simon Guinot wrote: > > This patch fixes the tclk frequency array for the Armada-370 SoC. > > This bug has been introduced by commit 6b72333d > > ("clk: mvebu: add Armada 370 SoC-centric clock init"). > > > > A wrong tclk frequency affects the following drivers: mvsdio, mvneta, > > i2c-mv64xxx and mvebu-devbus. This list may be incomplete. > > > > About the mvneta Ethernet driver, note that the tclk frequency is used > > to compute the Rx time coalescence. Then, this bug harms the coalescence > > configuration and also degrades the networking performances with the > > default values. > > > > Signed-off-by: Simon Guinot <simon.guinot@sequanux.org> > > Cc: Andrew Lunn <andrew@lunn.ch> > > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > > Cc: Jason Cooper <jason@lakedaemon.net> > > Cc: stable@vger.kernel.org > > --- > > drivers/clk/mvebu/armada-370.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Much better, thanks! > > Acked-by: Jason Cooper <jason@lakedaemon.net> > > This can be applied to v3.11 onwards. Hi Mike, Please consider applying this patch. Thanks, Simon
On Wed, Oct 09, 2013 at 09:36:33AM +0200, Simon Guinot wrote: > On Thu, Oct 03, 2013 at 08:23:07AM -0400, Jason Cooper wrote: > > Simon, > > > > On Thu, Oct 03, 2013 at 12:05:02PM +0200, Simon Guinot wrote: > > > This patch fixes the tclk frequency array for the Armada-370 SoC. > > > This bug has been introduced by commit 6b72333d > > > ("clk: mvebu: add Armada 370 SoC-centric clock init"). > > > > > > A wrong tclk frequency affects the following drivers: mvsdio, mvneta, > > > i2c-mv64xxx and mvebu-devbus. This list may be incomplete. > > > > > > About the mvneta Ethernet driver, note that the tclk frequency is used > > > to compute the Rx time coalescence. Then, this bug harms the coalescence > > > configuration and also degrades the networking performances with the > > > default values. > > > > > > Signed-off-by: Simon Guinot <simon.guinot@sequanux.org> > > > Cc: Andrew Lunn <andrew@lunn.ch> > > > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > > > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > > > Cc: Jason Cooper <jason@lakedaemon.net> > > > Cc: stable@vger.kernel.org > > > --- > > > drivers/clk/mvebu/armada-370.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Much better, thanks! > > > > Acked-by: Jason Cooper <jason@lakedaemon.net> > > > > This can be applied to v3.11 onwards. > > Hi Mike, > > Please consider applying this patch. Ping ?
On 14/10/2013 10:53, Simon Guinot wrote: > On Wed, Oct 09, 2013 at 09:36:33AM +0200, Simon Guinot wrote: >> On Thu, Oct 03, 2013 at 08:23:07AM -0400, Jason Cooper wrote: >>> Simon, >>> >>> On Thu, Oct 03, 2013 at 12:05:02PM +0200, Simon Guinot wrote: >>>> This patch fixes the tclk frequency array for the Armada-370 SoC. >>>> This bug has been introduced by commit 6b72333d >>>> ("clk: mvebu: add Armada 370 SoC-centric clock init"). >>>> >>>> A wrong tclk frequency affects the following drivers: mvsdio, mvneta, >>>> i2c-mv64xxx and mvebu-devbus. This list may be incomplete. >>>> >>>> About the mvneta Ethernet driver, note that the tclk frequency is used >>>> to compute the Rx time coalescence. Then, this bug harms the coalescence >>>> configuration and also degrades the networking performances with the >>>> default values. >>>> >>>> Signed-off-by: Simon Guinot <simon.guinot@sequanux.org> >>>> Cc: Andrew Lunn <andrew@lunn.ch> >>>> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> >>>> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> >>>> Cc: Jason Cooper <jason@lakedaemon.net> >>>> Cc: stable@vger.kernel.org >>>> --- >>>> drivers/clk/mvebu/armada-370.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> Much better, thanks! >>> >>> Acked-by: Jason Cooper <jason@lakedaemon.net> >>> >>> This can be applied to v3.11 onwards. >> >> Hi Mike, >> >> Please consider applying this patch. > > Ping ? Mike, this bug could be very annoying. We had some issue recently with i2c, and I am pretty sure it was caused by this wrong rate. So it would be nice to have this fix in 3.12, and then on the stable branches. Of course you can also add my: Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com> Thanks, > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
On Mon, Oct 14, 2013 at 11:55:01AM +0200, Gregory CLEMENT wrote: > On 14/10/2013 10:53, Simon Guinot wrote: > > On Wed, Oct 09, 2013 at 09:36:33AM +0200, Simon Guinot wrote: > >> On Thu, Oct 03, 2013 at 08:23:07AM -0400, Jason Cooper wrote: > >>> Simon, > >>> > >>> On Thu, Oct 03, 2013 at 12:05:02PM +0200, Simon Guinot wrote: > >>>> This patch fixes the tclk frequency array for the Armada-370 SoC. > >>>> This bug has been introduced by commit 6b72333d > >>>> ("clk: mvebu: add Armada 370 SoC-centric clock init"). > >>>> > >>>> A wrong tclk frequency affects the following drivers: mvsdio, mvneta, > >>>> i2c-mv64xxx and mvebu-devbus. This list may be incomplete. > >>>> > >>>> About the mvneta Ethernet driver, note that the tclk frequency is used > >>>> to compute the Rx time coalescence. Then, this bug harms the coalescence > >>>> configuration and also degrades the networking performances with the > >>>> default values. > >>>> > >>>> Signed-off-by: Simon Guinot <simon.guinot@sequanux.org> > >>>> Cc: Andrew Lunn <andrew@lunn.ch> > >>>> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > >>>> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > >>>> Cc: Jason Cooper <jason@lakedaemon.net> > >>>> Cc: stable@vger.kernel.org > >>>> --- > >>>> drivers/clk/mvebu/armada-370.c | 4 ++-- > >>>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >>> Much better, thanks! > >>> > >>> Acked-by: Jason Cooper <jason@lakedaemon.net> > >>> > >>> This can be applied to v3.11 onwards. > >> > >> Hi Mike, > >> > >> Please consider applying this patch. > > > > Ping ? > > Mike, > > this bug could be very annoying. We had some issue recently with i2c, > and I am pretty sure it was caused by this wrong rate. > So it would be nice to have this fix in 3.12, and then on the stable > branches. > > Of course you can also add my: > Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com> Well, it seems that Mike is not available this days. Given that this patch is a trivial one-liner, maybe that someone else can pick it ? Thanks in advance. Simon
Mike, I going to go ahead a take this through my tree. I'll hold it off until my last pull request for the merge window (I'm guessing about a week). If you object, just let me know before then and I'll drop it. On Thu, Oct 03, 2013 at 12:05:02PM +0200, Simon Guinot wrote: > This patch fixes the tclk frequency array for the Armada-370 SoC. > This bug has been introduced by commit 6b72333d > ("clk: mvebu: add Armada 370 SoC-centric clock init"). > > A wrong tclk frequency affects the following drivers: mvsdio, mvneta, > i2c-mv64xxx and mvebu-devbus. This list may be incomplete. > > About the mvneta Ethernet driver, note that the tclk frequency is used > to compute the Rx time coalescence. Then, this bug harms the coalescence > configuration and also degrades the networking performances with the > default values. > > Signed-off-by: Simon Guinot <simon.guinot@sequanux.org> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: stable@vger.kernel.org > --- > drivers/clk/mvebu/armada-370.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to mvebu/drivers for v3.13 and flagged for stable going back to v3.11. Also added Gregory's Ack. thx, Jason.
Quoting Jason Cooper (2013-10-17 05:31:59) > Mike, > > I going to go ahead a take this through my tree. I'll hold it off until > my last pull request for the merge window (I'm guessing about a week). > If you object, just let me know before then and I'll drop it. > > > On Thu, Oct 03, 2013 at 12:05:02PM +0200, Simon Guinot wrote: > > This patch fixes the tclk frequency array for the Armada-370 SoC. > > This bug has been introduced by commit 6b72333d > > ("clk: mvebu: add Armada 370 SoC-centric clock init"). > > > > A wrong tclk frequency affects the following drivers: mvsdio, mvneta, > > i2c-mv64xxx and mvebu-devbus. This list may be incomplete. > > > > About the mvneta Ethernet driver, note that the tclk frequency is used > > to compute the Rx time coalescence. Then, this bug harms the coalescence > > configuration and also degrades the networking performances with the > > default values. > > > > Signed-off-by: Simon Guinot <simon.guinot@sequanux.org> > > Cc: Andrew Lunn <andrew@lunn.ch> > > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > > Cc: Jason Cooper <jason@lakedaemon.net> > > Cc: stable@vger.kernel.org > > --- > > drivers/clk/mvebu/armada-370.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Applied to mvebu/drivers for v3.13 and flagged for stable going back to > v3.11. Also added Gregory's Ack. Worked it out with Jason face to face. I've added to clk-fixes with ACKs and will send out this week. Regards, Mike > > thx, > > Jason.
On Wed, Oct 23, 2013 at 03:45:34AM -0700, Mike Turquette wrote: > Quoting Jason Cooper (2013-10-17 05:31:59) > > Mike, > > > > I going to go ahead a take this through my tree. I'll hold it off until > > my last pull request for the merge window (I'm guessing about a week). > > If you object, just let me know before then and I'll drop it. > > > > > > On Thu, Oct 03, 2013 at 12:05:02PM +0200, Simon Guinot wrote: > > > This patch fixes the tclk frequency array for the Armada-370 SoC. > > > This bug has been introduced by commit 6b72333d > > > ("clk: mvebu: add Armada 370 SoC-centric clock init"). > > > > > > A wrong tclk frequency affects the following drivers: mvsdio, mvneta, > > > i2c-mv64xxx and mvebu-devbus. This list may be incomplete. > > > > > > About the mvneta Ethernet driver, note that the tclk frequency is used > > > to compute the Rx time coalescence. Then, this bug harms the coalescence > > > configuration and also degrades the networking performances with the > > > default values. > > > > > > Signed-off-by: Simon Guinot <simon.guinot@sequanux.org> > > > Cc: Andrew Lunn <andrew@lunn.ch> > > > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > > > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > > > Cc: Jason Cooper <jason@lakedaemon.net> > > > Cc: stable@vger.kernel.org > > > --- > > > drivers/clk/mvebu/armada-370.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Applied to mvebu/drivers for v3.13 and flagged for stable going back to > > v3.11. Also added Gregory's Ack. > > Worked it out with Jason face to face. I've added to clk-fixes with ACKs > and will send out this week. Hi Mike, Please, don't forget to send out :) Thanks, Simon
diff --git a/drivers/clk/mvebu/armada-370.c b/drivers/clk/mvebu/armada-370.c index fc777bd..81a202d 100644 --- a/drivers/clk/mvebu/armada-370.c +++ b/drivers/clk/mvebu/armada-370.c @@ -39,8 +39,8 @@ static const struct coreclk_ratio a370_coreclk_ratios[] __initconst = { }; static const u32 a370_tclk_freqs[] __initconst = { - 16600000, - 20000000, + 166000000, + 200000000, }; static u32 __init a370_get_tclk_freq(void __iomem *sar)
This patch fixes the tclk frequency array for the Armada-370 SoC. This bug has been introduced by commit 6b72333d ("clk: mvebu: add Armada 370 SoC-centric clock init"). A wrong tclk frequency affects the following drivers: mvsdio, mvneta, i2c-mv64xxx and mvebu-devbus. This list may be incomplete. About the mvneta Ethernet driver, note that the tclk frequency is used to compute the Rx time coalescence. Then, this bug harms the coalescence configuration and also degrades the networking performances with the default values. Signed-off-by: Simon Guinot <simon.guinot@sequanux.org> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> Cc: Jason Cooper <jason@lakedaemon.net> Cc: stable@vger.kernel.org --- drivers/clk/mvebu/armada-370.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)