From patchwork Thu Oct 17 12:45:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 3060751 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5E1319F2B6 for ; Thu, 17 Oct 2013 12:46:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CB2F92039F for ; Thu, 17 Oct 2013 12:46:31 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 777B820383 for ; Thu, 17 Oct 2013 12:46:30 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VWmyA-0000N6-6Q; Thu, 17 Oct 2013 12:46:26 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VWmy7-0003gX-Ki; Thu, 17 Oct 2013 12:46:23 +0000 Received: from mailout3.w1.samsung.com ([210.118.77.13]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VWmy4-0003fN-LQ for linux-arm-kernel@lists.infradead.org; Thu, 17 Oct 2013 12:46:21 +0000 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MUT00G89CR73LB0@mailout3.w1.samsung.com> for linux-arm-kernel@lists.infradead.org; Thu, 17 Oct 2013 13:45:53 +0100 (BST) X-AuditID: cbfec7f4-b7f0a6d000007b1b-6c-525fdc01e7de Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 75.BF.31515.10CDF525; Thu, 17 Oct 2013 13:45:53 +0100 (BST) Received: from AMDC1943.digital.local ([106.116.151.171]) by eusync1.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0MUT001D4CSEHWA0@eusync1.samsung.com>; Thu, 17 Oct 2013 13:45:53 +0100 (BST) From: Krzysztof Kozlowski To: Ben Dooks , Kukjin Kim , Mark Brown Subject: [PATCH] spi: spi-s3c64xx: Add missing pm_runtime_put on setup fail Date: Thu, 17 Oct 2013 14:45:41 +0200 Message-id: <1382013941-861-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGJMWRmVeSWpSXmKPExsVy+t/xy7qMd+KDDGaf07WYtO4Ak8XUh0/Y LF6/MLToXXCVzWLT42usFpd3zWGzmHF+H5NF48eb7BaH37SzOnB6/F31gtlj06pONo/NS+o9 +rasYvT4vEkugDWKyyYlNSezLLVI3y6BK+PE2bNMBWtYK7b9m8PUwLiLpYuRk0NCwETiyc6v 7BC2mMSFe+vZuhi5OIQEljJKfD6/jBHC6WOS2PlrAlgHm4CxxOblS9hAbBGBLInb/7YwgxQx CzxjlPh78DErSEJYwFtiwc0/zCA2i4CqxIq2bjCbV8BVYuLDf0BTOYDWKUjMmWQzgZF7ASPD KkbR1NLkguKk9FxDveLE3OLSvHS95PzcTYyQsPmyg3HxMatDjAIcjEo8vDOWxwUJsSaWFVfm HmKU4GBWEuHdsj0+SIg3JbGyKrUoP76oNCe1+BAjEwenVAOj+sLE6Y7xMnyH18Xw9rOKP5y7 eHtmc9TOB20S/Y/msx4N2n2J5+W/2yb+cR4+mz0y2xsmG5rrKsbrXX3eN/3tz2VqR0Vrtxuq 9UycIu1VvujSGtkFof+emhw8Gtbz/PF7xqBVt8/9MitynbFtj8P60hcND8U8DDoitwjw3vSJ m31p+ao5/xr9lFiKMxINtZiLihMBcCF8NPkBAAA= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131017_084620_787393_AEE76E44 X-CRM114-Status: UNSURE ( 7.63 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -7.3 (-------) Cc: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP pm_runtime_put() wasn't called if clock rate could not be set up in s3c64xx_spi_setup() leading to invalid count of device pm_runtime usage. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Sylwester Nawrocki --- drivers/spi/spi-s3c64xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index a80376d..0ddaff2 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1121,6 +1121,7 @@ static int s3c64xx_spi_setup(struct spi_device *spi) return 0; setup_exit: + pm_runtime_put(&sdd->pdev->dev); /* setup() returns with device de-selected */ disable_cs(sdd, spi);