| Message ID | 1382421528-17897-11-git-send-email-peter.chen@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Oct 22, 2013 at 01:58:44PM +0800, Peter Chen wrote: > This property is used to disconnect line between USB PHY and > USB controller. > > Signed-off-by: Peter Chen <peter.chen@freescale.com> > --- > Documentation/devicetree/bindings/usb/mxs-phy.txt | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentation/devicetree/bindings/usb/mxs-phy.txt > index 5837963..356c9b6 100644 > --- a/Documentation/devicetree/bindings/usb/mxs-phy.txt > +++ b/Documentation/devicetree/bindings/usb/mxs-phy.txt > @@ -9,6 +9,9 @@ mxs PHY verions. > - reg: Should contain registers location and length > - interrupts: Should contain phy interrupt > - fsl,anatop: phandle for anatop register, it is only for mx6 SoC serial > +- disconnect-line-without-vbus: needs to disconnect > +connection between USB PHY and controller, it can avoid > +unexpected wakeup interrupt when the PHY is out of power If it's a mxs-phy specific property, we may need to have vendor prefix 'fsl,' for it. I see you set the property in imx6qdl.dtsi. Is it true that we should always set it for imx6q/dl? If yes, why cannot we have the driver to force it for imx6q type of phy. If no, where do we need to set it and where not? Shawn > > Example: > usbphy1: usbphy@020c9000 { > @@ -16,4 +19,5 @@ usbphy1: usbphy@020c9000 { > reg = <0x020c9000 0x1000>; > interrupts = <0 44 0x04>; > fsl,anatop = <&anatop>; > + disconnect-line-without-vbus; > }; > -- > 1.7.1 > >
On Wed, Oct 23, 2013 at 02:31:56PM +0800, Shawn Guo wrote: > On Tue, Oct 22, 2013 at 01:58:44PM +0800, Peter Chen wrote: > > This property is used to disconnect line between USB PHY and > > USB controller. > > > > Signed-off-by: Peter Chen <peter.chen@freescale.com> > > --- > > Documentation/devicetree/bindings/usb/mxs-phy.txt | 4 ++++ > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentation/devicetree/bindings/usb/mxs-phy.txt > > index 5837963..356c9b6 100644 > > --- a/Documentation/devicetree/bindings/usb/mxs-phy.txt > > +++ b/Documentation/devicetree/bindings/usb/mxs-phy.txt > > @@ -9,6 +9,9 @@ mxs PHY verions. > > - reg: Should contain registers location and length > > - interrupts: Should contain phy interrupt > > - fsl,anatop: phandle for anatop register, it is only for mx6 SoC serial > > +- disconnect-line-without-vbus: needs to disconnect > > +connection between USB PHY and controller, it can avoid > > +unexpected wakeup interrupt when the PHY is out of power > > If it's a mxs-phy specific property, we may need to have vendor prefix > 'fsl,' for it. It is mx6 version mxs-phy specific, I will add prefix "imx6" > > I see you set the property in imx6qdl.dtsi. Is it true that we should > always set it for imx6q/dl? If yes, why cannot we have the driver to > force it for imx6q type of phy. If no, where do we need to set it and > where not? > Yes, it is needed for current imx6dq, imx6dl, and imx6sl SoC.
On Wed, Oct 23, 2013 at 02:31:56PM +0800, Shawn Guo wrote: > On Tue, Oct 22, 2013 at 01:58:44PM +0800, Peter Chen wrote: > > This property is used to disconnect line between USB PHY and > > USB controller. > > > > Signed-off-by: Peter Chen <peter.chen@freescale.com> > > --- > > Documentation/devicetree/bindings/usb/mxs-phy.txt | 4 ++++ > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentation/devicetree/bindings/usb/mxs-phy.txt > > index 5837963..356c9b6 100644 > > --- a/Documentation/devicetree/bindings/usb/mxs-phy.txt > > +++ b/Documentation/devicetree/bindings/usb/mxs-phy.txt > > @@ -9,6 +9,9 @@ mxs PHY verions. > > - reg: Should contain registers location and length > > - interrupts: Should contain phy interrupt > > - fsl,anatop: phandle for anatop register, it is only for mx6 SoC serial > > +- disconnect-line-without-vbus: needs to disconnect > > +connection between USB PHY and controller, it can avoid > > +unexpected wakeup interrupt when the PHY is out of power > > If it's a mxs-phy specific property, we may need to have vendor prefix > 'fsl,' for it. > > I see you set the property in imx6qdl.dtsi. Is it true that we should > always set it for imx6q/dl? If yes, why cannot we have the driver to > force it for imx6q type of phy. If no, where do we need to set it and > where not? > One more thing: it is a SoC feature, so I can delete it from DT, and using compatible string (or of_device_id.data) to judge if it is needed at driver, do you think so?
On Wed, Oct 23, 2013 at 03:08:25PM +0800, Peter Chen wrote: > One more thing: it is a SoC feature, so I can delete it from DT, and > using compatible string (or of_device_id.data) to judge if it is needed > at driver, do you think so? That's exactly my point - it's not a thing belonging to device tree. Shawn
diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentation/devicetree/bindings/usb/mxs-phy.txt index 5837963..356c9b6 100644 --- a/Documentation/devicetree/bindings/usb/mxs-phy.txt +++ b/Documentation/devicetree/bindings/usb/mxs-phy.txt @@ -9,6 +9,9 @@ mxs PHY verions. - reg: Should contain registers location and length - interrupts: Should contain phy interrupt - fsl,anatop: phandle for anatop register, it is only for mx6 SoC serial +- disconnect-line-without-vbus: needs to disconnect +connection between USB PHY and controller, it can avoid +unexpected wakeup interrupt when the PHY is out of power Example: usbphy1: usbphy@020c9000 { @@ -16,4 +19,5 @@ usbphy1: usbphy@020c9000 { reg = <0x020c9000 0x1000>; interrupts = <0 44 0x04>; fsl,anatop = <&anatop>; + disconnect-line-without-vbus; };
This property is used to disconnect line between USB PHY and USB controller. Signed-off-by: Peter Chen <peter.chen@freescale.com> --- Documentation/devicetree/bindings/usb/mxs-phy.txt | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)