| Message ID | 1382421528-17897-2-git-send-email-peter.chen@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Oct 22, 2013 at 01:58:35PM +0800, Peter Chen wrote: > Since there are three mxs PHY versions, using three compatible > strings for them. > > Signed-off-by: Peter Chen <peter.chen@freescale.com> > --- > Documentation/devicetree/bindings/usb/mxs-phy.txt | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentation/devicetree/bindings/usb/mxs-phy.txt > index 5835b27..912d4ad 100644 > --- a/Documentation/devicetree/bindings/usb/mxs-phy.txt > +++ b/Documentation/devicetree/bindings/usb/mxs-phy.txt > @@ -1,7 +1,11 @@ > * Freescale MXS USB Phy Device > > Required properties: > -- compatible: Should be "fsl,imx23-usbphy" > +- compatible: there are three compatiable strings to stand for three s/compatiable/compatible > +mxs PHY verions. s/verions/versions > +"fsl,imx23-usbphy": for mx23 and mx28 > +"fsl,imx6q-usbphy": for mx6q and mx6dl > +"fsl,imx6sl-usbphy": for mx6sl and later mx6 soc serial s/serial/series Shawn > - reg: Should contain registers location and length > - interrupts: Should contain phy interrupt > > -- > 1.7.1 > >
On Tue, Oct 22, 2013 at 01:58:35PM +0800, Peter Chen wrote: > Since there are three mxs PHY versions, using three compatible > strings for them. > > Signed-off-by: Peter Chen <peter.chen@freescale.com> > --- > Documentation/devicetree/bindings/usb/mxs-phy.txt | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentation/devicetree/bindings/usb/mxs-phy.txt > index 5835b27..912d4ad 100644 > --- a/Documentation/devicetree/bindings/usb/mxs-phy.txt > +++ b/Documentation/devicetree/bindings/usb/mxs-phy.txt > @@ -1,7 +1,11 @@ > * Freescale MXS USB Phy Device > > Required properties: > -- compatible: Should be "fsl,imx23-usbphy" > +- compatible: there are three compatiable strings to stand for three > +mxs PHY verions. > +"fsl,imx23-usbphy": for mx23 and mx28 > +"fsl,imx6q-usbphy": for mx6q and mx6dl > +"fsl,imx6sl-usbphy": for mx6sl and later mx6 soc serial Also, please use string 'imx' rather than 'mx' for consistency. Shawn > - reg: Should contain registers location and length > - interrupts: Should contain phy interrupt > > -- > 1.7.1 > >
On Wed, Oct 23, 2013 at 01:56:00PM +0800, Shawn Guo wrote: > On Tue, Oct 22, 2013 at 01:58:35PM +0800, Peter Chen wrote: > > Since there are three mxs PHY versions, using three compatible > > strings for them. > > > > Signed-off-by: Peter Chen <peter.chen@freescale.com> > > --- > > Documentation/devicetree/bindings/usb/mxs-phy.txt | 6 +++++- > > 1 files changed, 5 insertions(+), 1 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentation/devicetree/bindings/usb/mxs-phy.txt > > index 5835b27..912d4ad 100644 > > --- a/Documentation/devicetree/bindings/usb/mxs-phy.txt > > +++ b/Documentation/devicetree/bindings/usb/mxs-phy.txt > > @@ -1,7 +1,11 @@ > > * Freescale MXS USB Phy Device > > > > Required properties: > > -- compatible: Should be "fsl,imx23-usbphy" > > +- compatible: there are three compatiable strings to stand for three > > +mxs PHY verions. > > +"fsl,imx23-usbphy": for mx23 and mx28 > > +"fsl,imx6q-usbphy": for mx6q and mx6dl > > +"fsl,imx6sl-usbphy": for mx6sl and later mx6 soc serial > > Also, please use string 'imx' rather than 'mx' for consistency. > Thanks, will change your two comments.
diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentation/devicetree/bindings/usb/mxs-phy.txt index 5835b27..912d4ad 100644 --- a/Documentation/devicetree/bindings/usb/mxs-phy.txt +++ b/Documentation/devicetree/bindings/usb/mxs-phy.txt @@ -1,7 +1,11 @@ * Freescale MXS USB Phy Device Required properties: -- compatible: Should be "fsl,imx23-usbphy" +- compatible: there are three compatiable strings to stand for three +mxs PHY verions. +"fsl,imx23-usbphy": for mx23 and mx28 +"fsl,imx6q-usbphy": for mx6q and mx6dl +"fsl,imx6sl-usbphy": for mx6sl and later mx6 soc serial - reg: Should contain registers location and length - interrupts: Should contain phy interrupt
Since there are three mxs PHY versions, using three compatible strings for them. Signed-off-by: Peter Chen <peter.chen@freescale.com> --- Documentation/devicetree/bindings/usb/mxs-phy.txt | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)