| Message ID | 1382533861-12688-1-git-send-email-dianders@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2013-10-23 14:11, Doug Anderson wrote: > Without the interrupt you'll get problems if you enable > CONFIG_RTC_DRV_MAX77686. Setup the interrupt properly in the device > tree. Awesome! Thanks for fixing this, Doug. My Chromebook is much happier now! > Signed-off-by: Doug Anderson <dianders@chromium.org> Tested-by: Marc Zyngier <marc.zyngier@arm.com> M. > --- > arch/arm/boot/dts/cros5250-common.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/cros5250-common.dtsi > b/arch/arm/boot/dts/cros5250-common.dtsi > index dc259e8b..9b186ac 100644 > --- a/arch/arm/boot/dts/cros5250-common.dtsi > +++ b/arch/arm/boot/dts/cros5250-common.dtsi > @@ -27,6 +27,13 @@ > i2c2_bus: i2c2-bus { > samsung,pin-pud = <0>; > }; > + > + max77686_irq: max77686-irq { > + samsung,pins = "gpx3-2"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > }; > > i2c@12C60000 { > @@ -35,6 +42,11 @@ > > max77686@09 { > compatible = "maxim,max77686"; > + interrupt-parent = <&gpx3>; > + interrupts = <2 0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&max77686_irq>; > + wakeup-source; > reg = <0x09>; > > voltage-regulators {
Olof or Kukjin, On Wed, Oct 23, 2013 at 6:11 AM, Doug Anderson <dianders@chromium.org> wrote: > Without the interrupt you'll get problems if you enable > CONFIG_RTC_DRV_MAX77686. Setup the interrupt properly in the device > tree. > > Signed-off-by: Doug Anderson <dianders@chromium.org> > --- > arch/arm/boot/dts/cros5250-common.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) Would one of you be interested in applying this to your tree, with Marc's "Tested-by"? I know there are lots more things to fixup in the dts, but this is one that I know works. ;) -Doug
On Mon, Nov 25, 2013 at 3:11 PM, Doug Anderson <dianders@chromium.org> wrote: > Olof or Kukjin, > > On Wed, Oct 23, 2013 at 6:11 AM, Doug Anderson <dianders@chromium.org> wrote: >> Without the interrupt you'll get problems if you enable >> CONFIG_RTC_DRV_MAX77686. Setup the interrupt properly in the device >> tree. >> >> Signed-off-by: Doug Anderson <dianders@chromium.org> >> --- >> arch/arm/boot/dts/cros5250-common.dtsi | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) > > Would one of you be interested in applying this to your tree, with > Marc's "Tested-by"? I know there are lots more things to fixup in the > dts, but this is one that I know works. ;) Yes, I'll apply this to fixes for 3.13, and mark it for stable 3.12 at least. -Olof
Olof Johansson wrote: > > On Mon, Nov 25, 2013 at 3:11 PM, Doug Anderson <dianders@chromium.org> > wrote: > > Olof or Kukjin, > > > > On Wed, Oct 23, 2013 at 6:11 AM, Doug Anderson <dianders@chromium.org> > wrote: > >> Without the interrupt you'll get problems if you enable > >> CONFIG_RTC_DRV_MAX77686. Setup the interrupt properly in the device > >> tree. > >> > >> Signed-off-by: Doug Anderson <dianders@chromium.org> > >> --- > >> arch/arm/boot/dts/cros5250-common.dtsi | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > > > > Would one of you be interested in applying this to your tree, with > > Marc's "Tested-by"? I know there are lots more things to fixup in the > > dts, but this is one that I know works. ;) > > Yes, I'll apply this to fixes for 3.13, and mark it for stable 3.12 at > least. > Olof, thanks. Please add my ack on this if you want. - Kukjin
diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi index dc259e8b..9b186ac 100644 --- a/arch/arm/boot/dts/cros5250-common.dtsi +++ b/arch/arm/boot/dts/cros5250-common.dtsi @@ -27,6 +27,13 @@ i2c2_bus: i2c2-bus { samsung,pin-pud = <0>; }; + + max77686_irq: max77686-irq { + samsung,pins = "gpx3-2"; + samsung,pin-function = <0>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; }; i2c@12C60000 { @@ -35,6 +42,11 @@ max77686@09 { compatible = "maxim,max77686"; + interrupt-parent = <&gpx3>; + interrupts = <2 0>; + pinctrl-names = "default"; + pinctrl-0 = <&max77686_irq>; + wakeup-source; reg = <0x09>; voltage-regulators {
Without the interrupt you'll get problems if you enable CONFIG_RTC_DRV_MAX77686. Setup the interrupt properly in the device tree. Signed-off-by: Doug Anderson <dianders@chromium.org> --- arch/arm/boot/dts/cros5250-common.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)