| Message ID | 1382699771-4396-2-git-send-email-maxime.ripard@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 10/25/13 04:16, Maxime Ripard wrote: > The clock event structure irq field was not filled previously to the > interrupt we're using. > > This was resulting in the timer not being used at all when using a > configuration with SMP enabled on a system with several CPUs, and with > the cpumask set to the cpu_possible_mask. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
On 10/25/2013 01:16 PM, Maxime Ripard wrote: > The clock event structure irq field was not filled previously to the > interrupt we're using. > > This was resulting in the timer not being used at all when using a > configuration with SMP enabled on a system with several CPUs, and with > the cpumask set to the cpu_possible_mask. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Applied to my tree for 3.14 > --- > drivers/clocksource/sun4i_timer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clocksource/sun4i_timer.c b/drivers/clocksource/sun4i_timer.c > index 2fb4695..a7f492e 100644 > --- a/drivers/clocksource/sun4i_timer.c > +++ b/drivers/clocksource/sun4i_timer.c > @@ -188,6 +188,7 @@ static void __init sun4i_timer_init(struct device_node *node) > writel(val | TIMER_IRQ_EN(0), timer_base + TIMER_IRQ_EN_REG); > > sun4i_clockevent.cpumask = cpumask_of(0); > + sun4i_clockevent.irq = irq; > > clockevents_config_and_register(&sun4i_clockevent, rate, > TIMER_SYNC_TICKS, 0xffffffff); >
diff --git a/drivers/clocksource/sun4i_timer.c b/drivers/clocksource/sun4i_timer.c index 2fb4695..a7f492e 100644 --- a/drivers/clocksource/sun4i_timer.c +++ b/drivers/clocksource/sun4i_timer.c @@ -188,6 +188,7 @@ static void __init sun4i_timer_init(struct device_node *node) writel(val | TIMER_IRQ_EN(0), timer_base + TIMER_IRQ_EN_REG); sun4i_clockevent.cpumask = cpumask_of(0); + sun4i_clockevent.irq = irq; clockevents_config_and_register(&sun4i_clockevent, rate, TIMER_SYNC_TICKS, 0xffffffff);
The clock event structure irq field was not filled previously to the interrupt we're using. This was resulting in the timer not being used at all when using a configuration with SMP enabled on a system with several CPUs, and with the cpumask set to the cpu_possible_mask. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- drivers/clocksource/sun4i_timer.c | 1 + 1 file changed, 1 insertion(+)