From patchwork Mon Nov 4 08:04:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 3134761 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id F1A9B9F3C4 for ; Mon, 4 Nov 2013 08:05:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 84EBC20347 for ; Mon, 4 Nov 2013 08:05:57 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 884C42031C for ; Mon, 4 Nov 2013 08:05:56 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VdFAM-0005eH-Sg; Mon, 04 Nov 2013 08:05:43 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VdFAK-0004CE-DW; Mon, 04 Nov 2013 08:05:40 +0000 Received: from mail-we0-f172.google.com ([74.125.82.172]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VdFAI-0004Bf-5p for linux-arm-kernel@lists.infradead.org; Mon, 04 Nov 2013 08:05:38 +0000 Received: by mail-we0-f172.google.com with SMTP id q58so1754287wes.3 for ; Mon, 04 Nov 2013 00:05:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dL8k6dICorJiC4OIz35bm7tOQAeO1d9LuSN0yzGtFEg=; b=bz8FGIiNVW3RMRBd1X5Fc4xLB8YT4vzoEr+UFNFooP9wPkpACGvq3F7mXHsz6JCZiq EBlItUyAM71z/dcVibK4xanjs4ftTblQJ6D56/sconpcli/it/BXcL2fteXDtWlJK1aI 73yaDUXh+BI2vuiVxOENFOM+KBkFASMCF3lC3tOI9yp2RgAMY8Ybb5E99sH9Gu0Xgqwi S1rzztcs6jojh1+4cUkHUVAP/3hUYoYbHcDhdjLfRCSI8Pz4UWWMDmm4eeuevOFWk/1b jfbgdU8zVfDHNsCsYAfUdIocbZyn3z/8QOmg4XYxP7KVJsrLLLnrBV12VRNf3UMp14ii VOkQ== X-Gm-Message-State: ALoCoQkKk4jBGGP60nbHPa97/N6jEgz7Emr5NDO0QQu8yuSH9sviXNyh9yJ7mN29pmsKJma1dEaO X-Received: by 10.180.93.166 with SMTP id cv6mr11114415wib.37.1383552308814; Mon, 04 Nov 2013 00:05:08 -0800 (PST) Received: from localhost.localdomain ([85.235.11.236]) by mx.google.com with ESMTPSA id q3sm1382679wib.5.2013.11.04.00.05.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Nov 2013 00:05:07 -0800 (PST) From: Linus Walleij To: arm@kernel.org Subject: [PATCH] ARM: footbridge: fix build warning Date: Mon, 4 Nov 2013 09:04:56 +0100 Message-Id: <1383552296-16275-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.8.3.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131104_030538_330440_1AE731EB X-CRM114-Status: UNSURE ( 9.82 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) Cc: Linus Walleij , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The raw spinlock in the netwinder GPIO implementation was using non-raw accessors, fix this warning from the autobuilder: arch/arm/mach-footbridge/netwinder-hw.c:695:2: warning: passing argument 1 of 'spinlock_check' from incompatible pointer type [enabled by default] arch/arm/mach-footbridge/netwinder-hw.c:702:2: warning: passing argument 1 of 'spin_unlock_irqrestore' from incompatible pointer type [enabled by default] arch/arm/mach-footbridge/netwinder-hw.c:712:2: warning: passing argument 1 of 'spinlock_check' from incompatible pointer type [enabled by default] arch/arm/mach-footbridge/netwinder-hw.c:714:2: warning: passing argument 1 of 'spin_unlock_irqrestore' from incompatible pointer type [enabled by default] Signed-off-by: Linus Walleij --- ARM SoC folks: please apply this directly to fixes. --- arch/arm/mach-footbridge/netwinder-hw.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-footbridge/netwinder-hw.c b/arch/arm/mach-footbridge/netwinder-hw.c index 1fd2cf097e30..eb1fa5c84723 100644 --- a/arch/arm/mach-footbridge/netwinder-hw.c +++ b/arch/arm/mach-footbridge/netwinder-hw.c @@ -692,14 +692,14 @@ static void netwinder_led_set(struct led_classdev *cdev, unsigned long flags; u32 reg; - spin_lock_irqsave(&nw_gpio_lock, flags); + raw_spin_lock_irqsave(&nw_gpio_lock, flags); reg = nw_gpio_read(); if (b != LED_OFF) reg &= ~led->mask; else reg |= led->mask; nw_gpio_modify_op(led->mask, reg); - spin_unlock_irqrestore(&nw_gpio_lock, flags); + raw_spin_unlock_irqrestore(&nw_gpio_lock, flags); } static enum led_brightness netwinder_led_get(struct led_classdev *cdev) @@ -709,9 +709,9 @@ static enum led_brightness netwinder_led_get(struct led_classdev *cdev) unsigned long flags; u32 reg; - spin_lock_irqsave(&nw_gpio_lock, flags); + raw_spin_lock_irqsave(&nw_gpio_lock, flags); reg = nw_gpio_read(); - spin_unlock_irqrestore(&nw_gpio_lock, flags); + raw_spin_unlock_irqrestore(&nw_gpio_lock, flags); return (reg & led->mask) ? LED_OFF : LED_FULL; }