diff mbox

[v3,04/11] ARM: dts: imx6: add anatop phandle for usbphy

Message ID 1383616183-10511-5-git-send-email-peter.chen@freescale.com (mailing list archive)
State New, archived
Headers show

Commit Message

Peter Chen Nov. 5, 2013, 1:49 a.m. UTC
Add anatop phandle for usbphy

Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
 arch/arm/boot/dts/imx6qdl.dtsi |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Shawn Guo Nov. 5, 2013, 2:41 a.m. UTC | #1
On Tue, Nov 05, 2013 at 09:49:36AM +0800, Peter Chen wrote:
> Add anatop phandle for usbphy
> 
> Signed-off-by: Peter Chen <peter.chen@freescale.com>
> ---
>  arch/arm/boot/dts/imx6qdl.dtsi |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Does imx6sl.dtsi need the same update?

Shawn

> 
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index 226ce75..bb79678 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -559,6 +559,7 @@
>  				reg = <0x020c9000 0x1000>;
>  				interrupts = <0 44 0x04>;
>  				clocks = <&clks 182>;
> +				fsl,anatop = <&anatop>;
>  			};
>  
>  			usbphy2: usbphy@020ca000 {
> @@ -566,6 +567,7 @@
>  				reg = <0x020ca000 0x1000>;
>  				interrupts = <0 45 0x04>;
>  				clocks = <&clks 183>;
> +				fsl,anatop = <&anatop>;
>  			};
>  
>  			snvs@020cc000 {
> -- 
> 1.7.1
> 
>
Peter Chen Nov. 5, 2013, 2:53 a.m. UTC | #2
On Tue, Nov 05, 2013 at 10:41:33AM +0800, Shawn Guo wrote:
> On Tue, Nov 05, 2013 at 09:49:36AM +0800, Peter Chen wrote:
> > Add anatop phandle for usbphy
> > 
> > Signed-off-by: Peter Chen <peter.chen@freescale.com>
> > ---
> >  arch/arm/boot/dts/imx6qdl.dtsi |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> Does imx6sl.dtsi need the same update?
> 

It is needed (for chipidea, it is the same), but I still have
no time to test on it. Will add them later.

Peter

> Shawn
> 
> > 
> > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> > index 226ce75..bb79678 100644
> > --- a/arch/arm/boot/dts/imx6qdl.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> > @@ -559,6 +559,7 @@
> >  				reg = <0x020c9000 0x1000>;
> >  				interrupts = <0 44 0x04>;
> >  				clocks = <&clks 182>;
> > +				fsl,anatop = <&anatop>;
> >  			};
> >  
> >  			usbphy2: usbphy@020ca000 {
> > @@ -566,6 +567,7 @@
> >  				reg = <0x020ca000 0x1000>;
> >  				interrupts = <0 45 0x04>;
> >  				clocks = <&clks 183>;
> > +				fsl,anatop = <&anatop>;
> >  			};
> >  
> >  			snvs@020cc000 {
> > -- 
> > 1.7.1
> > 
> >
Peter Chen Nov. 5, 2013, 3:02 a.m. UTC | #3
On Tue, Nov 05, 2013 at 11:16:57AM +0800, Shawn Guo wrote:
> On Tue, Nov 05, 2013 at 10:53:08AM +0800, Peter Chen wrote:
> > On Tue, Nov 05, 2013 at 10:41:33AM +0800, Shawn Guo wrote:
> > > On Tue, Nov 05, 2013 at 09:49:36AM +0800, Peter Chen wrote:
> > > > Add anatop phandle for usbphy
> > > > 
> > > > Signed-off-by: Peter Chen <peter.chen@freescale.com>
> > > > ---
> > > >  arch/arm/boot/dts/imx6qdl.dtsi |    2 ++
> > > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > > 
> > > Does imx6sl.dtsi need the same update?
> > > 
> > 
> > It is needed (for chipidea, it is the same), but I still have
> > no time to test on it. Will add them later.
> 
> So all "fsl,imx6sl-usbphy" code is untested so far?
> 
> Shawn

Yes, "fsl,imx23-usbphy" and "fsl,imx6q-usbphy" have been tested,
I will test imx6sl during this patchset review cycle.
Shawn Guo Nov. 5, 2013, 3:16 a.m. UTC | #4
On Tue, Nov 05, 2013 at 10:53:08AM +0800, Peter Chen wrote:
> On Tue, Nov 05, 2013 at 10:41:33AM +0800, Shawn Guo wrote:
> > On Tue, Nov 05, 2013 at 09:49:36AM +0800, Peter Chen wrote:
> > > Add anatop phandle for usbphy
> > > 
> > > Signed-off-by: Peter Chen <peter.chen@freescale.com>
> > > ---
> > >  arch/arm/boot/dts/imx6qdl.dtsi |    2 ++
> > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > Does imx6sl.dtsi need the same update?
> > 
> 
> It is needed (for chipidea, it is the same), but I still have
> no time to test on it. Will add them later.

So all "fsl,imx6sl-usbphy" code is untested so far?

Shawn
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index 226ce75..bb79678 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -559,6 +559,7 @@ 
 				reg = <0x020c9000 0x1000>;
 				interrupts = <0 44 0x04>;
 				clocks = <&clks 182>;
+				fsl,anatop = <&anatop>;
 			};
 
 			usbphy2: usbphy@020ca000 {
@@ -566,6 +567,7 @@ 
 				reg = <0x020ca000 0x1000>;
 				interrupts = <0 45 0x04>;
 				clocks = <&clks 183>;
+				fsl,anatop = <&anatop>;
 			};
 
 			snvs@020cc000 {