diff mbox

[V2,4/4] arm: socfgpa: make use of common scu_a9_get_base() interface

Message ID 1383794204-4714-5-git-send-email-jszhang@marvell.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jisheng Zhang Nov. 7, 2013, 3:16 a.m. UTC
Make use of common scu_a9_get_base() and delete the comment since the
interface is self commented.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm/mach-socfpga/socfpga.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Dinh Nguyen Nov. 11, 2013, 11:24 p.m. UTC | #1
On Thu, 2013-11-07 at 11:16 +0800, Jisheng Zhang wrote:
> Make use of common scu_a9_get_base() and delete the comment since the
> interface is self commented.
> 
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
>  arch/arm/mach-socfpga/socfpga.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-socfpga/socfpga.c b/arch/arm/mach-socfpga/socfpga.c
> index bfce964..b695887 100644
> --- a/arch/arm/mach-socfpga/socfpga.c
> +++ b/arch/arm/mach-socfpga/socfpga.c
> @@ -24,6 +24,7 @@
>  #include <asm/hardware/cache-l2x0.h>
>  #include <asm/mach/arch.h>
>  #include <asm/mach/map.h>
> +#include <asm/smp_scu.h>
>  
>  #include "core.h"
>  
> @@ -51,8 +52,7 @@ static void __init socfpga_scu_map_io(void)
>  {
>  	unsigned long base;
>  
> -	/* Get SCU base */
> -	asm("mrc p15, 4, %0, c15, c0, 0" : "=r" (base));
> +	base = scu_a9_get_base();
>  
>  	scu_io_desc.pfn = __phys_to_pfn(base);
>  	iotable_init(&scu_io_desc, 1);

Acked-by: Dinh Nguyen <dinguyen@altera.com>

Thanks,
diff mbox

Patch

diff --git a/arch/arm/mach-socfpga/socfpga.c b/arch/arm/mach-socfpga/socfpga.c
index bfce964..b695887 100644
--- a/arch/arm/mach-socfpga/socfpga.c
+++ b/arch/arm/mach-socfpga/socfpga.c
@@ -24,6 +24,7 @@ 
 #include <asm/hardware/cache-l2x0.h>
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
+#include <asm/smp_scu.h>
 
 #include "core.h"
 
@@ -51,8 +52,7 @@  static void __init socfpga_scu_map_io(void)
 {
 	unsigned long base;
 
-	/* Get SCU base */
-	asm("mrc p15, 4, %0, c15, c0, 0" : "=r" (base));
+	base = scu_a9_get_base();
 
 	scu_io_desc.pfn = __phys_to_pfn(base);
 	iotable_init(&scu_io_desc, 1);