diff mbox

[2/2] ARM: highbank: only select errata 764369 if SMP

Message ID 1384389974-6229-2-git-send-email-olof@lixom.net (mailing list archive)
State New, archived
Headers show

Commit Message

Olof Johansson Nov. 14, 2013, 12:46 a.m. UTC
764369 depends on SMP, so don't select it on !SMP configs.

Signed-off-by: Olof Johansson <olof@lixom.net>
Cc: Rob Herring <rob.herring@calxeda.com>
---
 arch/arm/mach-highbank/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Herring Nov. 14, 2013, 12:51 a.m. UTC | #1
On 11/13/2013 06:46 PM, Olof Johansson wrote:
> 764369 depends on SMP, so don't select it on !SMP configs.

I think Russell has a fix for these in his tree.

Rob

> 
> Signed-off-by: Olof Johansson <olof@lixom.net>
> Cc: Rob Herring <rob.herring@calxeda.com>
> ---
>  arch/arm/mach-highbank/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-highbank/Kconfig b/arch/arm/mach-highbank/Kconfig
> index fe98df44579c..6e1d72326454 100644
> --- a/arch/arm/mach-highbank/Kconfig
> +++ b/arch/arm/mach-highbank/Kconfig
> @@ -6,7 +6,7 @@ config ARCH_HIGHBANK
>  	select ARCH_HAS_OPP
>  	select ARCH_WANT_OPTIONAL_GPIOLIB
>  	select ARM_AMBA
> -	select ARM_ERRATA_764369
> +	select ARM_ERRATA_764369 if SMP
>  	select ARM_ERRATA_775420
>  	select ARM_ERRATA_798181
>  	select ARM_GIC
>
Russell King - ARM Linux Nov. 14, 2013, 12:54 a.m. UTC | #2
On Wed, Nov 13, 2013 at 06:51:36PM -0600, Rob Herring wrote:
> On 11/13/2013 06:46 PM, Olof Johansson wrote:
> > 764369 depends on SMP, so don't select it on !SMP configs.
> 
> I think Russell has a fix for these in his tree.

Not this one.  I have:

	select ARM_ERRATA_798181 if SMP

for highbank, which is now in mainline.  Olof's patch is in response to
me pasting the Kconfig warning from last nights failed omap4 randconfig
build.  This wasn't the cause, but it's something that should be fixed
in any case.

(There's build failures in drivers/usb/gadget...)
Rob Herring Nov. 14, 2013, 1:02 a.m. UTC | #3
On 11/13/2013 06:54 PM, Russell King - ARM Linux wrote:
> On Wed, Nov 13, 2013 at 06:51:36PM -0600, Rob Herring wrote:
>> On 11/13/2013 06:46 PM, Olof Johansson wrote:
>>> 764369 depends on SMP, so don't select it on !SMP configs.
>>
>> I think Russell has a fix for these in his tree.
> 
> Not this one.  I have:
> 
> 	select ARM_ERRATA_798181 if SMP
> 
> for highbank, which is now in mainline.  Olof's patch is in response to
> me pasting the Kconfig warning from last nights failed omap4 randconfig
> build.  This wasn't the cause, but it's something that should be fixed
> in any case.

In that case:

Acked-by: Rob Herring <rob.herring@calxeda.com>

> 
> (There's build failures in drivers/usb/gadget...)
>
Olof Johansson Nov. 14, 2013, 1:05 a.m. UTC | #4
On Wed, Nov 13, 2013 at 5:02 PM, Rob Herring <robherring2@gmail.com> wrote:
> On 11/13/2013 06:54 PM, Russell King - ARM Linux wrote:
>> On Wed, Nov 13, 2013 at 06:51:36PM -0600, Rob Herring wrote:
>>> On 11/13/2013 06:46 PM, Olof Johansson wrote:
>>>> 764369 depends on SMP, so don't select it on !SMP configs.
>>>
>>> I think Russell has a fix for these in his tree.
>>
>> Not this one.  I have:
>>
>>       select ARM_ERRATA_798181 if SMP
>>
>> for highbank, which is now in mainline.  Olof's patch is in response to
>> me pasting the Kconfig warning from last nights failed omap4 randconfig
>> build.  This wasn't the cause, but it's something that should be fixed
>> in any case.
>
> In that case:
>
> Acked-by: Rob Herring <rob.herring@calxeda.com>

Thanks!

-Olof
diff mbox

Patch

diff --git a/arch/arm/mach-highbank/Kconfig b/arch/arm/mach-highbank/Kconfig
index fe98df44579c..6e1d72326454 100644
--- a/arch/arm/mach-highbank/Kconfig
+++ b/arch/arm/mach-highbank/Kconfig
@@ -6,7 +6,7 @@  config ARCH_HIGHBANK
 	select ARCH_HAS_OPP
 	select ARCH_WANT_OPTIONAL_GPIOLIB
 	select ARM_AMBA
-	select ARM_ERRATA_764369
+	select ARM_ERRATA_764369 if SMP
 	select ARM_ERRATA_775420
 	select ARM_ERRATA_798181
 	select ARM_GIC