| Message ID | 1384396537-3486-5-git-send-email-tony@atomide.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Nov 13, 2013 at 06:35:33PM -0800, Tony Lindgren wrote: > As we claim to support device tree for mach-omap2, we > should have the necessary flags in the driver to make it > usable. > > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: linux-i2c@vger.kernel.org > Signed-off-by: Tony Lindgren <tony@atomide.com> Acked-by: Wolfram Sang <wsa@the-dreams.de> It would have been helpful if the message "PATCH [0/x]" would have been sent to the i2c-list also. Thanks, Wolfram
On Thu, Nov 14, 2013 at 02:35:33AM +0000, Tony Lindgren wrote: > As we claim to support device tree for mach-omap2, we > should have the necessary flags in the driver to make it > usable. > > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: linux-i2c@vger.kernel.org > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > > If this looks OK, I'd like to merge this as a fix via arm-soc tree > along with the other patches in this series as my later patches > depend on patches in this series. > > --- > drivers/i2c/busses/i2c-omap.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) [...] > + { > + .compatible = "ti,omap2430-i2c", > + .data = &omap2430_pdata, > + }, > + { > + .compatible = "ti,omap2420-i2c", > + .data = &omap2420_pdata, Please update Documentation/devicetree/bindings/i2c/i2c-omap.txt Otherwise, this is fine. Thanks, Mark.
* Wolfram Sang <wsa@the-dreams.de> [131113 22:59]: > On Wed, Nov 13, 2013 at 06:35:33PM -0800, Tony Lindgren wrote: > > As we claim to support device tree for mach-omap2, we > > should have the necessary flags in the driver to make it > > usable. > > > > Cc: Wolfram Sang <wsa@the-dreams.de> > > Cc: linux-i2c@vger.kernel.org > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > Acked-by: Wolfram Sang <wsa@the-dreams.de> > > It would have been helpful if the message "PATCH [0/x]" would have been > sent to the i2c-list also. Thanks, next time I'll try check the cc list in the cover letter manually after running git format patch. I guess there's no way to deal with that in an automated way. Here's a link to the whole thread for reference: http://www.spinics.net/lists/arm-kernel/msg286246.html
> > It would have been helpful if the message "PATCH [0/x]" would have been > > sent to the i2c-list also. > > Thanks, next time I'll try check the cc list in the cover letter > manually after running git format patch. I guess there's no way > to deal with that in an automated way. I use this hackish script as --cc-cmd with git: #! /bin/sh # # cocci_cc - send cover letter to all mailing lists referenced in a patch series # done by Wolfram Sang in 2012 - WTFPLv2 name=${1##*/} num=${name%%-*} if [ "$num" = "0000" ]; then dir=${1%/*} for f in $dir/*; do patchname=${f##*/} [ "${patchname%%-*}" = "0000" ] && continue scripts/get_maintainer.pl --no-m $f done | sort -u else scripts/get_maintainer.pl $1 fi
* Wolfram Sang <wsa@the-dreams.de> [131114 09:49]: > > > > It would have been helpful if the message "PATCH [0/x]" would have been > > > sent to the i2c-list also. > > > > Thanks, next time I'll try check the cc list in the cover letter > > manually after running git format patch. I guess there's no way > > to deal with that in an automated way. > > I use this hackish script as --cc-cmd with git: > > #! /bin/sh > # > # cocci_cc - send cover letter to all mailing lists referenced in a patch series > # done by Wolfram Sang in 2012 - WTFPLv2 > > name=${1##*/} > num=${name%%-*} > > if [ "$num" = "0000" ]; then > dir=${1%/*} > for f in $dir/*; do > patchname=${f##*/} > [ "${patchname%%-*}" = "0000" ] && continue > scripts/get_maintainer.pl --no-m $f > done | sort -u > else > scripts/get_maintainer.pl $1 > fi > Cool thanks :) I'll give it a try next time. Tony
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 9967a6f..f04afd1 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -1037,6 +1037,20 @@ static const struct i2c_algorithm omap_i2c_algo = { }; #ifdef CONFIG_OF +static struct omap_i2c_bus_platform_data omap2420_pdata = { + .rev = OMAP_I2C_IP_VERSION_1, + .flags = OMAP_I2C_FLAG_NO_FIFO | + OMAP_I2C_FLAG_SIMPLE_CLOCK | + OMAP_I2C_FLAG_16BIT_DATA_REG | + OMAP_I2C_FLAG_BUS_SHIFT_2, +}; + +static struct omap_i2c_bus_platform_data omap2430_pdata = { + .rev = OMAP_I2C_IP_VERSION_1, + .flags = OMAP_I2C_FLAG_BUS_SHIFT_2 | + OMAP_I2C_FLAG_FORCE_19200_INT_CLK, +}; + static struct omap_i2c_bus_platform_data omap3_pdata = { .rev = OMAP_I2C_IP_VERSION_1, .flags = OMAP_I2C_FLAG_BUS_SHIFT_2, @@ -1055,6 +1069,14 @@ static const struct of_device_id omap_i2c_of_match[] = { .compatible = "ti,omap3-i2c", .data = &omap3_pdata, }, + { + .compatible = "ti,omap2430-i2c", + .data = &omap2430_pdata, + }, + { + .compatible = "ti,omap2420-i2c", + .data = &omap2420_pdata, + }, { }, }; MODULE_DEVICE_TABLE(of, omap_i2c_of_match);
As we claim to support device tree for mach-omap2, we should have the necessary flags in the driver to make it usable. Cc: Wolfram Sang <wsa@the-dreams.de> Cc: linux-i2c@vger.kernel.org Signed-off-by: Tony Lindgren <tony@atomide.com> --- If this looks OK, I'd like to merge this as a fix via arm-soc tree along with the other patches in this series as my later patches depend on patches in this series. --- drivers/i2c/busses/i2c-omap.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)